Fails to download Proxy Verifier

[maskit]

If you get a snapshot of the repo as a zip file or one of official releases, autest.sh fails to download proxy verifier, and the failure doesn't stop autest.sh.

$ curl -LO https://github.com/apache/trafficserver/archive/refs/heads/master.zip
$ unzip master.zip
$ cd trafficserver-master/tests/
$ ./autest.sh
fatal: not a git repository (or any of the parent directories): .git
cat: /tests/proxy-verifier-version.txt: No such file or directory
mkdir: /tests: Read-only file system
Warning: Failed to open the file /tests/proxy-verifier/proxy-verifier-.tar.gz:                                                                                                            
Warning: No such file or directory
#################################################################################################################################################################################### 100.0%curl: (23) Failure writing output to destination

./prepare_proxy_verifier.sh: line 56: /tests/proxy-verifier/sha1: No such file or directory
shasum: /tests/proxy-verifier/sha1: No such file or directory
SHA1 mismatch for downloaded proxy-verifier-.tar.gz.
Python 3.6 or newer detected!
python3-dev/devel detected!
pipenv detected!
Installing a new virtual environment via pipenv
Warning: the environment variable LANG is not set!
We recommend setting this in ~/.profile (or equivalent) for proper expected behavior.
Creating a virtualenv for this project...
{snip}

[maskit]

I could set $ROOT beforehand to avoid the issue, but I don't understand why the path for "proxy-verifier-version.txt" is checked like this. Is there a case that we want to have "prepare_proxy_verifier.sh" and "proxy-verifier-version.txt" in different directories?

[bneradt]

This is a good observation. I've never tried to work with this from a non-git directory. When I wrote prepare_proxy_verifier.sh, I borrowed its logic from our pre-commit hooks which is why it is written as it is. I'll work on making the prepare_proxy_verifier.sh logic more generic.