Skip to content

Proxy Protocol strings have dest and src reversed #9335

Description

@bneradt

I noticed that when we configure ATS to send Proxy Protocol via proxy.config.http.proxy_protocol_out, our Proxy Protocol strings have src and dest descriptions reversed:

info = ProxyProtocol{pp_version, local.family(), local, vc_in->get_remote_endpoint()};

We should pass vc_in->get_remote_endpoint() (which is the client's src address) before local (which is the client's dest address).

I have an internal Yahoo patch I'm working on for this with an AuTest that I plan to opensource soon.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions