Make sure open() and read() succeeded - #10273
Merged
Merged
Conversation
duke8253
force-pushed
the
master-check_fd
branch
from
August 23, 2023 20:17
09107bd to
85a723c
Compare
duke8253
force-pushed
the
master-check_fd
branch
2 times, most recently
from
August 24, 2023 15:30
8bb5fd2 to
b718b6a
Compare
duke8253
force-pushed
the
master-check_fd
branch
from
August 24, 2023 15:32
b718b6a to
12ef163
Compare
This was
linked to
issues
Aug 24, 2023
Contributor
Author
|
[approve ci] |
masaori335
previously approved these changes
Aug 28, 2023
Contributor
There was a problem hiding this comment.
Looks good, please fix the sign-compare warning.
experimental/ssl_session_reuse/src/ssl_init.cc:118:60: error: comparison of integer expressions of different signedness: 'long int' and 'std::__cxx11::basic_string<char>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
118 | if (read_len > 0 && read_len <= buffSize && read_len <= key_data.length()) {
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
duke8253
force-pushed
the
master-check_fd
branch
from
August 28, 2023 18:17
12ef163 to
d4176cf
Compare
duke8253
force-pushed
the
master-check_fd
branch
from
August 28, 2023 22:43
d4176cf to
d6c411e
Compare
shinrich
approved these changes
Sep 25, 2023
ezelkow1
pushed a commit
that referenced
this pull request
Sep 15, 2026
* Backport Clang 21 analyzer fixes to 9.2.x Newer Clang releases expose ownership and error-handling issues in 9.2.x as well as file I/O performed while holding the body factory lock. This patch adapts the applicable fixes from #13593 to the older source layout and APIs. CMake and changes to code absent from 9.2.x are omitted. (cherry picked from commit c31517c) * Backport earlier Clang analyzer fixes to 9.2.x The older branch still contains uninitialized error values and cache volume indices flagged by the analyzer. This patch adapts #12226 to initialize those values, verify the freelist element size before division, and remove dead initializers. (cherry picked from commit 0cf0f3e) * Backport session reuse key-file checks Missing or unreadable Redis authentication key files can leave invalid file descriptors and read lengths in the session reuse plugin. This patch backports the key-file checks from #10273 and closes the file only when it was opened successfully. Configuration-file handling is addressed separately for the older branch. (cherry picked from commit 26affda) * Backport header rewrite rule ownership fix Incomplete header rewrite rules can leak when configuration parsing ends without handing the rule to the configuration. This patch adapts #11386 to keep temporary rules under unique ownership until the configuration accepts them. (cherry picked from commit 0887836) * 9.2.x: latest clang-analyzer fixes The Ubuntu 26.04 clang-analyzer job exposes unchecked I/O, a rule leak, and configuration reads under a mutex in the older 9.2.x code. This branch backports the applicable fixes from #13593, #12226, #10273, and #11386. The remaining changes handle file and socket failures, keep session reuse configuration I/O outside the reader lock, and make the nonblocking eventfd operation explicit to the analyzer. * Address review findings and isolate TLS autest A full-size Redis key leaves no room for its terminator, and failed configuration reloads can repeat file I/O on every lookup. Modern Fedora policy also prevents the TLS autest from exercising TLS 1.0. This patch tightens the key bound, restores timestamp-gated reloads, clarifies configuration publication, and guards device-dependent checks. The TLS test uses isolated OpenSSL settings and RSA key exchange so all four protocol checks remain active. --------- Co-authored-by: Hiroaki Nakamura <hnakamur@gmail.com> Co-authored-by: Fei Deng <feid@yahooinc.com> Co-authored-by: Bryan Call <bcall@apache.org> Co-authored-by: bneradt <bneradt@yahooinc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the following issues: