Abort a read when the disk is known to be bad - #10286
Merged
Merged
Conversation
Reads on a known bad disk can read corrupt cache metadata, which causes a crash. Abort reads early on a bad disk so that ATS is less likely to crash after a disk is marked bad.
Member
|
Perhaps this should go before trying the lock. Do you really want to reschedule for the lock if the disk is bad? |
Contributor
Author
|
[approve ci rocky] |
SolidWallOfCode
previously approved these changes
Sep 18, 2023
SolidWallOfCode
left a comment
Member
There was a problem hiding this comment.
The new code should really be outside the brace at line 2182, because that's for scoping the mutex. You can commit this or I'll approve an update with that change.
Contributor
Author
Sounds good. I moved it. |
SolidWallOfCode
approved these changes
Sep 18, 2023
Contributor
|
Cherry-picked to v9.2.x |
zwoop
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Abort a read when the disk is known to be bad Reads on a known bad disk can read corrupt cache metadata, which causes a crash. Abort reads early on a bad disk so that ATS is less likely to crash after a disk is marked bad. (cherry picked from commit bc8bfa6)
traeak
pushed a commit
to traeak/trafficserver
that referenced
this pull request
Dec 15, 2023
* Abort a read when the disk is known to be bad Reads on a known bad disk can read corrupt cache metadata, which causes a crash. Abort reads early on a bad disk so that ATS is less likely to crash after a disk is marked bad. (cherry picked from commit bc8bfa6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reads on a known bad disk can read corrupt cache metadata, which causes a crash. Abort reads early on a bad disk so that ATS is less likely to crash after a disk is marked bad.