Move InkAPI.cc into src/api - #10315
Merged
Merged
Conversation
lzx404243
force-pushed
the
plugin-api-rebased
branch
2 times, most recently
from
August 30, 2023 22:46
3b67f17 to
696095e
Compare
lzx404243
force-pushed
the
plugin-api-rebased
branch
5 times, most recently
from
September 6, 2023 18:58
1050ad1 to
5be9b98
Compare
lzx404243
marked this pull request as ready for review
September 7, 2023 15:36
lzx404243
force-pushed
the
plugin-api-rebased
branch
from
September 11, 2023 14:40
f7f2ac1 to
44b9f90
Compare
lzx404243
force-pushed
the
plugin-api-rebased
branch
from
September 12, 2023 17:49
b516bcf to
69b127a
Compare
cmcfarlen
approved these changes
Sep 12, 2023
cmcfarlen
left a comment
Contributor
There was a problem hiding this comment.
Great progress on cleanup efforts! Thanks!
Collaborator
Author
|
@cmcfarlen Thanks for the review and all the suggestions! |
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
This PR moves InkAPI.cc into src/api, so that it's built into the libtsapi.so. A new libtsapicore.a is created to separate out the stuff also used in the core(e.g. Metrics) from the high-level plugin APIs. Also moved some files around: * Moved Hoststatus.cc from src/traffic_server/ to proxy/ where the header is. * Moved FetchSM.h/cc from src/traffic_server/ to include/api and src/api respectively. * Moved InkContInternal.cc and InkIOCoreAPI.cc from src/traffic_server/ to src/api. * Moved InkAPIInternal.h from proxy/ to include/api.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* commit '236b749b2b3cc746829ad534a7034ab7799d1b71': Allow origins to do TLS renegotiation (apache#10385) Remove deprecated debug output functions from 21 source files. (apache#9683) Fixes some make test build problems (apache#10402) Removes unused Errata functions from WCCP (apache#10380) Move InkAPI.cc into src/api (apache#10315) cmake: Generate files in rc, install the trafficserver script (apache#10367) Add support for OCSP requests by GET method (apache#10306) Preserve unmapped url regardless of need for remapping (apache#10304) Add TSVConnFdGet api (apache#10324) include/ts: comma on all last enum elements (apache#10400) cmake: Add remaining plugins without external deps (apache#10395) CID-1508974 (apache#10397) CID-1508987 (apache#10398) Coverity 1518564: fix off by one (apache#10401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves InkAPI.cc into src/api, so that it's built into the libtsapi.so. A new
libtsapicore.ais created to separate out the stuff also used in the core(e.g. Metrics) from the high-level plugin APIs.Also moved some files around:
Hoststatus.ccfromsrc/traffic_server/toproxy/where the header is.FetchSM.h/ccfromsrc/traffic_server/toinclude/apiandsrc/apirespectively.InkContInternal.ccandInkIOCoreAPI.ccfromsrc/traffic_server/tosrc/api.InkAPIInternal.hfromproxy/toinclude/api.