Add assert of CacheDisk is not nullptr - #10704
Merged
Merged
Conversation
zwoop
previously approved these changes
Nov 1, 2023
masaori335
force-pushed
the
fix-odd-clang-analyzer
branch
from
November 1, 2023 01:41
68d6f71 to
1a965c9
Compare
masaori335
force-pushed
the
fix-odd-clang-analyzer
branch
from
November 1, 2023 01:49
1a965c9 to
ec82096
Compare
ywkaras
approved these changes
Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make clang-analyer happy.
We faced odd warning report with clang-analyer at #10694.
If I run clang-analyer against the master branch with below change locally, it also reports the same. My guess is the Metircs related change made clang-analyzer confused.
As @ywkaras suggested in the PR, the warning is gone with this assert.
/cc @zwoop