Updated SSLSNIConfig to use the Regex class (pcre2) - #12219
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the regex functionality in SSLSNIConfig to use the new Regex class based on PCRE2 instead of legacy PCRE usage. It introduces a move assignment operator and an empty() helper in the Regex class, updates regex compilation and execution in SSLSNIConfig, and removes obsolete PCRE includes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tsutil/Regex.cc | Added move assignment operator and empty() method; adjusted exec() behavior to update match vector size. |
| include/tsutil/Regex.h | Added declaration for move assignment operator and empty() method. |
| src/iocore/net/SSLSNIConfig.cc | Replaced PCRE API calls with Regex class methods and updated capture groups handling. |
| include/iocore/net/SSLSNIConfig.h | Removed PCRE header inclusion and updated NamedElement's regex member to use Regex. |
bryancall
marked this pull request as draft
May 5, 2025 16:00
1 task
Contributor
Author
|
[approve ci] |
bryancall
marked this pull request as ready for review
May 22, 2025 15:06
Contributor
Author
|
[approve ci] |
1 similar comment
Contributor
Author
|
[approve ci] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated testing before this PR: #12248