Remove PCRE references, complete migration to PCRE2 - #12685
Merged
Merged
Conversation
Contributor
Author
|
This PR addresses parts of #8780 by removing remaining PCRE references from the codebase. Specifically, this completes the cleanup for:
All CMakeLists.txt files now exclusively reference PCRE2, and the obsolete FindPCRE.cmake has been removed. |
bryancall
force-pushed
the
remove-pcre-refs
branch
from
November 21, 2025 18:24
355e940 to
db1171a
Compare
- Remove cmake/FindPCRE.cmake (no longer needed) - Update all CMakeLists.txt files to use PkgConfig::PCRE2 instead of PCRE::PCRE - Remove find_package(PCRE) from main CMakeLists.txt - Update code comments from PCRE to PCRE2 in plugin sources - Update coverity model from PCRE to PCRE2 API - Update README example to remove obsolete PCRE_ROOT reference - Update tools/hrw4u/src/lsp/documentation.py to reference PCRE2 - Note: cripts::Matcher::PCRE class name intentionally unchanged (public API) This completes the transition from PCRE (version 1) to PCRE2 throughout the Apache Traffic Server codebase.
bryancall
force-pushed
the
remove-pcre-refs
branch
from
November 21, 2025 18:28
db1171a to
510a535
Compare
Cleaned up PCRE2 linking throughout the codebase: - Use RE_ERROR_NOMATCH from tsutil instead of PCRE2_ERROR_NOMATCH in ControlMatcher to properly use the Regex wrapper - Remove direct pcre2.h include from ControlMatcher.h - Remove redundant PCRE2 links from components that get it transitively through tsutil (tscore, tsapi) - Remove redundant PCRE2 links from plugins that only use tsutil/Regex.h (cachekey, prefetch, slice, tls_bridge) Only components that directly use PCRE2 APIs (tsutil, cripts, txn_box) should explicitly link PCRE2. Others get it transitively through tsutil which publicly exports PCRE2.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the migration from PCRE (version 1) to PCRE2 throughout the Apache Traffic Server codebase by removing all remaining PCRE references.
Fixes #8780
Changes
cmake/FindPCRE.cmake(no longer needed)PkgConfig::PCRE2instead ofPCRE::PCREfind_package(PCRE)from main CMakeLists.txtPCRE_ROOTreferenceNotes
cripts::Matcher::PCREclass name is intentionally unchanged as it's part of the public APITesting
The changes are primarily code comments and build system updates. All existing PCRE2 functionality remains intact.