Skip to content

Check state of HostDBInfo #12880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masaori335 merged 3 commits into from
Feb 23, 2026
Merged

Check state of HostDBInfo #12880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93750d9
Check state of HostDBInfo
masaori335 Feb 12, 2026
5c10920
Adjust AuTest
masaori335 Feb 16, 2026
67c4c6e
Cleanup: use select function for consistency
masaori335 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/iocore/hostdb/HostDB.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,9 @@ HostDBRecord::select_best_http(ts_time now, ts_seconds fail_window, sockaddr con
}
}
} else {
best_alive = &info[0];
if (info[0].select(now, fail_window)) {
best_alive = &info[0];
}
}

return best_alive;
Expand Down
14 changes: 1 addition & 13 deletions tests/gold_tests/dns/dns_host_down.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,24 +55,13 @@ def _configure_trafficserver(self):
'proxy.config.hostdb.host_file.path': os.path.join(Test.TestDirectory, "hosts_file"),
})

# Even when the origin server is down, SM will return a hit-fresh domain from HostDB.
# After request has failed, SM should mark the IP as down
def _test_host_mark_down(self):
tr = Test.AddTestRun()

tr.Processes.Default.StartBefore(self._server)
tr.Processes.Default.StartBefore(self._ts)

tr.AddVerifierClientProcess(
"client-1", DownCachedOriginServerTest.replay_file, http_ports=[self._ts.Variables.port], other_args='--keys 1')

# After host has been marked down from previous test, HostDB should not return
# the host as available and DNS lookup should fail.
def _test_host_unreachable(self):
tr = Test.AddTestRun()

tr.AddVerifierClientProcess(
"client-2", DownCachedOriginServerTest.replay_file, http_ports=[self._ts.Variables.port], other_args='--keys 2')
tr.AddVerifierClientProcess("client-1", DownCachedOriginServerTest.replay_file, http_ports=[self._ts.Variables.port])

# Verify error log marking host down exists
def _test_error_log(self):
Expand All @@ -86,7 +75,6 @@ def _test_error_log(self):

def run(self):
self._test_host_mark_down()
self._test_host_unreachable()
self._test_error_log()


Expand Down
5 changes: 4 additions & 1 deletion tests/gold_tests/dns/replay/server_down.replay.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ sessions:
status: 200

# Returns 502 since server connection is unreachable
# This transaction should mark the IP as down
proxy-response:
status: 502

Expand All @@ -55,5 +56,7 @@ sessions:
server-response:
status: 200

# After host has been marked down from previous test, HostDB should not return
# the host as available and HostDB lookup should fail.
proxy-response:
status: 502
status: 500