Skip to content

Update to Proxy Verifier v3.0.0 - #12990

Merged
bneradt merged 2 commits into
apache:masterfrom
bneradt:pv_v300
Mar 19, 2026
Merged

bneradt merged 2 commits into
apache:masterfrom
bneradt:pv_v300

Conversation

@bneradt

@bneradt bneradt commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

This will require #12986 in order to fix many of our replay files that specify verification rules for transactions that are not seen. With Proxy Verifier v3.0.0 these now generate an error message.

This also includes a duplicate header update for a verification change for such header fiels in Proxy Verifier v3.0.0.

bneradt added 2 commits March 18, 2026 20:33
The latest proxy-verifier combines duplicate header values during
equality checks unless the replay uses duplicate-aware
verification. cachedDuplicateHeaders still expected the older
rendering, so the AuTest failed even though ATS behavior had not
changed.

Update the replay expectation to match the current duplicate
header matching behavior. This keeps the test validating cached
header handling against the latest proxy-verifier semantics.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Apache Traffic Server’s AuTest integration to use Proxy Verifier v3.0.0, including the corresponding download hashes and a replay adjustment to match v3’s header verification behavior.

Changes:

  • Bump Proxy Verifier from v2.12.0 to v3.0.0 across test tooling/config.
  • Update the expected SHA1 for the v3.0.0 Proxy Verifier tarball.
  • Adjust a header replay expectation to align with v3.0.0 duplicate-header verification output.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/proxy-verifier-version.txt Updates the Proxy Verifier version used by test setup scripts.
tests/prepare_proxy_verifier.sh Updates the expected SHA1 for the downloaded Proxy Verifier tarball.
tests/gold_tests/headers/replays/cache-test.replay.yaml Updates expected duplicate-header values for v3 verification behavior.
CMakeLists.txt Bumps the CMake-controlled Proxy Verifier version/hash used when ENABLE_AUTEST is enabled.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread CMakeLists.txt
@bneradt
bneradt requested review from masaori335 and removed request for zwoop March 19, 2026 04:32

@masaori335 masaori335 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you.

@bneradt
bneradt merged commit 886e360 into apache:master Mar 19, 2026
19 checks passed
@bneradt
bneradt deleted the pv_v300 branch March 19, 2026 14:58
@github-project-automation github-project-automation Bot moved this to For v10.2.0 in ATS v10.2.x Mar 19, 2026
@cmcfarlen cmcfarlen moved this from For v10.2.0 to Picked v10.2.0 in ATS v10.2.x Mar 23, 2026
@cmcfarlen cmcfarlen modified the milestones: 11.0.0, 10.2.0 Mar 23, 2026
@cmcfarlen

Copy link
Copy Markdown
Contributor

Cherry-picked to 10.2.x

cmcfarlen pushed a commit that referenced this pull request Mar 23, 2026
This updates our use of Proxy Verifier to version v3.0.0.

This also requires updating cachedDuplicateHeaders.

The latest proxy-verifier combines duplicate header values during
equality checks unless the replay uses duplicate-aware
verification. cachedDuplicateHeaders still expected the older
rendering, so the AuTest failed even though ATS behavior had not
changed.

Update the replay expectation to match the current duplicate
header matching behavior. This keeps the test validating cached
header handling against the latest proxy-verifier semantics.

(cherry picked from commit 886e360)
@github-project-automation github-project-automation Bot moved this to For v10.1.1 in ATS v10.1.x Jun 10, 2026
@cmcfarlen cmcfarlen moved this from For v10.1.1 to Picked v10.1.1 in ATS v10.1.x Jun 10, 2026
@cmcfarlen cmcfarlen modified the milestones: 10.2.0, 10.1.3 Jun 10, 2026
@cmcfarlen

Copy link
Copy Markdown
Contributor

Cherry-picked to 10.1.x branch

cmcfarlen pushed a commit that referenced this pull request Jun 10, 2026
This updates our use of Proxy Verifier to version v3.0.0.

This also requires updating cachedDuplicateHeaders.

The latest proxy-verifier combines duplicate header values during
equality checks unless the replay uses duplicate-aware
verification. cachedDuplicateHeaders still expected the older
rendering, so the AuTest failed even though ATS behavior had not
changed.

Update the replay expectation to match the current duplicate
header matching behavior. This keeps the test validating cached
header handling against the latest proxy-verifier semantics.

(cherry picked from commit 886e360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Picked v10.1.1
Status: Picked v10.2.0

Development

Successfully merging this pull request may close these issues.

4 participants