Fix build: TLS log fields use m_data, not m_http_sm - #13241
Merged
Merged
Conversation
m_http_sm was removed from LogAccess by apache#13059 (TransactionLogData).
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes build breakage introduced by #13059 by removing direct HttpSM access from LogAccess when marshalling TLS handshake-related log fields, routing those fields through TransactionLogData instead.
Changes:
- Add
TransactionLogDataaccessors for client TLS handshake byte counters and TLS 1.3 early data length. - Update
LogAccessTLS-related marshalers to usem_data(TransactionLogData) rather than a removedm_http_smmember. - Update TLS squid-length calculations to use
TransactionLogDatabyte counters for consistency across HttpSM-backed and non-HttpSM logging paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/proxy/logging/TransactionLogData.cc |
Implements new TLS handshake/early-data accessors (HttpSM-backed, defaulting to 0 for non-HttpSM). |
src/proxy/logging/LogAccess.cc |
Replaces m_http_sm references with m_data for TLS handshake byte and squid-length TLS marshalers. |
include/proxy/logging/TransactionLogData.h |
Declares new TLS handshake/early-data accessor APIs used by LogAccess. |
brbzull0
approved these changes
Jun 5, 2026
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 16, 2026
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
m_http_sm was removed from LogAccess by apache#13059 (TransactionLogData).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_http_sm was removed from LogAccess by #13059 (TransactionLogData).