slice_prefetch.test.py: address cache.log flakiness - #13322
Merged
Merged
Conversation
bneradt
force-pushed
the
fix-slice-prefetch-log-order
branch
from
June 24, 2026 20:52
45f6471 to
ec8c25e
Compare
Background slice prefetch requests can log around the client transactions. A run can therefore contain the expected cache records while still failing an ordered cache.log gold comparison. This replaces the full-file gold comparison with per-entry log assertions that verify the expected cache and prefetch records independently of ordering, then removes the unused gold file. Fixes: apache#13311
bneradt
force-pushed
the
fix-slice-prefetch-log-order
branch
from
June 24, 2026 21:39
ec8c25e to
19e311e
Compare
Contributor
Author
|
[approve ci ubuntu autest 1] |
JosiahWI
approved these changes
Jun 25, 2026
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 26, 2026
Background slice prefetch requests can log around the client transactions. A run can therefore contain the expected cache records while still failing an ordered cache.log gold comparison. This replaces the full-file gold comparison with per-entry log assertions that verify the expected cache and prefetch records independently of ordering, then removes the unused gold file. Fixes: #13311 (cherry picked from commit c179b6b)
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
Background slice prefetch requests can log around the client transactions. A run can therefore contain the expected cache records while still failing an ordered cache.log gold comparison. This replaces the full-file gold comparison with per-entry log assertions that verify the expected cache and prefetch records independently of ordering, then removes the unused gold file. Fixes: apache#13311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background slice prefetch requests can log around the client
transactions. A run can therefore contain the expected cache records
while still failing an ordered cache.log gold comparison.
This replaces the full-file gold comparison with per-entry log
assertions that verify the expected cache and prefetch records
independently of ordering, then removes the unused gold file.
Fixes: #13311