Add unit tests for Action logic - #13332
Merged
Merged
Conversation
Authored with Claude Sonnet and Claude Opus.
bryancall
requested review from
cmcfarlen and
masaori335
and removed request for
cmcfarlen
June 29, 2026 22:26
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Catch2 unit test executable covering the Action contract in the inkevent event system, with emphasis on assignment semantics (continuation/mutex binding) and cancellation behavior (including cancellation of scheduled events).
Changes:
- Introduces
test_Action.ccwith unit tests validatingAction’s observable state transitions (operator=,cancel,cancel_action) and sentinel encodings (MAKE_ACTION_RESULT,ACTION_RESULT_DONE,ACTION_IO_ERROR). - Adds a multithreaded test that schedules and cancels an event before its deadline to verify no dispatch occurs.
- Wires the new unit test into the inkevent CMake test targets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/iocore/eventsystem/unit_tests/test_Action.cc | New Catch2 tests exercising Action assignment/cancellation behavior and action-result sentinels, plus a scheduled-event cancellation scenario. |
| src/iocore/eventsystem/CMakeLists.txt | Adds test_Action executable and registers it as a Catch2 test. |
masaori335
approved these changes
Jul 28, 2026
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
* Add unit tests for `Action` logic Authored with Claude Sonnet and Claude Opus. (cherry picked from commit 04ee11a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I authored these tests with Claude Sonnet and Claude Opus. They are part of a suite of unit tests I am generating with AI, aimed at the event system. The
Actioninterface doesn't have much logic, so most of what's tested here is pretty simple, but there are a few tests related to cancellation that serve as good documentation/examples of how to use actions appropriately.