Skip to content

ssl: remove the dead SSL_HOOK_OP_TERMINATE op #13407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moonchen merged 1 commit into from
Jul 20, 2026
+2 −6
Merged

ssl: remove the dead SSL_HOOK_OP_TERMINATE op #13407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/iocore/net/P_SSLNetVConnection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,8 @@ constexpr int SSL_DEF_TLS_RECORD_MSEC_THRESHOLD = 1000;
struct SSLCertLookup;

enum class SslVConnOp {
SSL_HOOK_OP_DEFAULT, ///< Null / initialization value. Do normal processing.
SSL_HOOK_OP_TUNNEL, ///< Switch to blind tunnel
SSL_HOOK_OP_TERMINATE ///< Termination connection / transaction.
SSL_HOOK_OP_DEFAULT, ///< Null / initialization value. Do normal processing.
SSL_HOOK_OP_TUNNEL ///< Switch to blind tunnel
};

enum class SSLHandshakeStatus { SSL_HANDSHAKE_ONGOING, SSL_HANDSHAKE_DONE, SSL_HANDSHAKE_ERROR };
Expand Down
3 changes: 0 additions & 3 deletions src/iocore/net/SSLNetVConnection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,9 +1309,6 @@ SSLNetVConnection::sslServerHandShakeEvent(int &err)
// we get out of this callback, and then will shuffle
// over the buffered handshake packets to the O.S.
return EVENT_DONE;
} else if (SslVConnOp::SSL_HOOK_OP_TERMINATE == hookOpRequested) {
sslHandshakeStatus = SSLHandshakeStatus::SSL_HANDSHAKE_DONE;
return EVENT_DONE;
}

Dbg(dbg_ctl_ssl, "Go on with the handshake state=%s",
Expand Down