Adds voluspa - a configuration generator by randall · Pull Request #4436 · apache/trafficserver

randall · 2018-10-18T16:19:23Z

This generates configuration files for ATS from simpler high-level YAML specifications.

It is a stand-alone command line utility and package implemented in Go.

SolidWallOfCode · 2018-10-21T19:26:58Z

That's quite a large code drop. Do we want this in the code base, or in a stand alone repo?

zwoop · 2018-11-06T18:48:44Z

Also, the plan was to code-drop this into a separate branch in ATS for now, not master. Sorry I missed that.

zwoop

We need to

Fix the RAT reports (IMO). Ideally, avoid adding to .rat-excludes unless necessary.
We should land this in a branch named Voluspa, not master. The plan / goal is to move this over to ATC if they see this useful to them.

zwoop · 2018-11-06T18:53:24Z

@SolidWallOfCode See other comment, but agreed. For now, we should do this in a separate branch, long term, it will likely move to the ATC project.

bryancall · 2019-01-09T23:00:13Z

[approve ci autest]

Instead of fixing the URI decoding functionality to handle the exception (re)implemented a check for percent encoding which was what was needed. During signature calculation AWS avoids URI encoding of already encoded query parameters (rfc3986#section-2.4 says "implementations must not percent-encode or decode the same string more than once ...")

Also changes the messaging of all config file loads to be consistent Addresses issue apache#1348

Added new test for client hello hook

…ests.

…getby

Because Susan did it i her branch. And she said it never really worked right. And I like to KIWF.

…be const for STL compatability.

Updated all headers test to not use netstat. Fixed README.md

…slConnection()

…rtions.

… loaded.

This generates configuration files for ATS from simpler high-level YAML specifications. It is a stand-alone command line utility and package implemented in Go.

randall · 2019-05-13T22:04:26Z

Dusting off this changes...

We need to

Fix the RAT reports (IMO). Ideally, avoid adding to .rat-excludes unless necessary.

Tried. The .confs, gometalint.conf, and .config_default are all config files (son or YAML).
gojsonschema is a vendor-ed library. I could move to gomod which would eliminate the copy of gojsonschema, but would require relatively new versions of go for people to use.

# tools/voluspa related
^.gometalint.conf$
.*\.conf$
.*config_default$
gojsonschema(?:                      Apache 2.0. Properly documented in LICENSE-APACHE-2.0.txt ){0}

We should land this in a branch named Voluspa, not master. The plan / goal is to move this over to ATC if they see this useful to them.

The voluspa branch is the target here.

randall · 2019-07-09T18:23:31Z

@bryancall Can you take a look at this? I think I've addressed everything @zwoop requested.

bryancall · 2019-07-16T16:37:38Z

It looks like it has the clang-tidy changes I did on master and then @zwoop reverted. We should either update the PR from the current master and not have the clang-tidy changes in this PR or wait until I do clang-tidy again on master before merging this.

randall added the Tools label Oct 18, 2018

randall self-assigned this Oct 18, 2018

zwoop requested changes Nov 6, 2018

View reviewed changes

randall changed the base branch from master to voluspa November 7, 2018 00:37

randall force-pushed the add_voluspa branch from 2fc13ee to 24952b5 Compare November 7, 2018 19:24

zwoop added this to the 9.0.0 milestone Jan 8, 2019

masaori335 and others added 20 commits February 16, 2019 14:21

Fix typo of SNI

37f3405

Frees disk_vols when volume create failed

c2a9189

RecHttp: Convert protocol session pool to use views and MemArena.

5ad8eec

Adds websocket note for remap config

4e05b24

Fixes formatting

0b39c1d

Build fix: Fix build issue for -O3 on CI.

0781e91

Build: Fix array bounds error under -O3.

390ebe5

Adds logging around various config file loads

9f5396e

Also changes the messaging of all config file loads to be consistent Addresses issue apache#1348

Added TS_SSL_CLIENT_HELLO_HOOK and docs

53fd833

Added new test for client hello hook

Refresh mgmt signal logic to remove possible memory issues.

d57057d

Diags: Make some methods virtual so they can be overridden for unit t…

5b7ce5f

…ests.

LibRecord: Add unit tests.

c83061d

ink_inet: Fix family string printing, add IpAddr::isAnyAddr.

03cfef1

Optimize: rewrite getbyname_imm and getSRVbyname_imm as wrappers for …

2906f16

…getby

TextView: add overflow checking to svto_radix.

331d378

Removing Lazy Buf Alloc from H1 Server session

b4f8d1c

Because Susan did it i her branch. And she said it never really worked right. And I like to KIWF.

rm unused func reset_read_buffer

3b0a6f0

Cleanup: Set SSL_OP_NO_TICKET in SSLInitServerContext()

837250c

Cleanup: Separate SSLStats and SSLDiags from SSLUtils

c811aea

shinrich and others added 16 commits April 30, 2019 10:56

Off by 1 error in memcpy of redirect url

d611b54

MIMEScanner: only clear m_line buffer if at MIME_PARSE_BEFORE state

5be0134

Clang Analyzer: Fix IpMap.cc false positives.

0ee898d

Added user defined conversion operator in ConstBuffer for string_view.

8246a4e

Update jtest.cc

0fe8937

Tries to make builds on older clang happy

e68b191

ssl_session_resuse: operator for redis endpoint compare functor must …

05398aa

…be const for STL compatability.

Removes code related to removed configuration

a34a122

Update README.md

c351730

Updated all headers test to not use netstat. Fixed README.md

TS C++ API: add member function TSSslConnection InterceptPlugin::getS…

92ecbcb

…slConnection()

Fixed clang-analyzer issues in cookie_remap

37661eb

Implement prefetched OCSP stapling responses

d2386a5

Move setsockopt from UnixNetProcessor to Server::setup_fd_for_listen

00c11d0

Rewrite the assert statement to avoid Socks Proxy triggering the asse…

c934b15

…rtions.

Load the Socks configuration after the host state persistence data is…

96c0c71

… loaded.

Adds voluspa - a configuration generator

16ca878

This generates configuration files for ATS from simpler high-level YAML specifications. It is a stand-alone command line utility and package implemented in Go.

randall force-pushed the add_voluspa branch from 24952b5 to 16ca878 Compare May 6, 2019 16:12

randall requested a review from bryancall May 23, 2019 17:54

zwoop mentioned this pull request Jun 13, 2019

☂ Action items prior to July 9.x branch #5457

Closed

18 tasks

randall closed this Jul 18, 2019

randall mentioned this pull request Jul 18, 2019

Adds voluspa - a configuration generator #5736

Merged

randall deleted the add_voluspa branch July 22, 2019 14:54

zwoop modified the milestone: 9.0.0 Aug 27, 2019

zwoop modified the milestones: 9.0.0, QUIC Nov 4, 2019

Navigation Menu

Uh oh!

Adds voluspa - a configuration generator - #4436

Adds voluspa - a configuration generator#4436
randall wants to merge 526 commits into
apache:voluspafrom
randall:add_voluspa

randall commented Oct 18, 2018

Uh oh!

SolidWallOfCode commented Oct 21, 2018

Uh oh!

zwoop commented Nov 6, 2018

Uh oh!

zwoop left a comment

Uh oh!

zwoop commented Nov 6, 2018

Uh oh!

bryancall commented Jan 9, 2019

Uh oh!

randall commented May 13, 2019

Uh oh!

randall commented Jul 9, 2019

Uh oh!

bryancall commented Jul 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

randall commented Oct 18, 2018

Uh oh!

SolidWallOfCode commented Oct 21, 2018

Uh oh!

zwoop commented Nov 6, 2018

Uh oh!

zwoop left a comment

Choose a reason for hiding this comment

Uh oh!

zwoop commented Nov 6, 2018

Uh oh!

bryancall commented Jan 9, 2019

Uh oh!

randall commented May 13, 2019

Uh oh!

randall commented Jul 9, 2019

Uh oh!

bryancall commented Jul 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants