Clean up ua_entry when client_vc is closed - #4873
Merged
Merged
Conversation
Member
Author
scw00
force-pushed
the
cleanup_ua_entry
branch
from
January 26, 2019 09:48
a910de4 to
ffee972
Compare
Member
|
With PR #4020 merged, It is required to remove VCEntry from VCTable once perform do_io_close on a VC. +1 |
oknet
previously approved these changes
Jan 26, 2019
Member
Author
scw00
force-pushed
the
cleanup_ua_entry
branch
2 times, most recently
from
January 30, 2019 07:21
8ce044e to
d0d352c
Compare
oknet
previously approved these changes
Jan 30, 2019
scw00
force-pushed
the
cleanup_ua_entry
branch
from
January 30, 2019 08:24
d0d352c to
227761b
Compare
oknet
approved these changes
Jan 30, 2019
Member
Author
Contributor
|
Did this get cherry picked to 7.1.x too? |
Contributor
|
Cherry picked to 8.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client vc might be closed when we call
ua_txn->do_io_close()and freed bywrite_signal_and_update /root/trafficserver/iocore/net/UnixNetVConnection.cc:133. But tunnel is still alive because cache write are not finishing. So we need to clean upua_entrybefore callkill_sm->vc_table->cleanup_all().