Plugin reload - #5282
Merged
Merged
Plugin reload#5282
Conversation
Contributor
Author
|
[approve ci autest] |
zwoop
reviewed
Apr 18, 2019
zwoop
reviewed
Apr 18, 2019
Contributor
Author
|
Addressed feedback from the ATS summit:
|
Contributor
|
Hmmm, it still fails with clang8 on FreeBSD. |
Contributor
|
Doesn't build on FreeBSD12 with llvm8 :-/. I really kinda dislike all these checks for c++fs, are we sure we really want to drag in this nightmare ? |
Contributor
|
Blocks #5457 |
Contributor
Author
|
yeah, FreeBSD + clang seems to be problematic, will look into it |
vmamidi
reviewed
May 16, 2019
Contributor
Author
|
[approve ci autest] |
Contributor
Author
|
[approve ci clang-analyzer] |
Contributor
Author
Any other feedback, ideas, considerations ? |
SolidWallOfCode
previously approved these changes
Jul 15, 2019
Reloading plugin allows new versions of a plugin code to be loaded and executed and old versions to be unloaded without restarting the traffic server process. More info in doc/developer-guide/plugins/reloading-plugins.en.rst
Contributor
Author
|
@SolidWallOfCode, could you reiterate your 👍? Pushed a change with comment clarification and c-style casting removal which removed your approving review. |
18 tasks
bryancall
self-requested a review
July 16, 2019 16:08
SolidWallOfCode
self-requested a review
July 17, 2019 15:43
SolidWallOfCode
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloading plugin allows new versions of a plugin code to be loaded
and executed and old versions to be unloaded without restarting
the traffic server process.
More info in doc/developer-guide/plugins/reloading-plugins.en.rst