Add cache_range_requests autest, add to x-parentselectiion-key to xdebug plugin. - #6168
Merged
Merged
Conversation
Contributor
Author
|
These tests all pass except the python microserver doesn't exit properly at the end for some reason and I can't figure out why (at the moment)... resolved. |
Contributor
|
[approve ci] |
Contributor
|
The subject here is slightly confusing. I would have preferred to see it as "Adding X-ParentSelection-Key to xdebug", with the more detailed description saying that it's also adding autest. I know, bike shedding, but these things can be important, particularly when we put together release notes. |
Contributor
Author
|
The change to xdebug was to support the autest for cache range requests. The CRR plugin sets the Parent Selection Key and the only way I could think of to check it was to either set up a full blown multi parent test and hope setting a random key would result in a different parent being selected, or else just inspect the parent selection key via TSHttpTxnParentSelectionUrlGet.
|
jrushford
self-requested a review
November 20, 2019 17:25
Contributor
|
[approve ci] |
Contributor
|
[approve ci clang-format] |
Contributor
|
Cherry-picked to v9.0.x branch. |
This was referenced Mar 23, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add basic functionality test for cache_range_requests, including an addition to the xdebug plugin to add parent selection key inspection (x-parentselection-key).