Skip to content

Bugfix: set a default inactivity timeout only if a read or write I/O operation was set #7226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oknet merged 1 commit into from
Oct 9, 2020
Merged

Bugfix: set a default inactivity timeout only if a read or write I/O operation was set #7226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion iocore/net/UnixNet.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ class InactivityCop : public Continuation
}

// set a default inactivity timeout if one is not set
if (ne->next_inactivity_timeout_at == 0 && nh.config.default_inactivity_timeout > 0) {
// The event `EVENT_INACTIVITY_TIMEOUT` only be triggered if a read
// or write I/O operation was set by `do_io_read()` or `do_io_write()`.
if (ne->next_inactivity_timeout_at == 0 && nh.config.default_inactivity_timeout > 0 &&

@bryancall bryancall Sep 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing cases where default_inactivity_timeout is being set on server sessions when ne->read.enabled and ne->write.enabled are 0. I haven't tracked down if that is required or not for closing the server sessions.

Thread 15 "[ET_NET 12]" hit Breakpoint 1, InactivityCop::check_inactivity (this=0x7fffc40a0ba0, event=2, e=0xe8aac0) at ../../../iocore/net/UnixNet.cc:74
74	        Debug("inactivity_cop", "vc: %p inactivity timeout not set, setting a default of %d", ne,
(gdb) p ne->next_inactivity_timeout_at
$1 = 0
(gdb) p nh.config.default_inactivity_timeout
$2 = 300
(gdb) p ne->read.enabled
$3 = 0
(gdb) p ne->write.enabled
$4 = 0

@sudheerv sudheerv Sep 29, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryancall Curious, do you configure active timeout for Server sessions? If there's no active timeout (which is how we configure for Server sessions), I'd think we should still set the default inactivity timeout just in case.

(ne->read.enabled || ne->write.enabled)) {
Debug("inactivity_cop", "vc: %p inactivity timeout not set, setting a default of %d", ne,
nh.config.default_inactivity_timeout);
ne->set_default_inactivity_timeout(HRTIME_SECONDS(nh.config.default_inactivity_timeout));
Expand Down