Skip to content

Apple Silicon macOS support - #7389

Merged
randall merged 1 commit into
apache:masterfrom
randall:macos_darwin
Feb 16, 2021
Merged

Apple Silicon macOS support#7389
randall merged 1 commit into
apache:masterfrom
randall:macos_darwin

Conversation

@randall

@randall randall commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

Allows builds on Apple Silicon to complete and run

@randall randall added the Build work related to build configuration or environment label Dec 15, 2020
@randall randall added this to the 10.0.0 milestone Dec 15, 2020
@randall
randall force-pushed the macos_darwin branch 2 times, most recently from 41d650b to c81bb76 Compare December 30, 2020 00:21
@randall randall changed the title Disable compiling Inline.cc on macOS Apple Silicon macOS support Dec 30, 2020
@randall randall self-assigned this Jan 6, 2021
@ywkaras

ywkaras commented Jan 9, 2021

Copy link
Copy Markdown

I am confused that there are changes to catch.hpp but no change to the version, how is that possible?

3 similar comments
@ywkaras

This comment has been minimized.

@ywkaras

This comment has been minimized.

@ywkaras

ywkaras commented Jan 9, 2021

Copy link
Copy Markdown

I am confused that there are changes to catch.hpp but no change to the version, how is that possible?

@randall

randall commented Feb 1, 2021

Copy link
Copy Markdown
Contributor Author

I am confused that there are changes to catch.hpp but no change to the version, how is that possible?

I manually back ported the apple-related changes from catch.

Upgrading catch to it's latest version is an effort of it's own: #7464

@bryancall

Copy link
Copy Markdown
Contributor

@randall Can you have a better explanation of what is happening? We did a code review today and had questions.

Allows builds on Apple Silicon to complete and run
@randall

randall commented Feb 12, 2021

Copy link
Copy Markdown
Contributor Author

originally, I back ported some macOS specific changes from catch.hpp's head to get macOS on AS to build. With #7464 merged I no longer need that (and this PR has been fixed up to reflect that)

@apache apache deleted a comment from bneradt Feb 16, 2021
@randall
randall merged commit fa8b3f9 into apache:master Feb 16, 2021
@randall
randall deleted the macos_darwin branch February 16, 2021 20:28
randall added a commit to randall/trafficserver that referenced this pull request Feb 16, 2021
maskit added a commit that referenced this pull request Feb 17, 2021
* master:
  Select lua context per thread (#7465)
  Fix out of bounds access error in jtest (#7526)
  Disable compiling Inline.cc on macOS (#7389)
  Makes sure the types are correct, avoiding compiler warnings (#7523)
  Move has_request_body to ProxyTransaction (#7499)
  Make the H3 build script work properly on Debian platforms (#7522)
  slice/handleFirstServerHeader: return sooner on requested range errors (#7486)
  Add new log field for negotiated ALPN Protocol ID with the client (#7491)
  Add Outbound PROXY Protocol (v1/v2) Support (#7446)
  Updates the Dockerfile for debian (#7518)
  Disable client inactivity timeout while server is processing POST request (#7309)
  Upgrade Catch.hpp to v2.13.4 (#7464)
  Move reopen_moved_log_files to log flushing thread (#7450)
  replace psutil.pid() with psutil.process_iter() for safer execution (#7515)
  Fix spacing in clang-analyzer.sh script (#7480)
  Fix out of bounds access error in ats_base64_decode (#7490)
  Updated to build lastest versions of Fedora and CentOS docker images (#7505)
  Fix QUIC unit tests build issue on GNU ld (#7496)
  Fix QUIC unit test failures (#7497)
  Fixed build issues with Fedora 34 (#7506)
  Fixing DNS local_ipv* config option (#7507)
  traffic_dump: AuTests to use Proxy Verifier. (#7502)
  Disable ja3 plugin when building with boringssl (#7500)
  Avoid -Warray-bounds on PROXY Protocol Builder (#7488)
  AuTest: Upgrade to Proxy Verifier 2.0.2 (#7493)
  fix certs (#7494)
  Add zlib1g-dev to Debian dependencies in README (#7495)
  Unit Test -  Increase openssl's key size. Place test certs into a common test folder. (#7451)
  Add basic type aliases for std::chrono types to ink_time.h for future use. (#7482)
  traffic_ctl - Fix lookup key for run-root option (#7484)
  update thread config tests (#7370)
  Perf: Replace casecmp with memcmp in HPACK static table lookup (#6521)
  Add PROXY Protocol Builder (#7445)
  Adjust so transfer-encoding header can be treated hop-by-hop (#7473)
  Convert auxkey form 2 uint32_t to 1 uint64_t. (#7350)
  Remove the queuing option from proxy.config.http.per_server.connection (#7302)
  Remove unused function ink_microseconds. (#7481)
  use std::unordered_map to store sessions (#7405)
  drop use of BIO_f_base64 and EVP_PKEY_new_mac_key (#7106)
  Do not write to the cache if the plugin decides not to write to the cache (#7461)
  API to retrieve NoStore set by plugins (#7439)
  Update AuTest version update directions for pipenv (#7469)
  Add command line utility to help convert remap plugin usage to ATS9. (#7426)
  Cleanup: Get rid of MIMEFieldWrapper from HPACK encoding (#6520)
  Proxy Verifier: Making use of delay directives for caching tests. (#7468)
  Cleanup: Add SNIRoutingType (#7453)
  Updating to Proxy Verifier v2.0.0 (#7454)
  Adjust to actually try a server address more than once (#7288)
  Change atoi to atol, causing obvious issues on what needs to be int64's (#7466)
  Cleans up duplicated TSOutboundConnectionMatchType definition (#7090)
  Fixing compress expectation for new microserver (#7463)
  Update to the new MicroServer 1.0.6 release (#7460)
  CacheRead: clear dir entry if doc is found to be truncated (#7064)
  Do not provide a stale negative cache (#7422)
  Generalize SNI support (#6870)
  Add synchronization between UDPNetProcessor::UDPBind in main Thread and initialize_thread_for_udp_net in ET_UDP Thread (#7407)
  Fix heap use after free in DNSProcessor::getby() (#3871)
  Fix comment in include/tscore/Filenames.h. (#7457)
  Fix Makefile target for creating changelogs (#7455)
  Change squid log code for self looping (#7443)
  Enhancements for compress plugin (#7416)
  Add incoming PROXY Protocol v2 support (#7340)
  Cleanup: Remove unused members of NextHopProperty (#7436)
  Small fix to regex_remap PR # 7347. (#7437)
  PoolableSession (#6828)
  option to disable compression for range request's response (#7287)
  Make TSUrlSchemeGet() return scheme implied by URL type when there is no explicit scheme. (#7262)
zwoop pushed a commit that referenced this pull request Feb 23, 2021
Allows builds on Apple Silicon to complete and run

(cherry picked from commit fa8b3f9)
@zwoop

zwoop commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

Cherry-picked to v9.1.x branch.

@zwoop zwoop modified the milestones: 10.0.0, 9.1.0 Feb 23, 2021
@zwoop

ghost commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

Cherry-picked to v9.0.x branch.

@zwoop zwoop modified the milestones: 9.1.0, 9.0.1 Feb 23, 2021
@zwoop

ghost commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

I think we need to revert this for now, from all release branches.

@zwoop zwoop modified the milestones: 9.0.1, 10.0.0 Mar 9, 2021
@zwoop zwoop modified the milestones: 10.0.0, 9.1.0 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants