Skip to content

Adding TCP Info logging support to header rewrite - #7441

Closed
dbhat wants to merge 0 commit into
apache:masterfrom
dbhat:master
Closed

Adding TCP Info logging support to header rewrite#7441
dbhat wants to merge 0 commit into
apache:masterfrom
dbhat:master

Conversation

@dbhat

@dbhat dbhat commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

This change to the header rewrite plugin allows TCP Info logs to be written out as part of the header.

@vmamidi

vmamidi commented Jan 23, 2021

Copy link
Copy Markdown
Contributor

@dbhat Can you also update the documentation?

@vmamidi vmamidi added this to the 10.0.0 milestone Jan 23, 2021
@masaori335

Copy link
Copy Markdown
Contributor

[approve ci]
[add to whitelist]

Comment thread doc/admin-guide/plugins/header_rewrite.en.rst Outdated
@maskit

maskit commented Feb 3, 2021

Copy link
Copy Markdown
Member

It may be nice to have a subsection about TXN_CLOSE_HOOK under Hook Conditions section on the documentation. If I understand correctly, the hook is special because it's too late to modify/add response headers that will be sent to a client and it only makes sense if you add internal headers.

@dbhat

dbhat commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

@maskit: Added to documentation in commit

@maskit

maskit commented Feb 4, 2021

Copy link
Copy Markdown
Member

Rerunning autest. At minimum tests for header_rewrite pass on my MBP.

[approve ci autest]

@bryancall
bryancall requested review from bryancall and removed request for bryancall February 4, 2021 22:52
@bryancall

Copy link
Copy Markdown
Contributor

I will review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants