Skip to content

build_h3_tools: use draft-29 - #7826

Closed
bneradt wants to merge 1 commit into
apache:masterfrom
bneradt:build_h3_tools_draft_29
Closed

build_h3_tools: use draft-29#7826
bneradt wants to merge 1 commit into
apache:masterfrom
bneradt:build_h3_tools_draft_29

Conversation

@bneradt

@bneradt bneradt commented May 12, 2021

Copy link
Copy Markdown
Contributor

This changes build_h3_tools to build openssl-quic with branch
OpenSSL_1_1_1g-quic-draft-29 since that is what ATS currently supports.
Building against draft-32 results in functional HTTP/3 behavior but not
HTTPS behavior. Further, curl built against draft-32 also has HTTPS
problems.

This also makes /opt/openssl-quic a symlink to the built directory which
contains the explicit openssl draft branch name. Thus, with default
environment parameters, running the script results in the following:

$ ls -lad /opt/openssl-quic*
lrwxrwxrwx 1 root root 46 May 12 18:50 /opt/openssl-quic -> /opt/openssl-quic-OpenSSL_1_1_1g-quic-draft-29
drwxr-xr-x 7 root root 67 May 12 18:49 /opt/openssl-quic-OpenSSL_1_1_1g-quic-draft-29

This changes build_h3_tools to build openssl-quic with branch
OpenSSL_1_1_1g-quic-draft-29 since that is what ATS currently supports.
Building against draft-32 results in functional HTTP/3 behavior but not
HTTPS behavior. Further, curl built against draft-32 also has HTTPS
problems.

This also makes /opt/openssl-quic a symlink to the built directory which
contains the explicit openssl draft branch name. Thus, with default
environment parameters, running the script results in the following:

$ ls -lad /opt/openssl-quic*
lrwxrwxrwx 1 root root 46 May 12 18:50 /opt/openssl-quic -> /opt/openssl-quic-OpenSSL_1_1_1g-quic-draft-29
drwxr-xr-x 7 root root 67 May 12 18:49 /opt/openssl-quic-OpenSSL_1_1_1g-quic-draft-29
@bneradt bneradt added the QUIC label May 12, 2021
@bneradt bneradt added this to the 10.0.0 milestone May 12, 2021
@bneradt
bneradt requested a review from zwoop May 12, 2021 20:42
@bneradt bneradt self-assigned this May 12, 2021
@bneradt
bneradt requested a review from bryancall as a code owner May 12, 2021 20:42
@maskit

maskit commented May 12, 2021

Copy link
Copy Markdown
Member

Did you try https://github.com/quictls/openssl/tree/OpenSSL_1_1_1k+quic ?
The author of ngtcp2 (== the owner of OpenSSL_1_1_1g-quic-draft-29) switched to use it.

@bneradt

bneradt commented May 13, 2021

Copy link
Copy Markdown
Contributor Author

Did you try https://github.com/quictls/openssl/tree/OpenSSL_1_1_1k+quic ?
The author of ngtcp2 (== the owner of OpenSSL_1_1_1g-quic-draft-29) switched to use it.

Oh, interesting. I was not aware of this fork. Thank you for pointing it out.

I've built with it and am running the AuTests with it now locally. Looks promising. I'll update the PR tomorrow if the tests look good.

@bneradt

bneradt commented May 13, 2021

Copy link
Copy Markdown
Contributor Author

Did you try https://github.com/quictls/openssl/tree/OpenSSL_1_1_1k+quic ?
The author of ngtcp2 (== the owner of OpenSSL_1_1_1g-quic-draft-29) switched to use it.

Oh, interesting. I was not aware of this fork. Thank you for pointing it out.

I've built with it and am running the AuTests with it now locally. Looks promising. I'll update the PR tomorrow if the tests look good.

I've implemented this change in #7836 . That change replaces this PR, so I'm closing this.

@bneradt bneradt closed this May 13, 2021
@bneradt
bneradt deleted the build_h3_tools_draft_29 branch June 9, 2021 18:24
@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants