remap_reload AuTest: await config reload messages - #8872
Merged
Merged
Conversation
Change the remap_reload AuTest from waiting an arbitrary amount of time (5 seconds) for the config reload to finish to instead waiting upon a log message to indicate the reload has finished. This resolves some flaky test results from the test when the previous 5 second sleep wasn't enough time for the reload to finish. Fixes: apache#8860
masaori335
approved these changes
May 29, 2022
masaori335
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable. Thanks for making it robust.
brbzull0
approved these changes
May 31, 2022
brbzull0
left a comment
Contributor
There was a problem hiding this comment.
Better this way.
As a note I think 30s is a lot, a reload shouldn't take more than 10s to be done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the remap_reload AuTest from waiting an arbitrary amount of time
(5 seconds) for the config reload to finish to instead waiting upon a
log message to indicate the reload has finished. This resolves some
flaky test results from the test when the previous 5 second sleep wasn't
enough time for the reload to finish.
Fixes: #8860