Make FileManager ctor private. - #8888
Merged
Merged
Conversation
… private and also explicitly add code to avoid any copies.
Contributor
|
[approve ci autest] |
2 similar comments
Contributor
|
[approve ci autest] |
Contributor
Author
|
[approve ci autest] |
masaori335
approved these changes
Jun 9, 2022
masaori335
left a comment
Contributor
There was a problem hiding this comment.
Looks good and the freaky autest is gone.
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
… private and also explicitly add code to avoid any copies. (apache#8888) (apache#686) (cherry picked from commit 2f05312)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix singleton class by making his ctor private and also explicitly add code to avoid any copies.