Skip to content

Use direct comparison to check data type consistency during Tablet.addValue - #678

Merged
jt2594838 merged 2 commits into
developfrom
refine_write
Dec 26, 2025
Merged

Use direct comparison to check data type consistency during Tablet.addValue#678
jt2594838 merged 2 commits into
developfrom
refine_write

Conversation

@ColinLeeo

@ColinLeeoColinLeeo commented Dec 25, 2025

Copy link
Copy Markdown
Contributor

Before

imageimage

After

image

@codecov-commenter

codecov-commenter commented Dec 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.87%. Comparing base (0b286ad) to head (db38d9a).
⚠️ Report is 33 commits behind head on develop.

Files with missing linesPatch %Lines
cpp/src/common/tablet.cc0.00%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## develop #678 +/- ##
===========================================
- Coverage 61.89% 61.87% -0.03% 
===========================================
Files 709 709 Lines 40176 40197 +21 Branches 5650 5653 +3 ===========================================
+ Hits 24867 24871 +4 - Misses 14608 14628 +20 + Partials 701 698 -3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838jt2594838 changed the title refine writeing.Use direct comparison to check data type consistency during Tablet.addValueDec 26, 2025
@jt2594838
jt2594838 merged commit 26ecec8 into developDec 26, 2025
13 checks passed
@jt2594838
jt2594838 deleted the refine_write branch December 26, 2025 01:52
@ColinLeeoColinLeeo linked an issue Jan 5, 2026 that may be closed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to make tsfile_cpp read and write faster.

3 participants

@ColinLeeo@codecov-commenter@jt2594838