Uh oh!
There was an error while loading. Please reload this page.
[RFC] Use CMSIS-NN with TVM - #15
Conversation
u99127
commented
Aug 3, 2021
Minor nit - the title of the RFC should really read - [RFC] Use CMSIS-NN with TVM. @manupa-arm , @Mousius .. |
leandron
left a comment
There was a problem hiding this comment.
Just a few nits here and there. Generally looks very good.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
leandron
left a comment
There was a problem hiding this comment.
A couple of other acronyms.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Change-Id: I3b0954f3fdb4d54b3e38a84de0ab649c1e79bca8
Change-Id: I6142c001175cdf41c58b5bb555a39e07c834254f
Change-Id: Id63d1866cd783f5e59b568f36c9177ee8715bc4d
Change-Id: Id54bae4bd2ca4bd9c3ab734e8cae966ebbe332b2
comaniac
left a comment
There was a problem hiding this comment.
Overall LGTM. One thing I'm a little bit worry about is this RFC depends on another two RFCs (target hook and Ethos-U integration). I would be better if this RFC can also discuss the impact and alternative plan without other 2 RFCs so that this RFC won't be blocked.
Uh oh!
There was an error while loading. Please reload this page.
areusch
left a comment
There was a problem hiding this comment.
@ashutosh-arm apologies for the delay! just a few points to clarify here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Change-Id: I56a5f9bf319576d342a5bdc3771402262584e8c4
… with some terminologies Change-Id: I002be9cc67b72444ea27fe0a31769549fb6fd452
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
areusch
left a comment
There was a problem hiding this comment.
@ashutosh-arm i did another round here to clarify your intentions. i think this should be the bulk of my questions on this RFC
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
areusch
commented
Aug 28, 2021
Merging as Cody said LGTM in his last review |
This RFC details integration of CMSIS-NN API into TVM to support code generation for Arm(R) Cortex-M using the following library: https://github.com/ARM-software/CMSIS_5/tree/develop/CMSIS/NN
cc : @areusch@mbaret@tqchen@Mousius@manupa-arm