Skip to content

[RFC] Integrate LIBXSMM with TVM. - #47

Merged
comaniac merged 8 commits into
apache:mainfrom
zhuwenxi:Intel_LIBXSMM_integration
Dec 24, 2021
Merged

[RFC] Integrate LIBXSMM with TVM.#47
comaniac merged 8 commits into
apache:mainfrom
zhuwenxi:Intel_LIBXSMM_integration

Conversation

@zhuwenxi

@zhuwenxizhuwenxi commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

comaniac
comaniac reviewed Dec 16, 2021
View reviewed changes

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:

  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.

Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md Outdated
@zhuwenxi

zhuwenxi commented Dec 17, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:

  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.

Upstream plan added, at the end of RFC.

By the way, I'm not quite sure what "TVM CI" refers to? If it means unit tests, they will be included in their related PRs when I upstream my code.

@zhuwenxizhuwenxi changed the title RFC to integrate LIBXSMM with TVM.[RFC] Integrate LIBXSMM with TVM.Dec 18, 2021
@zhuwenxi

zhuwenxi commented Dec 21, 2021

Copy link
Copy Markdown
ContributorAuthor

@comaniac Any update?

comaniac
comaniac approved these changes Dec 21, 2021
View reviewed changes

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just try to polish the plan for the last time and we should be good to go.

Comment threadrfcs/0046-Intel-LIBXSMM-integration.md Outdated
@zhuwenxi

zhuwenxi commented Dec 23, 2021

Copy link
Copy Markdown
ContributorAuthor

@comaniac Thank you, I've updated the plan, please let me know if there is still problems.

@comaniac
comaniac merged commit 1a3d4f1 into apache:mainDec 24, 2021
@comaniac

comaniac commented Dec 24, 2021

Copy link
Copy Markdown
Contributor

Thanks @zhuwenxi this is now merged.
Also please file a follow-up PR to add the RFC information (start date, RFC PR and RFC tracking issue). You can refer to other merged RFCs for details.

@zhuwenxi

zhuwenxi commented Dec 29, 2021

Copy link
Copy Markdown
ContributorAuthor

@comaniac OK, I'll update the RFC information soon.

@zhuwenxi

zhuwenxi commented Jan 13, 2022

Copy link
Copy Markdown
ContributorAuthor

@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?

@comaniac

comaniac commented Jan 13, 2022

Copy link
Copy Markdown
Contributor

@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?

You could refer to the PR like apache/tvm#9881 or something similar.

@zhuwenxi

zhuwenxi commented Jan 14, 2022

Copy link
Copy Markdown
ContributorAuthor

@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?

You could refer to the PR like apache/tvm#9881 or something similar.

Thank you!

@zhuwenxizhuwenxi mentioned this pull request Feb 7, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes

Assignees

@comaniaccomaniac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhuwenxi@comaniac
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[RFC] Integrate LIBXSMM with TVM. by zhuwenxi · Pull Request #47 · apache/tvm-rfcs · GitHub
Skip to content
[RFC] Integrate LIBXSMM with TVM. - #47
Merged
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Dec 24, 2021
Merged
[RFC] Integrate LIBXSMM with TVM.#47
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Conversation
@zhuwenxi
@zhuwenxizhuwenxi
commented
Dec 16, 2021

Copy link


Copy Markdown

Contributor
comaniac
comaniac
reviewed
Dec 16, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 17, 2021

Copy link


Copy Markdown

ContributorAuthor
Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Upstream plan added, at the end of RFC.
By the way, I'm not quite sure what "TVM CI" refers to? If it means unit tests, they will be included in their related PRs when I upstream my code.
@zhuwenxizhuwenxi
changed the title
RFC to integrate LIBXSMM with TVM.[RFC] Integrate LIBXSMM with TVM.Dec 18, 2021
@zhuwenxi
zhuwenxi
commented
Dec 21, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Any update?
comaniac
comaniac
approved these changes
Dec 21, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just try to polish the plan for the last time and we should be good to go.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Thank you, I've updated the plan, please let me know if there is still problems.
@comaniac
comaniac
merged commit 1a3d4f1
into
apache:mainDec 24, 2021
@comaniac
comaniac
commented
Dec 24, 2021

Copy link


Copy Markdown

Contributor
Thanks @zhuwenxi this is now merged.

Also please file a follow-up PR to add the RFC information (start date, RFC PR and RFC tracking issue). You can refer to other merged RFCs for details.
@zhuwenxi
zhuwenxi
commented
Dec 29, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac OK, I'll update the RFC information soon.
@zhuwenxi
zhuwenxi
commented
Jan 13, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
@comaniac
comaniac
commented
Jan 13, 2022

Copy link


Copy Markdown

Contributor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
@zhuwenxi
zhuwenxi
commented
Jan 14, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
Thank you!
@zhuwenxizhuwenxi
mentioned this pull request
Feb 7, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes

Assignees

@comaniaccomaniac

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zhuwenxi@comaniac

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RFC] Integrate LIBXSMM with TVM. by zhuwenxi · Pull Request #47 · apache/tvm-rfcs · GitHub
Skip to content
[RFC] Integrate LIBXSMM with TVM. - #47
Merged
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Dec 24, 2021
Merged
[RFC] Integrate LIBXSMM with TVM.#47
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Conversation
@zhuwenxi
@zhuwenxizhuwenxi
commented
Dec 16, 2021

Copy link


Copy Markdown

Contributor
comaniac
comaniac
reviewed
Dec 16, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 17, 2021

Copy link


Copy Markdown

ContributorAuthor
Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Upstream plan added, at the end of RFC.
By the way, I'm not quite sure what "TVM CI" refers to? If it means unit tests, they will be included in their related PRs when I upstream my code.
@zhuwenxizhuwenxi
changed the title
RFC to integrate LIBXSMM with TVM.[RFC] Integrate LIBXSMM with TVM.Dec 18, 2021
@zhuwenxi
zhuwenxi
commented
Dec 21, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Any update?
comaniac
comaniac
approved these changes
Dec 21, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just try to polish the plan for the last time and we should be good to go.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Thank you, I've updated the plan, please let me know if there is still problems.
@comaniac
comaniac
merged commit 1a3d4f1
into
apache:mainDec 24, 2021
@comaniac
comaniac
commented
Dec 24, 2021

Copy link


Copy Markdown

Contributor
Thanks @zhuwenxi this is now merged.

Also please file a follow-up PR to add the RFC information (start date, RFC PR and RFC tracking issue). You can refer to other merged RFCs for details.
@zhuwenxi
zhuwenxi
commented
Dec 29, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac OK, I'll update the RFC information soon.
@zhuwenxi
zhuwenxi
commented
Jan 13, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
@comaniac
comaniac
commented
Jan 13, 2022

Copy link


Copy Markdown

Contributor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
@zhuwenxi
zhuwenxi
commented
Jan 14, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
Thank you!
@zhuwenxizhuwenxi
mentioned this pull request
Feb 7, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes

Assignees

@comaniaccomaniac

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zhuwenxi@comaniac

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RFC] Integrate LIBXSMM with TVM. by zhuwenxi · Pull Request #47 · apache/tvm-rfcs · GitHub
Skip to content
[RFC] Integrate LIBXSMM with TVM. - #47
Merged
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Dec 24, 2021
Merged
[RFC] Integrate LIBXSMM with TVM.#47
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Conversation
@zhuwenxi
@zhuwenxizhuwenxi
commented
Dec 16, 2021

Copy link


Copy Markdown

Contributor
comaniac
comaniac
reviewed
Dec 16, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 17, 2021

Copy link


Copy Markdown

ContributorAuthor
Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Upstream plan added, at the end of RFC.
By the way, I'm not quite sure what "TVM CI" refers to? If it means unit tests, they will be included in their related PRs when I upstream my code.
@zhuwenxizhuwenxi
changed the title
RFC to integrate LIBXSMM with TVM.[RFC] Integrate LIBXSMM with TVM.Dec 18, 2021
@zhuwenxi
zhuwenxi
commented
Dec 21, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Any update?
comaniac
comaniac
approved these changes
Dec 21, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just try to polish the plan for the last time and we should be good to go.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Thank you, I've updated the plan, please let me know if there is still problems.
@comaniac
comaniac
merged commit 1a3d4f1
into
apache:mainDec 24, 2021
@comaniac
comaniac
commented
Dec 24, 2021

Copy link


Copy Markdown

Contributor
Thanks @zhuwenxi this is now merged.

Also please file a follow-up PR to add the RFC information (start date, RFC PR and RFC tracking issue). You can refer to other merged RFCs for details.
@zhuwenxi
zhuwenxi
commented
Dec 29, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac OK, I'll update the RFC information soon.
@zhuwenxi
zhuwenxi
commented
Jan 13, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
@comaniac
comaniac
commented
Jan 13, 2022

Copy link


Copy Markdown

Contributor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
@zhuwenxi
zhuwenxi
commented
Jan 14, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
Thank you!
@zhuwenxizhuwenxi
mentioned this pull request
Feb 7, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes

Assignees

@comaniaccomaniac

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zhuwenxi@comaniac

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[RFC] Integrate LIBXSMM with TVM. by zhuwenxi · Pull Request #47 · apache/tvm-rfcs · GitHub
Skip to content
[RFC] Integrate LIBXSMM with TVM. - #47
Merged
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Dec 24, 2021
Merged
[RFC] Integrate LIBXSMM with TVM.#47
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Conversation
@zhuwenxi
@zhuwenxizhuwenxi
commented
Dec 16, 2021

Copy link


Copy Markdown

Contributor
comaniac
comaniac
reviewed
Dec 16, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 17, 2021

Copy link


Copy Markdown

ContributorAuthor
Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Upstream plan added, at the end of RFC.
By the way, I'm not quite sure what "TVM CI" refers to? If it means unit tests, they will be included in their related PRs when I upstream my code.
@zhuwenxizhuwenxi
changed the title
RFC to integrate LIBXSMM with TVM.[RFC] Integrate LIBXSMM with TVM.Dec 18, 2021
@zhuwenxi
zhuwenxi
commented
Dec 21, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Any update?
comaniac
comaniac
approved these changes
Dec 21, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just try to polish the plan for the last time and we should be good to go.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Thank you, I've updated the plan, please let me know if there is still problems.
@comaniac
comaniac
merged commit 1a3d4f1
into
apache:mainDec 24, 2021
@comaniac
comaniac
commented
Dec 24, 2021

Copy link


Copy Markdown

Contributor
Thanks @zhuwenxi this is now merged.

Also please file a follow-up PR to add the RFC information (start date, RFC PR and RFC tracking issue). You can refer to other merged RFCs for details.
@zhuwenxi
zhuwenxi
commented
Dec 29, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac OK, I'll update the RFC information soon.
@zhuwenxi
zhuwenxi
commented
Jan 13, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
@comaniac
comaniac
commented
Jan 13, 2022

Copy link


Copy Markdown

Contributor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
@zhuwenxi
zhuwenxi
commented
Jan 14, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
Thank you!
@zhuwenxizhuwenxi
mentioned this pull request
Feb 7, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes

Assignees

@comaniaccomaniac

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zhuwenxi@comaniac

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RFC] Integrate LIBXSMM with TVM. by zhuwenxi · Pull Request #47 · apache/tvm-rfcs · GitHub
Skip to content
[RFC] Integrate LIBXSMM with TVM. - #47
Merged
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Dec 24, 2021
Merged
[RFC] Integrate LIBXSMM with TVM.#47
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Conversation
@zhuwenxi
@zhuwenxizhuwenxi
commented
Dec 16, 2021

Copy link


Copy Markdown

Contributor
comaniac
comaniac
reviewed
Dec 16, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 17, 2021

Copy link


Copy Markdown

ContributorAuthor
Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Upstream plan added, at the end of RFC.
By the way, I'm not quite sure what "TVM CI" refers to? If it means unit tests, they will be included in their related PRs when I upstream my code.
@zhuwenxizhuwenxi
changed the title
RFC to integrate LIBXSMM with TVM.[RFC] Integrate LIBXSMM with TVM.Dec 18, 2021
@zhuwenxi
zhuwenxi
commented
Dec 21, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Any update?
comaniac
comaniac
approved these changes
Dec 21, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just try to polish the plan for the last time and we should be good to go.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Thank you, I've updated the plan, please let me know if there is still problems.
@comaniac
comaniac
merged commit 1a3d4f1
into
apache:mainDec 24, 2021
@comaniac
comaniac
commented
Dec 24, 2021

Copy link


Copy Markdown

Contributor
Thanks @zhuwenxi this is now merged.

Also please file a follow-up PR to add the RFC information (start date, RFC PR and RFC tracking issue). You can refer to other merged RFCs for details.
@zhuwenxi
zhuwenxi
commented
Dec 29, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac OK, I'll update the RFC information soon.
@zhuwenxi
zhuwenxi
commented
Jan 13, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
@comaniac
comaniac
commented
Jan 13, 2022

Copy link


Copy Markdown

Contributor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
@zhuwenxi
zhuwenxi
commented
Jan 14, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
Thank you!
@zhuwenxizhuwenxi
mentioned this pull request
Feb 7, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes

Assignees

@comaniaccomaniac

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zhuwenxi@comaniac

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[RFC] Integrate LIBXSMM with TVM. by zhuwenxi · Pull Request #47 · apache/tvm-rfcs · GitHub
Skip to content
[RFC] Integrate LIBXSMM with TVM. - #47
Merged
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Dec 24, 2021
Merged
[RFC] Integrate LIBXSMM with TVM.#47
comaniac merged 8 commits into
apache:mainfrom 
zhuwenxi:Intel_LIBXSMM_integration
Conversation
@zhuwenxi
@zhuwenxizhuwenxi
commented
Dec 16, 2021

Copy link


Copy Markdown

Contributor
comaniac
comaniac
reviewed
Dec 16, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 17, 2021

Copy link


Copy Markdown

ContributorAuthor
Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
  1. Add libxsmm to the TVM CI.
  2. Add libxsmm to TOPI.
  3. Add libxsmm to Relay op strategy.
  4. Add libxsmm to BYOC.
Upstream plan added, at the end of RFC.
By the way, I'm not quite sure what "TVM CI" refers to? If it means unit tests, they will be included in their related PRs when I upstream my code.
@zhuwenxizhuwenxi
changed the title
RFC to integrate LIBXSMM with TVM.[RFC] Integrate LIBXSMM with TVM.Dec 18, 2021
@zhuwenxi
zhuwenxi
commented
Dec 21, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Any update?
comaniac
comaniac
approved these changes
Dec 21, 2021
View reviewed changes
@comaniaccomaniac
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just try to polish the plan for the last time and we should be good to go.
Comment threadrfcs/0046-Intel-LIBXSMM-integration.md
Outdated

@zhuwenxi
zhuwenxi
commented
Dec 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac Thank you, I've updated the plan, please let me know if there is still problems.
@comaniac
comaniac
merged commit 1a3d4f1
into
apache:mainDec 24, 2021
@comaniac
comaniac
commented
Dec 24, 2021

Copy link


Copy Markdown

Contributor
Thanks @zhuwenxi this is now merged.

Also please file a follow-up PR to add the RFC information (start date, RFC PR and RFC tracking issue). You can refer to other merged RFCs for details.
@zhuwenxi
zhuwenxi
commented
Dec 29, 2021

Copy link


Copy Markdown

ContributorAuthor
@comaniac OK, I'll update the RFC information soon.
@zhuwenxi
zhuwenxi
commented
Jan 13, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
@comaniac
comaniac
commented
Jan 13, 2022

Copy link


Copy Markdown

Contributor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
@zhuwenxi
zhuwenxi
commented
Jan 14, 2022

Copy link


Copy Markdown

ContributorAuthor
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to?
You could refer to the PR like apache/tvm#9881 or something similar.
Thank you!
@zhuwenxizhuwenxi
mentioned this pull request
Feb 7, 2022
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes

Assignees

@comaniaccomaniac

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zhuwenxi@comaniac