') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add Target Features RFC by Mousius · Pull Request #78 · apache/tvm-rfcs · GitHub
Skip to content

Add Target Features RFC - #78

Merged
areusch merged 1 commit into
apache:mainfrom
Mousius:target-features
Aug 22, 2022
Merged

Add Target Features RFC#78
areusch merged 1 commit into
apache:mainfrom
Mousius:target-features

Conversation

@Mousius

@MousiusMousius commented Jun 9, 2022

Copy link
Copy Markdown
Member

No description provided.

@MousiusMousius mentioned this pull request Jun 9, 2022
Merged
@areusch

areusch commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

cc @kparzysz-quic@tqchen@jwfromm@masahi@junrushao1994@comaniac

areusch
areusch reviewed Jun 21, 2022
View reviewed changes

@areuschareusch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mousius added a question. would you like to discuss at a Community Meeting?

Comment threadrfcs/0078-target-features.md
The `Target` can be directly inspected:

```python
if target.features.dsp:

@areuschareuschJun 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we adopt any namespacing? if so how would we represent that with this syntax?

@MousiusMousiusAug 2, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hopeful for the initial pass we can work with target.features.X rather than further namespacing - most of what I've seen in other compilers is a flat array seems to work.

@Mousius

Mousius commented Jun 29, 2022

Copy link
Copy Markdown
MemberAuthor

@Mousius added a question. would you like to discuss at a Community Meeting?

Happy to do a quick update on where this went 😸

@kparzysz-quic

kparzysz-quic commented Jul 15, 2022

Copy link
Copy Markdown

If we add another member to Target, how will this interact with the target parser proposal?

@Mousius

Mousius commented Jul 15, 2022

Copy link
Copy Markdown
MemberAuthor

If we add another member to Target, how will this interact with the target parser proposal?

The hope is to use the target parser to parse out the features as it'd just be an additional field we can set:

target_json.Set("features", features_map);

Mousius added a commit to Mousius/tvm that referenced this pull request Jul 18, 2022
@Mousius
[Target] Add "features" property to Target
eeedb1d
This adds a generated property "features" to the `Target` which can
contain a read-only list of available features in line with
apache/tvm-rfcs#78.
Features are re-generated upon parsing into a `Target` object rather than being
attached as `attrs`. The `Target` JSON is therefore stored without the
inferred `features` attached.
@MousiusMousius mentioned this pull request Jul 18, 2022
Merged
Mousius added a commit to Mousius/tvm that referenced this pull request Jul 19, 2022
@Mousius
[Target] Add "features" property to Target
7e0652f
This adds a generated property "features" to the `Target` which can
contain a read-only list of available features in line with
apache/tvm-rfcs#78.
Features are re-generated upon parsing into a `Target` object rather than being
attached as `attrs`. The `Target` JSON is therefore stored without the
inferred `features` attached.
kparzysz-quic pushed a commit to apache/tvm that referenced this pull request Jul 19, 2022
@Mousius
[Target] Add "features" property to Target (#12121)
7bf5fa4
This adds a generated property "features" to the `Target` which can
contain a read-only list of available features in line with
apache/tvm-rfcs#78.
Features are re-generated upon parsing into a `Target` object rather than being
attached as `attrs`. The `Target` JSON is therefore stored without the
inferred `features` attached.
areusch
areusch approved these changes Aug 19, 2022
View reviewed changes

@areuschareusch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's call this accepted since we're implementing it :)

@areusch
areusch merged commit 1ab898d into apache:mainAug 22, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@Mousius@xinetzone
[Target] Add "features" property to Target (apache#12121)
856ddf5
This adds a generated property "features" to the `Target` which can
contain a read-only list of available features in line with
apache/tvm-rfcs#78.
Features are re-generated upon parsing into a `Target` object rather than being
attached as `attrs`. The `Target` JSON is therefore stored without the
inferred `features` attached.
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
@MousiusMikael Sevenier
[Target] Add "features" property to Target (apache#12121)
182c9c9
This adds a generated property "features" to the `Target` which can
contain a read-only list of available features in line with
apache/tvm-rfcs#78.
Features are re-generated upon parsing into a `Target` object rather than being
attached as `attrs`. The `Target` JSON is therefore stored without the
inferred `features` attached.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@areuschareuschareusch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mousius@areusch@kparzysz-quic