Skip to content

[Runtime][PackedFunc] Bring PackedFunc into TVM Object System - #10032

Merged
junrushao merged 9 commits into
apache:mainfrom
cyx-6:PackedFuncObj
Feb 3, 2022
Merged

[Runtime][PackedFunc] Bring PackedFunc into TVM Object System#10032
junrushao merged 9 commits into
apache:mainfrom
cyx-6:PackedFuncObj

Conversation

@cyx-6

@cyx-6cyx-6 commented Jan 23, 2022

Copy link
Copy Markdown
Contributor

This PR allows developers to use PackedFunc as TVM objects, which completes the last missing step of TVM runtime object system.

junrushao
junrushao requested changes Jan 23, 2022
View reviewed changes
Comment threadinclude/tvm/runtime/packed_func.h Outdated
Comment threadinclude/tvm/runtime/packed_func.h Outdated
Comment threadinclude/tvm/runtime/packed_func.h Outdated
Comment threadinclude/tvm/runtime/packed_func.h Outdated
Comment threadinclude/tvm/runtime/packed_func.h Outdated
Comment threadinclude/tvm/runtime/packed_func.h
Comment threadinclude/tvm/runtime/packed_func.h Outdated
Comment threadinclude/tvm/runtime/packed_func.h
Comment threadinclude/tvm/runtime/packed_func.h Outdated
Comment threadinclude/tvm/runtime/packed_func.h Outdated
@junrushao

junrushao commented Jan 23, 2022

Copy link
Copy Markdown
Member

Nice PR @cyx-6! Please also fix the lint and let's get it tested in our CI!

@junrushaojunrushao mentioned this pull request Feb 1, 2022
Merged
@junrushao

junrushao commented Feb 2, 2022

Copy link
Copy Markdown
Member

RFC: apache/tvm-rfcs#51

junrushao
junrushao reviewed Feb 2, 2022
View reviewed changes
Comment threadinclude/tvm/runtime/packed_func.h
junrushao
junrushao approved these changes Feb 3, 2022
View reviewed changes

@junrushaojunrushao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao
junrushao merged commit f929b0f into apache:mainFeb 3, 2022
@junrushao

junrushao commented Feb 3, 2022

Copy link
Copy Markdown
Member

Thanks @cyx-6 for the huge effort! It's merged!!

mbs-octoml pushed a commit to mbs-octoml/mbs-tvm that referenced this pull request Feb 5, 2022
@cyx-6@mbs-octoml
[Runtime][PackedFunc] BringPackedFuncinto TVM Object System (apac…
41fcf8e
…he#10032)
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
@cyx-6@ylc
[Runtime][PackedFunc] BringPackedFuncinto TVM Object System (apac…
40b4471
…he#10032)
@zxybazhzxybazh mentioned this pull request Apr 28, 2022
Merged
@driazatidriazati mentioned this pull request Jul 14, 2022
Closed
@cyx-6
cyx-6 deleted the PackedFuncObj branch July 16, 2026 06:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junrushaojunrushaojunrushao approved these changes
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@jroeschjroeschAwaiting requested review from jroesch
@kazumkazumAwaiting requested review from kazum
@kparzysz-quickparzysz-quicAwaiting requested review from kparzysz-quic
@liangfuliangfuAwaiting requested review from liangfu
@masahimasahiAwaiting requested review from masahi
@tmoreau89tmoreau89Awaiting requested review from tmoreau89
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang
@icemelonicemelonAwaiting requested review from icemelon
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyx-6@junrushao