Skip to content

[Relay] QLinearMatMul allows 1D weight_scale, weight_zero_point inputs - #10047

Merged
masahi merged 5 commits into
apache:mainfrom
yuanfz98:qlinearmatmul_v3
Jan 26, 2022
Merged

[Relay] QLinearMatMul allows 1D weight_scale, weight_zero_point inputs#10047
masahi merged 5 commits into
apache:mainfrom
yuanfz98:qlinearmatmul_v3

Conversation

@yuanfz98

@yuanfz98yuanfz98 commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

Hello,

This PR is to fix#9908. Previously I made a mistake in git (#9946), now this is a clean PR.

@AndrewZhaoLuo Thank you for your code review, very valuable advice !

AndrewZhaoLuo
AndrewZhaoLuo approved these changes Jan 25, 2022
View reviewed changes

@AndrewZhaoLuoAndrewZhaoLuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit

Comment threadpython/tvm/relay/frontend/onnx.py
AndrewZhaoLuo
AndrewZhaoLuo reviewed Jan 25, 2022
View reviewed changes

@AndrewZhaoLuoAndrewZhaoLuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FZYUAN-1

Looks like CI bugged out (we recently moved servers I think). You can redo CI by pushing an empty commit e.g. git commit -m 'jostle' --allow-empty and git push

After CI passes I will merge

@yuanfz98

yuanfz98 commented Jan 25, 2022

Copy link
Copy Markdown
ContributorAuthor

@FZYUAN-1

Looks like CI bugged out (we recently moved servers I think). You can redo CI by pushing an empty commit e.g. git commit -m 'jostle' --allow-empty and git push

After CI passes I will merge

Thanks. Done.

@AndrewZhaoLuo

AndrewZhaoLuo commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Need to jostle again, looks like the CI folks did not enable autoscaling until now so your job timed out.

@yuanfz98

yuanfz98 commented Jan 26, 2022

Copy link
Copy Markdown
ContributorAuthor

Need to jostle again, looks like the CI folks did not enable autoscaling until now so your job timed out.

Done.

@masahi
masahi merged commit 90e454a into apache:mainJan 26, 2022
sunggg pushed a commit to sunggg/tvm that referenced this pull request Jan 29, 2022
@yuanfz98@sunggg
[Relay] QLinearMatMul allows 1D weight_scale, weight_zero_point inputs (
5bee3c0
apache#10047)
* fix after cr
* fix after cr 2
* emptycommit
* emptycommit 2nd try
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
@yuanfz98@ylc
[Relay] QLinearMatMul allows 1D weight_scale, weight_zero_point inputs (
b174f2e
apache#10047)
* fix after cr
* fix after cr 2
* emptycommit
* emptycommit 2nd try
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HuyuweiHuyuweiAwaiting requested review from Huyuwei
@jwfrommjwfrommAwaiting requested review from jwfromm
@kazumkazumAwaiting requested review from kazum
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@siju-samuelsiju-samuelAwaiting requested review from siju-samuel
@srkreddy1238srkreddy1238Awaiting requested review from srkreddy1238
@AndrewZhaoLuoAndrewZhaoLuoAwaiting requested review from AndrewZhaoLuo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [ONNX] QLinearMatMul works with binary output only

3 participants

@yuanfz98@AndrewZhaoLuo@masahi