Uh oh!
There was an error while loading. Please reload this page.
[TE] Promote substituted variable to iter_var's dtype - #10571
Conversation
This fixes a bug where an iteration variable and its associated loop variable have a mismatched dtype.
tkonolige
commented
Mar 11, 2022
This problem is a lot more complicated than I initially thought. It is actually two problems: 1. |
Interesting, does this change remove the need for fixes in the following PRs? I've been trying to compile the QAT BERT from mlperf via various ways but I consistently get the int32 vs int64 dtype mismatch like: |
tkonolige
commented
Mar 11, 2022
I think it may fix the middle and top issues, but I'm not positive. Also, we should think about checking that every |
masahi
commented
Mar 11, 2022
just sent a PR fixing a related problem (one of my errors above) |
mbrookhart
left a comment
There was a problem hiding this comment.
@junrushao1994@masahi Any concerns with this?
* [TE] Promote substituted variable to iter_var's dtype This fixes a bug where an iteration variable and its associated loop variable have a mismatched dtype. * add check to iter var constructor. fix two bad uses * proplem is more complicated then I thought * one more fix * remove old comments
This fixes a bug where an iteration variable and its associated loop variable have a mismatched dtype.
@mbrookhart@junrushao1994