Uh oh!
There was an error while loading. Please reload this page.
[TVMC] compile: Check if FILE exists - #10608
Merged
Merged
Conversation
gromero
commented
Mar 14, 2022
ContributorAuthor
cc @leandron |
ContributorAuthor
@leandron Thanks for the review. Do you know what's not pleasing the CI now? The result says: I really have no clue what happens here... |
leandron
commented
Mar 15, 2022
Contributor
Looks like a transient: see |
ContributorAuthor
@leandron hmm I see it now. But also it says: and since it's in the CI, shouldn't we mark it as "xfail" ? I think reporting every time in HG it fails in the CI is a big ask no? |
gromero
commented
Mar 15, 2022
ContributorAuthor
Anyways, I'm re-triggering 👍 |
gromeroforce-pushed
the
improve_error_handling_tvmc_compile
branch
2 times, most recently
from
March 18, 2022 23:18
eb20470 to
7765793Compareareusch
reviewed
Mar 23, 2022
| try: | ||
| tvmc_model = frontends.load_model(args.FILE, args.model_format, args.input_shapes) | ||
| except FileNotFoundError: | ||
| raise TVMCException(f"Input file {args.FILE} does not exist!") |
Contributor
There was a problem hiding this comment.
what about just checking if os.exists(args.FILE) rather than assuming all FileNotFoundError relate to the input file?
ContributorAuthor
There was a problem hiding this comment.
@areusch yeah I was unsure about that option or the one I've used. Sure, let's use os.path. I just used os.path.isfile() instead of os.path.exists() because exists() will also return true if FILE is a directory, which is also invalid in that context. PTAL. Thanks!
Currently when a non-existing FILE is passed to 'tvmc compile' it throws a traceback because a FileNotFoundError exception is not handled. Since there is no need for such abrupt exit, and the trace can also confuse users, this commit fixes it by checking if FILE indeed exists, informing the user about the non-existing FILE before exiting. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
gromeroforce-pushed
the
improve_error_handling_tvmc_compile
branch
from
March 23, 2022 21:55
7765793 to
6dd1bc1Comparegromero added a commit
to gromero/tvm
that referenced
this pull request
Apr 1, 2022
Currently when a non-existing FILE is passed to 'tvmc tune' it throws a traceback because a FileNotFoundError exception is not handled. Since there is no need for such abrupt exit, and the trace can also confuse users, this commit fixes it by checking if FILE indeed exists, kindly informing the user about the non-existing FILE before exiting. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
gromero added a commit
to gromero/tvm
that referenced
this pull request
Apr 4, 2022
Currently when a non-existing FILE is passed to 'tvmc tune' it throws a traceback because a FileNotFoundError exception is not handled. Since there is no need for such abrupt exit, and the trace can also confuse users, this commit fixes it by checking if FILE indeed exists, kindly informing the user about the non-existing FILE before exiting. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
gromero added a commit
to gromero/tvm
that referenced
this pull request
Apr 5, 2022
Currently when a non-existing FILE is passed to 'tvmc tune' it throws a traceback because a FileNotFoundError exception is not handled. Since there is no need for such abrupt exit, and the trace can also confuse users, this commit fixes it by checking if FILE indeed exists, kindly informing the user about the non-existing FILE before exiting.
pfk-beta pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Currently when a non-existing FILE is passed to 'tvmc compile' it throws a traceback because a FileNotFoundError exception is not handled. Since there is no need for such abrupt exit, and the trace can also confuse users, this commit fixes it by checking if FILE indeed exists, informing the user about the non-existing FILE before exiting. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
gromero added a commit
to gromero/tvm
that referenced
this pull request
Apr 14, 2022
Currently when a non-existing FILE is passed to 'tvmc tune' it throws a traceback because a FileNotFoundError exception is not handled. Since there is no need for such abrupt exit, and the trace can also confuse users, this commit fixes it by checking if FILE indeed exists, kindly informing the user about the non-existing FILE before exiting.
gromero added a commit
to gromero/tvm
that referenced
this pull request
Apr 20, 2022
Currently when a non-existing FILE is passed to 'tvmc tune' it throws a traceback because a FileNotFoundError exception is not handled. Since there is no need for such abrupt exit, and the trace can also confuse users, this commit fixes it by checking if FILE indeed exists, kindly informing the user about the non-existing FILE before exiting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a non-existing FILE is passed to 'tvmc compile' it throws
a traceback because a FileNotFoundError exception is not handled. Since
there is no need for such abrupt exit, and the trace can also confuse
users, this commit fixes it by checking if FILE indeed exists, informing
the user about the non-existing FILE before exiting.