Skip to content

[Arith] Fix floormod rewrite simplify rule - #10626

Merged
junrushao merged 1 commit into
apache:mainfrom
vinx13:fix-arith
Mar 16, 2022
Merged

[Arith] Fix floormod rewrite simplify rule#10626
junrushao merged 1 commit into
apache:mainfrom
vinx13:fix-arith

Conversation

@vinx13

@vinx13vinx13 commented Mar 15, 2022

Copy link
Copy Markdown
Member

@tkonolige

tkonolige commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

This PR supersedes #10618.

@vinx13 can you confirm that the error is no longer present if seed = 8607320357002032383 here: https://github.com/apache/tvm/blob/main/tests/python/unittest/test_arith_solve_linear_inequality.py#L25?

@vinx13

vinx13 commented Mar 15, 2022

Copy link
Copy Markdown
MemberAuthor

@tkonolige I can confirm it pass the test with the given seed

@driazatidriazati mentioned this pull request Mar 16, 2022
Closed
@junrushao
junrushao merged commit 6991396 into apache:mainMar 16, 2022
@masahimasahi mentioned this pull request Mar 16, 2022
Merged
@vinx13vinx13 mentioned this pull request Apr 4, 2022
Closed
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
@vinx13pfk-beta
[Arith] Fix floormod rewrite simplify rule (apache#10626)
b074a55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junrushaojunrushaojunrushao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinx13@tkonolige@junrushao