Uh oh!
There was an error while loading. Please reload this page.
[MetaSchedule][Refactor] Clarify Integration Logic - #10927
Conversation
58e5af3 to
ceb2bc2Compareceb2bc2 to
ab67e5fComparesunggg
commented
Apr 7, 2022
Overall, LGTM. |
junrushao
commented
Apr 7, 2022
@sunggg Thanks for asking! There is no breaking change in terms of API usage, given ApplyHistoryBest is the only framework-facing integration point. It's still used in the same way like: withApplyHistoryBest(database=...):
...
|
junrushao
commented
Apr 7, 2022
@sunggg For now, |
sunggg
commented
Apr 7, 2022
@junrushao1994 Thank you for the explanation. Makes sense to me. |
Based on @masahi's PR #10578, we are able to further simplify the logic and remove redundancy.
Changes:
MetaScheduleContext, which is not useful any more after Masa's new relay backend;ApplyHistoryBest, and slightly improve the error message;integration.pyinto 3 files:apply_history_best.py,extracted_task.pyandrelay_integration.py;These changes make future Relax integration easier - the only thing needed is to add
relax_integration.pywithout having to worry about potential conflicts.