Skip to content

[build][hexagon] fix several compiler warnings - #11245

Merged
mehrdadh merged 1 commit into
apache:mainfrom
cconvey:fix-hexagon-compiler-warnings
May 16, 2022
Merged

[build][hexagon] fix several compiler warnings#11245
mehrdadh merged 1 commit into
apache:mainfrom
cconvey:fix-hexagon-compiler-warnings

Conversation

@cconvey

@cconveycconvey commented May 9, 2022

Copy link
Copy Markdown
Contributor

[build][hexagon] fix several compiler warnings

Fix several compiler warnings for Hexagon code.

cc @mehrdadh

@cconvey
cconveyforce-pushed the fix-hexagon-compiler-warnings branch from 6c67b2f to a0c58acCompareMay 9, 2022 14:46
@github-actions
github-actionsBot requested a review from mehrdadhMay 9, 2022 14:46
@cconvey
cconveyforce-pushed the fix-hexagon-compiler-warnings branch from a0c58ac to e461dc8CompareMay 9, 2022 14:50
@cconveycconvey changed the title [build][hexagon] disable warning in generated code[build][hexagon] fix several compiler warningsMay 9, 2022
@cconvey
cconvey marked this pull request as draft May 9, 2022 14:51
Comment threadcmake/modules/Hexagon.cmake Outdated
@cconvey
cconveyforce-pushed the fix-hexagon-compiler-warnings branch from e461dc8 to 9e013e4CompareMay 9, 2022 18:37
@cconvey
cconvey marked this pull request as ready for review May 9, 2022 19:42
@cconvey

Copy link
Copy Markdown
ContributorAuthor

CC: @kparzysz-quic

Comment threadsrc/runtime/hexagon/rpc/simulator/session.cc Outdated

@kparzysz-quickparzysz-quic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of comments.

Comment threadsrc/runtime/hexagon/rpc/simulator/session.cc Outdated
Comment threadcmake/modules/Hexagon.cmake Outdated
@cconveycconvey changed the title [build][hexagon] fix several compiler warningsWIP [build][hexagon] fix several compiler warningsMay 10, 2022
@cconvey

cconvey commented May 13, 2022

Copy link
Copy Markdown
ContributorAuthor

I'll slightly rework this PR once #11245 is merged.

@cconvey
cconveyforce-pushed the fix-hexagon-compiler-warnings branch from 9e013e4 to c63e08cCompareMay 13, 2022 18:10
@cconveycconvey changed the title WIP [build][hexagon] fix several compiler warnings[build][hexagon] fix several compiler warningsMay 13, 2022
@cconvey
cconveyforce-pushed the fix-hexagon-compiler-warnings branch from c63e08c to e3ae8d7CompareMay 15, 2022 17:53
@cconvey

Copy link
Copy Markdown
ContributorAuthor

@mehrdadh : Ready for merge if/when you're happy.

@mehrdadhmehrdadh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mehrdadh
mehrdadh merged commit ebf3607 into apache:mainMay 16, 2022
@cconvey
cconvey deleted the fix-hexagon-compiler-warnings branch May 16, 2022 21:23
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
shingjan pushed a commit to shingjan/tvm that referenced this pull request May 17, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cconvey@mehrdadh@kparzysz-quic