') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [Schedule] Allowed typing.Tuple in tir.schedule._type_checker by Lunderberg · Pull Request #11289 · apache/tvm · GitHub
Skip to content

[Schedule] Allowed typing.Tuple in tir.schedule._type_checker - #11289

Merged
vinx13 merged 5 commits into
apache:mainfrom
Lunderberg:type_check_tuple
May 20, 2022
Merged

[Schedule] Allowed typing.Tuple in tir.schedule._type_checker#11289
vinx13 merged 5 commits into
apache:mainfrom
Lunderberg:type_check_tuple

Conversation

@Lunderberg

@LunderbergLunderberg commented May 12, 2022

Copy link
Copy Markdown
Contributor

Previously, typing.Tuple annotations could not be used with tir.schedule._type_checker.type_checked annotations. This allows Tuple type annotations to be type-checked.

@Lunderberg
[Schedule] Allowed typing.Tuple in tir.schedule._type_checker
8193fac
Previously, `typing.Tuple` annotations could not be used with
`tir.schedule._type_checker.type_checked` annotations. This allows
`Tuple` type annotations to be type-checked.
@LunderbergLunderberg mentioned this pull request May 12, 2022
Merged
vinx13
vinx13 reviewed May 12, 2022
View reviewed changes
Comment threadpython/tvm/tir/schedule/_type_checker.py Outdated
@junrushao

junrushao commented May 13, 2022

Copy link
Copy Markdown
Member

Thanks for improving the type checker! Maybe at some time point we could together propose to lift this to top-level TVM utility with an RFC :-)

@Lunderberg
Suppress mypy errors
0bb2bbd
Directly interacting with a type object would otherwise cause some
false positives.
@Lunderberg
Corrected unit test for allowing tuples to be used as typing.List
6b745c3
@Lunderberg
Represent multi-type lists as List[Union[...]] instead of List[Any]
14c0e48
This gives a better error message and plays nicely with _type2str,
since `typing.Any` doesn't have a `__name__` field.
@Lunderberg
Lunderberg marked this pull request as ready for review May 19, 2022 13:18
@Lunderberg

Lunderberg commented May 19, 2022

Copy link
Copy Markdown
ContributorAuthor

@vinx13@junrushao1994 CI passing, and ready for review.

@vinx13
vinx13 merged commit 72a5219 into apache:mainMay 20, 2022
@Lunderberg
Lunderberg deleted the type_check_tuple branch May 20, 2022 17:28
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request May 20, 2022
@Lunderberg
Re-enable type checks of transform_layout/set_axis_separator
99fb775
Disabled while waiting for apache#11289,
which was required for the `Tuple` argument.
vinx13 pushed a commit that referenced this pull request May 26, 2022
@Lunderberg
[TIR][Schedule] Transform layout quality of life (#11269)
814f550
* [TIR][Schedule] Added Schedule.transform_layout_sugared
* [TE][TIR] Reduced duplication in TE/TIR layout transformations
Previously, the implementations of `tir.IndexMap.from_func` and
`te.Stage.transform_layout` had significant duplication to handle
argument parsing. This commit extracts the shared logic into
`tir.IndexMap`.
* Enabled *args in Schedule.transform_layout_sugared
* Fix lint error
* Allow Schedule.transform_layout_sugared to set axis separators
* Merged transform_layout_sugared functionality into transform_layout
* Fix lint errors
* Fix lint error
* Fixed docstring errors
* Updated/tested TransformatLayoutTraits::UnpackedAsPython
* Disabled exec-used check for running trace.as_python()
* Updated SetAxisSeparatorTraits::UnpackedAsPython
* Updated unit test that was added in merge commit
* Fixed the argument name for TensorizeTraits
This wasn't checked before, but was the only other issue caught by the
updates to verify_trace_roundtrip.
* Re-enable type checks of transform_layout/set_axis_separator
Disabled while waiting for #11289,
which was required for the `Tuple` argument.
* Updated a few additional transform_layout usages from main
@driazatidriazati mentioned this pull request Jul 14, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinx13vinx13vinx13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lunderberg@junrushao@vinx13