Skip to content

[ci][1/n] Rebuild Docker images if necessary - #11329

Merged
Mousius merged 1 commit into
apache:mainfrom
driazati:rebuild_images2
Jun 9, 2022
Merged

[ci][1/n] Rebuild Docker images if necessary#11329
Mousius merged 1 commit into
apache:mainfrom
driazati:rebuild_images2

Conversation

@driazati

@driazatidriazati commented May 16, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This sets us up to rebuild Docker images and uses them in later stages in the same build. This is not yet enabled (see the commented out code in DockerBuild.groovy.j2. If the build is running on main, then the images are uploaded to Docker Hub automatically once the run is complete. To avoid landing a complicated infra PR all at once this mostly adds the scaffolding and a follow up PR will: 1. upload images to tlcpack instead of tlcpackstaging 2. dynamically determine the docker image to use based on the latest hash 3. always rebuild docker images if an updated one hasn't been uploaded

cc @Mousius@areusch

@driazatidriazati mentioned this pull request May 17, 2022
Open
@driazatidriazati changed the title [ci][wip] Rebuild Docker images if necessary[ci] Rebuild Docker images if necessaryMay 18, 2022
@driazati
driazati marked this pull request as ready for review May 18, 2022 18:01
areusch
areusch reviewed May 18, 2022
View reviewed changes

@areuschareusch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @driazati, added some comments

Comment threadjenkins/Jenkinsfile.j2 Outdated
Comment threadjenkins/Jenkinsfile.j2 Outdated
Comment threadjenkins/Jenkinsfile.j2 Outdated
Comment threadtests/scripts/git_utils.py Outdated
Comment threadtests/scripts/should_rebuild_docker.py Outdated
Comment threadtests/scripts/should_rebuild_docker.py
@github-actions
github-actionsBot requested a review from MousiusMay 18, 2022 19:30
@areusch

areusch commented May 18, 2022

Copy link
Copy Markdown
Contributor

cool! i think this looks good to me, will let @Mousius have a look.

also cc @leandron

@driazati

driazati commented May 19, 2022

Copy link
Copy Markdown
MemberAuthor

just a note for reviewers: the code is 99% done but will take a couple more iterations through CI once it’s verified before it can be merged (ie right now it still has testing code specific to this PR)

Mousius
Mousius requested changes May 19, 2022
View reviewed changes

@MousiusMousius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this Jenkinsfile is getting fun 😸 Thanks for working through this @driazati, is it possible to document some of the flow here in terms of using ECR as an intermediary cache before Docker Hub? Not necessarily this PR but it'd be great to have as a reference

Comment threadtests/scripts/git_utils.py Outdated
Comment threadtests/python/ci/test_ci.py Outdated
Comment threadtests/python/ci/test_ci.py Outdated
Comment threadtests/scripts/cmd_utils.py Outdated
Comment threadtests/python/ci/test_ci.py Outdated
Comment threadjenkins/Jenkinsfile.j2 Outdated
Comment threadjenkins/Jenkinsfile.j2 Outdated
Comment threadjenkins/Jenkinsfile.j2 Outdated
Comment threadjenkins/Jenkinsfile.j2 Outdated
).trim()
def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
{% for image in images %}
update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")

@MousiusMousiusMay 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is literally for testing, but I'll leave a comment just in case 😸

Suggested change
update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
update_docker({{ image.name }}, "tlcpackstaging/{{ image.name }}:${tag}")

Comment threadjenkins/Jenkinsfile.j2 Outdated
@driazatidriazati mentioned this pull request May 19, 2022
Closed
@driazatidriazati changed the title [ci] Rebuild Docker images if necessary[ci] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati changed the title [ci] Add code to rebuild Docker images if necessary[ci][1/n] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati changed the title [ci][1/n] Add code to rebuild Docker images if necessary[ci][1/n] Rebuild Docker images if necessaryMay 31, 2022
@driazati

driazati commented May 31, 2022

Copy link
Copy Markdown
MemberAuthor

@Mousius I've re-worked this PR a bit, I'm weary about landing it all at once since it can potentially have a big impact on CI times. In a follow up PR I'll enable the docker image rebuilds based on the Docker Hub hashes behind a flag in Jenkins so we can turn it off if we need to, but this one is ready to go now

@driazati
driazati requested a review from MousiusJune 1, 2022 14:59
@driazati

driazati commented Jun 3, 2022

Copy link
Copy Markdown
MemberAuthor

@tvm-bot rerun

Mousius
Mousius approved these changes Jun 6, 2022
View reviewed changes

@MousiusMousius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati I left a few questions but I'm ok with follow up in the next in the PR series. I also manually triggered CI to re-run as the bot didn't seem to be doing it?

Comment threadjenkins/Build.groovy.j2 Outdated
timeout(time: max_time, unit: 'MINUTES') {
try {
cmake_build(docker_type, path, make_flag)
// always run cpp test when build

@MousiusMousiusJun 6, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment has been sneaking around with this function but actually no longer relates to this function?

Comment threadjenkins/Deploy.groovy.j2
).trim()
def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
{% for image in images %}
update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")

@MousiusMousiusJun 6, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is just to avoid conflicts with the over night build?

@driazatidriazatiJun 7, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, in the follow up(s) we'll switch it over

@driazati

driazati commented Jun 7, 2022

Copy link
Copy Markdown
MemberAuthor

I also manually triggered CI to re-run as the bot didn't seem to be doing it?

the bot is broken but fixes are in flight, we're looking into better ways to test these kinds of things before deploying (e.g. the merge functionality also isn't working due to some auth errors I haven't been able to sort out yet)

@driazati
[ci] Rebuild Docker images if necessary
69363eb
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@Mousius
Mousius merged commit 6d557ff into apache:mainJun 9, 2022
@Mousius

Mousius commented Jun 9, 2022

Copy link
Copy Markdown
Member

Nice work @driazati, looking forward to seeing this fully functional 😸

Kathryn-cat pushed a commit to Kathryn-cat/tvm that referenced this pull request Jun 10, 2022
@driazati@Kathryn-cat
[ci] Rebuild Docker images if necessary (apache#11329)
dd75257
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@driazatidriazati mentioned this pull request Jun 10, 2022
Closed
@driazatidriazati mentioned this pull request Jul 14, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@MousiusMousiusMousius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@Mousius
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[ci][1/n] Rebuild Docker images if necessary by driazati · Pull Request #11329 · apache/tvm · GitHub
Skip to content
[ci][1/n] Rebuild Docker images if necessary - #11329
Merged
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Jun 9, 2022
Merged
[ci][1/n] Rebuild Docker images if necessary#11329
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Conversation
@driazati
@driazatidriazati
commented
May 16, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This sets us up to rebuild Docker images and uses them in later stages in the same build. This is not yet enabled (see the commented out code in DockerBuild.groovy.j2. If the build is running on main, then the images are uploaded to Docker Hub automatically once the run is complete. To avoid landing a complicated infra PR all at once this mostly adds the scaffolding and a follow up PR will: 1. upload images to tlcpack instead of tlcpackstaging 2. dynamically determine the docker image to use based on the latest hash 3. always rebuild docker images if an updated one hasn't been uploaded
cc @Mousius@areusch
@driazatidriazati
mentioned this pull request
May 17, 2022
 Open

@driazatidriazati
changed the title
[ci][wip] Rebuild Docker images if necessary[ci] Rebuild Docker images if necessaryMay 18, 2022
@driazati
driazati
marked this pull request as ready for review
May 18, 2022 18:01
areusch
areusch
reviewed
May 18, 2022
View reviewed changes
@areuschareusch
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @driazati, added some comments
Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
@github-actions
github-actionsBot
requested a review
from MousiusMay 18, 2022 19:30
@areusch
areusch
commented
May 18, 2022

Copy link


Copy Markdown

Contributor
cool! i think this looks good to me, will let @Mousius have a look.
also cc @leandron
@driazati
driazati
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
just a note for reviewers: the code is 99% done but will take a couple more iterations through CI once it’s verified before it can be merged (ie right now it still has testing code specific to this PR)
Mousius
Mousius
requested changes
May 19, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this Jenkinsfile is getting fun 😸 Thanks for working through this @driazati, is it possible to document some of the flow here in terms of using ECR as an intermediary cache before Docker Hub? Not necessarily this PR but it'd be great to have as a reference
Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/scripts/cmd_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusMay 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is literally for testing, but I'll leave a comment just in case 😸

Suggested change

 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
 update_docker({{ image.name }}, "tlcpackstaging/{{ image.name }}:${tag}")
Comment threadjenkins/Jenkinsfile.j2
Outdated

@driazatidriazati
mentioned this pull request
May 19, 2022
 Closed

@driazatidriazati
changed the title
[ci] Rebuild Docker images if necessary[ci] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci] Add code to rebuild Docker images if necessary[ci][1/n] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci][1/n] Add code to rebuild Docker images if necessary[ci][1/n] Rebuild Docker images if necessaryMay 31, 2022
@driazati
driazati
commented
May 31, 2022

Copy link


Copy Markdown

MemberAuthor
@Mousius I've re-worked this PR a bit, I'm weary about landing it all at once since it can potentially have a big impact on CI times. In a follow up PR I'll enable the docker image rebuilds based on the Docker Hub hashes behind a flag in Jenkins so we can turn it off if we need to, but this one is ready to go now
@driazati
driazati
requested a review
from MousiusJune 1, 2022 14:59
@driazati
driazati
commented
Jun 3, 2022

Copy link


Copy Markdown

MemberAuthor
@tvm-bot rerun
Mousius
Mousius
approved these changes
Jun 6, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati I left a few questions but I'm ok with follow up in the next in the PR series. I also manually triggered CI to re-run as the bot didn't seem to be doing it?
Comment threadjenkins/Build.groovy.j2
Outdated

 timeout(time: max_time, unit: 'MINUTES') {
 try {
 cmake_build(docker_type, path, make_flag)
 // always run cpp test when build
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment has been sneaking around with this function but actually no longer relates to this function?
Comment threadjenkins/Deploy.groovy.j2
 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is just to avoid conflicts with the over night build?
@driazatidriazatiJun 7, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, in the follow up(s) we'll switch it over
@driazati
driazati
commented
Jun 7, 2022

Copy link


Copy Markdown

MemberAuthor
I also manually triggered CI to re-run as the bot didn't seem to be doing it?
the bot is broken but fixes are in flight, we're looking into better ways to test these kinds of things before deploying (e.g. the merge functionality also isn't working due to some auth errors I haven't been able to sort out yet)
@driazati
[ci] Rebuild Docker images if necessary
69363eb
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@Mousius
Mousius
merged commit 6d557ff
into
apache:mainJun 9, 2022
@Mousius
Mousius
commented
Jun 9, 2022

Copy link


Copy Markdown

Member
Nice work @driazati, looking forward to seeing this fully functional 😸
Kathryn-cat pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
@driazati@Kathryn-cat
[ci] Rebuild Docker images if necessary (apache#11329)
dd75257
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@driazatidriazati
mentioned this pull request
Jun 10, 2022
 Closed

@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@MousiusMousiusMousius approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@Mousius

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[ci][1/n] Rebuild Docker images if necessary by driazati · Pull Request #11329 · apache/tvm · GitHub
Skip to content
[ci][1/n] Rebuild Docker images if necessary - #11329
Merged
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Jun 9, 2022
Merged
[ci][1/n] Rebuild Docker images if necessary#11329
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Conversation
@driazati
@driazatidriazati
commented
May 16, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This sets us up to rebuild Docker images and uses them in later stages in the same build. This is not yet enabled (see the commented out code in DockerBuild.groovy.j2. If the build is running on main, then the images are uploaded to Docker Hub automatically once the run is complete. To avoid landing a complicated infra PR all at once this mostly adds the scaffolding and a follow up PR will: 1. upload images to tlcpack instead of tlcpackstaging 2. dynamically determine the docker image to use based on the latest hash 3. always rebuild docker images if an updated one hasn't been uploaded
cc @Mousius@areusch
@driazatidriazati
mentioned this pull request
May 17, 2022
 Open

@driazatidriazati
changed the title
[ci][wip] Rebuild Docker images if necessary[ci] Rebuild Docker images if necessaryMay 18, 2022
@driazati
driazati
marked this pull request as ready for review
May 18, 2022 18:01
areusch
areusch
reviewed
May 18, 2022
View reviewed changes
@areuschareusch
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @driazati, added some comments
Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
@github-actions
github-actionsBot
requested a review
from MousiusMay 18, 2022 19:30
@areusch
areusch
commented
May 18, 2022

Copy link


Copy Markdown

Contributor
cool! i think this looks good to me, will let @Mousius have a look.
also cc @leandron
@driazati
driazati
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
just a note for reviewers: the code is 99% done but will take a couple more iterations through CI once it’s verified before it can be merged (ie right now it still has testing code specific to this PR)
Mousius
Mousius
requested changes
May 19, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this Jenkinsfile is getting fun 😸 Thanks for working through this @driazati, is it possible to document some of the flow here in terms of using ECR as an intermediary cache before Docker Hub? Not necessarily this PR but it'd be great to have as a reference
Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/scripts/cmd_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusMay 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is literally for testing, but I'll leave a comment just in case 😸

Suggested change

 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
 update_docker({{ image.name }}, "tlcpackstaging/{{ image.name }}:${tag}")
Comment threadjenkins/Jenkinsfile.j2
Outdated

@driazatidriazati
mentioned this pull request
May 19, 2022
 Closed

@driazatidriazati
changed the title
[ci] Rebuild Docker images if necessary[ci] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci] Add code to rebuild Docker images if necessary[ci][1/n] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci][1/n] Add code to rebuild Docker images if necessary[ci][1/n] Rebuild Docker images if necessaryMay 31, 2022
@driazati
driazati
commented
May 31, 2022

Copy link


Copy Markdown

MemberAuthor
@Mousius I've re-worked this PR a bit, I'm weary about landing it all at once since it can potentially have a big impact on CI times. In a follow up PR I'll enable the docker image rebuilds based on the Docker Hub hashes behind a flag in Jenkins so we can turn it off if we need to, but this one is ready to go now
@driazati
driazati
requested a review
from MousiusJune 1, 2022 14:59
@driazati
driazati
commented
Jun 3, 2022

Copy link


Copy Markdown

MemberAuthor
@tvm-bot rerun
Mousius
Mousius
approved these changes
Jun 6, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati I left a few questions but I'm ok with follow up in the next in the PR series. I also manually triggered CI to re-run as the bot didn't seem to be doing it?
Comment threadjenkins/Build.groovy.j2
Outdated

 timeout(time: max_time, unit: 'MINUTES') {
 try {
 cmake_build(docker_type, path, make_flag)
 // always run cpp test when build
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment has been sneaking around with this function but actually no longer relates to this function?
Comment threadjenkins/Deploy.groovy.j2
 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is just to avoid conflicts with the over night build?
@driazatidriazatiJun 7, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, in the follow up(s) we'll switch it over
@driazati
driazati
commented
Jun 7, 2022

Copy link


Copy Markdown

MemberAuthor
I also manually triggered CI to re-run as the bot didn't seem to be doing it?
the bot is broken but fixes are in flight, we're looking into better ways to test these kinds of things before deploying (e.g. the merge functionality also isn't working due to some auth errors I haven't been able to sort out yet)
@driazati
[ci] Rebuild Docker images if necessary
69363eb
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@Mousius
Mousius
merged commit 6d557ff
into
apache:mainJun 9, 2022
@Mousius
Mousius
commented
Jun 9, 2022

Copy link


Copy Markdown

Member
Nice work @driazati, looking forward to seeing this fully functional 😸
Kathryn-cat pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
@driazati@Kathryn-cat
[ci] Rebuild Docker images if necessary (apache#11329)
dd75257
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@driazatidriazati
mentioned this pull request
Jun 10, 2022
 Closed

@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@MousiusMousiusMousius approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@Mousius

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[ci][1/n] Rebuild Docker images if necessary by driazati · Pull Request #11329 · apache/tvm · GitHub
Skip to content
[ci][1/n] Rebuild Docker images if necessary - #11329
Merged
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Jun 9, 2022
Merged
[ci][1/n] Rebuild Docker images if necessary#11329
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Conversation
@driazati
@driazatidriazati
commented
May 16, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This sets us up to rebuild Docker images and uses them in later stages in the same build. This is not yet enabled (see the commented out code in DockerBuild.groovy.j2. If the build is running on main, then the images are uploaded to Docker Hub automatically once the run is complete. To avoid landing a complicated infra PR all at once this mostly adds the scaffolding and a follow up PR will: 1. upload images to tlcpack instead of tlcpackstaging 2. dynamically determine the docker image to use based on the latest hash 3. always rebuild docker images if an updated one hasn't been uploaded
cc @Mousius@areusch
@driazatidriazati
mentioned this pull request
May 17, 2022
 Open

@driazatidriazati
changed the title
[ci][wip] Rebuild Docker images if necessary[ci] Rebuild Docker images if necessaryMay 18, 2022
@driazati
driazati
marked this pull request as ready for review
May 18, 2022 18:01
areusch
areusch
reviewed
May 18, 2022
View reviewed changes
@areuschareusch
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @driazati, added some comments
Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
@github-actions
github-actionsBot
requested a review
from MousiusMay 18, 2022 19:30
@areusch
areusch
commented
May 18, 2022

Copy link


Copy Markdown

Contributor
cool! i think this looks good to me, will let @Mousius have a look.
also cc @leandron
@driazati
driazati
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
just a note for reviewers: the code is 99% done but will take a couple more iterations through CI once it’s verified before it can be merged (ie right now it still has testing code specific to this PR)
Mousius
Mousius
requested changes
May 19, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this Jenkinsfile is getting fun 😸 Thanks for working through this @driazati, is it possible to document some of the flow here in terms of using ECR as an intermediary cache before Docker Hub? Not necessarily this PR but it'd be great to have as a reference
Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/scripts/cmd_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusMay 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is literally for testing, but I'll leave a comment just in case 😸

Suggested change

 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
 update_docker({{ image.name }}, "tlcpackstaging/{{ image.name }}:${tag}")
Comment threadjenkins/Jenkinsfile.j2
Outdated

@driazatidriazati
mentioned this pull request
May 19, 2022
 Closed

@driazatidriazati
changed the title
[ci] Rebuild Docker images if necessary[ci] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci] Add code to rebuild Docker images if necessary[ci][1/n] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci][1/n] Add code to rebuild Docker images if necessary[ci][1/n] Rebuild Docker images if necessaryMay 31, 2022
@driazati
driazati
commented
May 31, 2022

Copy link


Copy Markdown

MemberAuthor
@Mousius I've re-worked this PR a bit, I'm weary about landing it all at once since it can potentially have a big impact on CI times. In a follow up PR I'll enable the docker image rebuilds based on the Docker Hub hashes behind a flag in Jenkins so we can turn it off if we need to, but this one is ready to go now
@driazati
driazati
requested a review
from MousiusJune 1, 2022 14:59
@driazati
driazati
commented
Jun 3, 2022

Copy link


Copy Markdown

MemberAuthor
@tvm-bot rerun
Mousius
Mousius
approved these changes
Jun 6, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati I left a few questions but I'm ok with follow up in the next in the PR series. I also manually triggered CI to re-run as the bot didn't seem to be doing it?
Comment threadjenkins/Build.groovy.j2
Outdated

 timeout(time: max_time, unit: 'MINUTES') {
 try {
 cmake_build(docker_type, path, make_flag)
 // always run cpp test when build
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment has been sneaking around with this function but actually no longer relates to this function?
Comment threadjenkins/Deploy.groovy.j2
 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is just to avoid conflicts with the over night build?
@driazatidriazatiJun 7, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, in the follow up(s) we'll switch it over
@driazati
driazati
commented
Jun 7, 2022

Copy link


Copy Markdown

MemberAuthor
I also manually triggered CI to re-run as the bot didn't seem to be doing it?
the bot is broken but fixes are in flight, we're looking into better ways to test these kinds of things before deploying (e.g. the merge functionality also isn't working due to some auth errors I haven't been able to sort out yet)
@driazati
[ci] Rebuild Docker images if necessary
69363eb
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@Mousius
Mousius
merged commit 6d557ff
into
apache:mainJun 9, 2022
@Mousius
Mousius
commented
Jun 9, 2022

Copy link


Copy Markdown

Member
Nice work @driazati, looking forward to seeing this fully functional 😸
Kathryn-cat pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
@driazati@Kathryn-cat
[ci] Rebuild Docker images if necessary (apache#11329)
dd75257
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@driazatidriazati
mentioned this pull request
Jun 10, 2022
 Closed

@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@MousiusMousiusMousius approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@Mousius

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[ci][1/n] Rebuild Docker images if necessary by driazati · Pull Request #11329 · apache/tvm · GitHub
Skip to content
[ci][1/n] Rebuild Docker images if necessary - #11329
Merged
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Jun 9, 2022
Merged
[ci][1/n] Rebuild Docker images if necessary#11329
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Conversation
@driazati
@driazatidriazati
commented
May 16, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This sets us up to rebuild Docker images and uses them in later stages in the same build. This is not yet enabled (see the commented out code in DockerBuild.groovy.j2. If the build is running on main, then the images are uploaded to Docker Hub automatically once the run is complete. To avoid landing a complicated infra PR all at once this mostly adds the scaffolding and a follow up PR will: 1. upload images to tlcpack instead of tlcpackstaging 2. dynamically determine the docker image to use based on the latest hash 3. always rebuild docker images if an updated one hasn't been uploaded
cc @Mousius@areusch
@driazatidriazati
mentioned this pull request
May 17, 2022
 Open

@driazatidriazati
changed the title
[ci][wip] Rebuild Docker images if necessary[ci] Rebuild Docker images if necessaryMay 18, 2022
@driazati
driazati
marked this pull request as ready for review
May 18, 2022 18:01
areusch
areusch
reviewed
May 18, 2022
View reviewed changes
@areuschareusch
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @driazati, added some comments
Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
@github-actions
github-actionsBot
requested a review
from MousiusMay 18, 2022 19:30
@areusch
areusch
commented
May 18, 2022

Copy link


Copy Markdown

Contributor
cool! i think this looks good to me, will let @Mousius have a look.
also cc @leandron
@driazati
driazati
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
just a note for reviewers: the code is 99% done but will take a couple more iterations through CI once it’s verified before it can be merged (ie right now it still has testing code specific to this PR)
Mousius
Mousius
requested changes
May 19, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this Jenkinsfile is getting fun 😸 Thanks for working through this @driazati, is it possible to document some of the flow here in terms of using ECR as an intermediary cache before Docker Hub? Not necessarily this PR but it'd be great to have as a reference
Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/scripts/cmd_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusMay 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is literally for testing, but I'll leave a comment just in case 😸

Suggested change

 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
 update_docker({{ image.name }}, "tlcpackstaging/{{ image.name }}:${tag}")
Comment threadjenkins/Jenkinsfile.j2
Outdated

@driazatidriazati
mentioned this pull request
May 19, 2022
 Closed

@driazatidriazati
changed the title
[ci] Rebuild Docker images if necessary[ci] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci] Add code to rebuild Docker images if necessary[ci][1/n] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci][1/n] Add code to rebuild Docker images if necessary[ci][1/n] Rebuild Docker images if necessaryMay 31, 2022
@driazati
driazati
commented
May 31, 2022

Copy link


Copy Markdown

MemberAuthor
@Mousius I've re-worked this PR a bit, I'm weary about landing it all at once since it can potentially have a big impact on CI times. In a follow up PR I'll enable the docker image rebuilds based on the Docker Hub hashes behind a flag in Jenkins so we can turn it off if we need to, but this one is ready to go now
@driazati
driazati
requested a review
from MousiusJune 1, 2022 14:59
@driazati
driazati
commented
Jun 3, 2022

Copy link


Copy Markdown

MemberAuthor
@tvm-bot rerun
Mousius
Mousius
approved these changes
Jun 6, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati I left a few questions but I'm ok with follow up in the next in the PR series. I also manually triggered CI to re-run as the bot didn't seem to be doing it?
Comment threadjenkins/Build.groovy.j2
Outdated

 timeout(time: max_time, unit: 'MINUTES') {
 try {
 cmake_build(docker_type, path, make_flag)
 // always run cpp test when build
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment has been sneaking around with this function but actually no longer relates to this function?
Comment threadjenkins/Deploy.groovy.j2
 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is just to avoid conflicts with the over night build?
@driazatidriazatiJun 7, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, in the follow up(s) we'll switch it over
@driazati
driazati
commented
Jun 7, 2022

Copy link


Copy Markdown

MemberAuthor
I also manually triggered CI to re-run as the bot didn't seem to be doing it?
the bot is broken but fixes are in flight, we're looking into better ways to test these kinds of things before deploying (e.g. the merge functionality also isn't working due to some auth errors I haven't been able to sort out yet)
@driazati
[ci] Rebuild Docker images if necessary
69363eb
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@Mousius
Mousius
merged commit 6d557ff
into
apache:mainJun 9, 2022
@Mousius
Mousius
commented
Jun 9, 2022

Copy link


Copy Markdown

Member
Nice work @driazati, looking forward to seeing this fully functional 😸
Kathryn-cat pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
@driazati@Kathryn-cat
[ci] Rebuild Docker images if necessary (apache#11329)
dd75257
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@driazatidriazati
mentioned this pull request
Jun 10, 2022
 Closed

@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@MousiusMousiusMousius approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@Mousius

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[ci][1/n] Rebuild Docker images if necessary by driazati · Pull Request #11329 · apache/tvm · GitHub
Skip to content
[ci][1/n] Rebuild Docker images if necessary - #11329
Merged
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Jun 9, 2022
Merged
[ci][1/n] Rebuild Docker images if necessary#11329
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Conversation
@driazati
@driazatidriazati
commented
May 16, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This sets us up to rebuild Docker images and uses them in later stages in the same build. This is not yet enabled (see the commented out code in DockerBuild.groovy.j2. If the build is running on main, then the images are uploaded to Docker Hub automatically once the run is complete. To avoid landing a complicated infra PR all at once this mostly adds the scaffolding and a follow up PR will: 1. upload images to tlcpack instead of tlcpackstaging 2. dynamically determine the docker image to use based on the latest hash 3. always rebuild docker images if an updated one hasn't been uploaded
cc @Mousius@areusch
@driazatidriazati
mentioned this pull request
May 17, 2022
 Open

@driazatidriazati
changed the title
[ci][wip] Rebuild Docker images if necessary[ci] Rebuild Docker images if necessaryMay 18, 2022
@driazati
driazati
marked this pull request as ready for review
May 18, 2022 18:01
areusch
areusch
reviewed
May 18, 2022
View reviewed changes
@areuschareusch
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @driazati, added some comments
Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
@github-actions
github-actionsBot
requested a review
from MousiusMay 18, 2022 19:30
@areusch
areusch
commented
May 18, 2022

Copy link


Copy Markdown

Contributor
cool! i think this looks good to me, will let @Mousius have a look.
also cc @leandron
@driazati
driazati
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
just a note for reviewers: the code is 99% done but will take a couple more iterations through CI once it’s verified before it can be merged (ie right now it still has testing code specific to this PR)
Mousius
Mousius
requested changes
May 19, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this Jenkinsfile is getting fun 😸 Thanks for working through this @driazati, is it possible to document some of the flow here in terms of using ECR as an intermediary cache before Docker Hub? Not necessarily this PR but it'd be great to have as a reference
Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/scripts/cmd_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusMay 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is literally for testing, but I'll leave a comment just in case 😸

Suggested change

 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
 update_docker({{ image.name }}, "tlcpackstaging/{{ image.name }}:${tag}")
Comment threadjenkins/Jenkinsfile.j2
Outdated

@driazatidriazati
mentioned this pull request
May 19, 2022
 Closed

@driazatidriazati
changed the title
[ci] Rebuild Docker images if necessary[ci] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci] Add code to rebuild Docker images if necessary[ci][1/n] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci][1/n] Add code to rebuild Docker images if necessary[ci][1/n] Rebuild Docker images if necessaryMay 31, 2022
@driazati
driazati
commented
May 31, 2022

Copy link


Copy Markdown

MemberAuthor
@Mousius I've re-worked this PR a bit, I'm weary about landing it all at once since it can potentially have a big impact on CI times. In a follow up PR I'll enable the docker image rebuilds based on the Docker Hub hashes behind a flag in Jenkins so we can turn it off if we need to, but this one is ready to go now
@driazati
driazati
requested a review
from MousiusJune 1, 2022 14:59
@driazati
driazati
commented
Jun 3, 2022

Copy link


Copy Markdown

MemberAuthor
@tvm-bot rerun
Mousius
Mousius
approved these changes
Jun 6, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati I left a few questions but I'm ok with follow up in the next in the PR series. I also manually triggered CI to re-run as the bot didn't seem to be doing it?
Comment threadjenkins/Build.groovy.j2
Outdated

 timeout(time: max_time, unit: 'MINUTES') {
 try {
 cmake_build(docker_type, path, make_flag)
 // always run cpp test when build
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment has been sneaking around with this function but actually no longer relates to this function?
Comment threadjenkins/Deploy.groovy.j2
 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is just to avoid conflicts with the over night build?
@driazatidriazatiJun 7, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, in the follow up(s) we'll switch it over
@driazati
driazati
commented
Jun 7, 2022

Copy link


Copy Markdown

MemberAuthor
I also manually triggered CI to re-run as the bot didn't seem to be doing it?
the bot is broken but fixes are in flight, we're looking into better ways to test these kinds of things before deploying (e.g. the merge functionality also isn't working due to some auth errors I haven't been able to sort out yet)
@driazati
[ci] Rebuild Docker images if necessary
69363eb
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@Mousius
Mousius
merged commit 6d557ff
into
apache:mainJun 9, 2022
@Mousius
Mousius
commented
Jun 9, 2022

Copy link


Copy Markdown

Member
Nice work @driazati, looking forward to seeing this fully functional 😸
Kathryn-cat pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
@driazati@Kathryn-cat
[ci] Rebuild Docker images if necessary (apache#11329)
dd75257
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@driazatidriazati
mentioned this pull request
Jun 10, 2022
 Closed

@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@MousiusMousiusMousius approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@Mousius

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[ci][1/n] Rebuild Docker images if necessary by driazati · Pull Request #11329 · apache/tvm · GitHub
Skip to content
[ci][1/n] Rebuild Docker images if necessary - #11329
Merged
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Jun 9, 2022
Merged
[ci][1/n] Rebuild Docker images if necessary#11329
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Conversation
@driazati
@driazatidriazati
commented
May 16, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This sets us up to rebuild Docker images and uses them in later stages in the same build. This is not yet enabled (see the commented out code in DockerBuild.groovy.j2. If the build is running on main, then the images are uploaded to Docker Hub automatically once the run is complete. To avoid landing a complicated infra PR all at once this mostly adds the scaffolding and a follow up PR will: 1. upload images to tlcpack instead of tlcpackstaging 2. dynamically determine the docker image to use based on the latest hash 3. always rebuild docker images if an updated one hasn't been uploaded
cc @Mousius@areusch
@driazatidriazati
mentioned this pull request
May 17, 2022
 Open

@driazatidriazati
changed the title
[ci][wip] Rebuild Docker images if necessary[ci] Rebuild Docker images if necessaryMay 18, 2022
@driazati
driazati
marked this pull request as ready for review
May 18, 2022 18:01
areusch
areusch
reviewed
May 18, 2022
View reviewed changes
@areuschareusch
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @driazati, added some comments
Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
@github-actions
github-actionsBot
requested a review
from MousiusMay 18, 2022 19:30
@areusch
areusch
commented
May 18, 2022

Copy link


Copy Markdown

Contributor
cool! i think this looks good to me, will let @Mousius have a look.
also cc @leandron
@driazati
driazati
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
just a note for reviewers: the code is 99% done but will take a couple more iterations through CI once it’s verified before it can be merged (ie right now it still has testing code specific to this PR)
Mousius
Mousius
requested changes
May 19, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this Jenkinsfile is getting fun 😸 Thanks for working through this @driazati, is it possible to document some of the flow here in terms of using ECR as an intermediary cache before Docker Hub? Not necessarily this PR but it'd be great to have as a reference
Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/scripts/cmd_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusMay 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is literally for testing, but I'll leave a comment just in case 😸

Suggested change

 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
 update_docker({{ image.name }}, "tlcpackstaging/{{ image.name }}:${tag}")
Comment threadjenkins/Jenkinsfile.j2
Outdated

@driazatidriazati
mentioned this pull request
May 19, 2022
 Closed

@driazatidriazati
changed the title
[ci] Rebuild Docker images if necessary[ci] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci] Add code to rebuild Docker images if necessary[ci][1/n] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci][1/n] Add code to rebuild Docker images if necessary[ci][1/n] Rebuild Docker images if necessaryMay 31, 2022
@driazati
driazati
commented
May 31, 2022

Copy link


Copy Markdown

MemberAuthor
@Mousius I've re-worked this PR a bit, I'm weary about landing it all at once since it can potentially have a big impact on CI times. In a follow up PR I'll enable the docker image rebuilds based on the Docker Hub hashes behind a flag in Jenkins so we can turn it off if we need to, but this one is ready to go now
@driazati
driazati
requested a review
from MousiusJune 1, 2022 14:59
@driazati
driazati
commented
Jun 3, 2022

Copy link


Copy Markdown

MemberAuthor
@tvm-bot rerun
Mousius
Mousius
approved these changes
Jun 6, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati I left a few questions but I'm ok with follow up in the next in the PR series. I also manually triggered CI to re-run as the bot didn't seem to be doing it?
Comment threadjenkins/Build.groovy.j2
Outdated

 timeout(time: max_time, unit: 'MINUTES') {
 try {
 cmake_build(docker_type, path, make_flag)
 // always run cpp test when build
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment has been sneaking around with this function but actually no longer relates to this function?
Comment threadjenkins/Deploy.groovy.j2
 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is just to avoid conflicts with the over night build?
@driazatidriazatiJun 7, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, in the follow up(s) we'll switch it over
@driazati
driazati
commented
Jun 7, 2022

Copy link


Copy Markdown

MemberAuthor
I also manually triggered CI to re-run as the bot didn't seem to be doing it?
the bot is broken but fixes are in flight, we're looking into better ways to test these kinds of things before deploying (e.g. the merge functionality also isn't working due to some auth errors I haven't been able to sort out yet)
@driazati
[ci] Rebuild Docker images if necessary
69363eb
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@Mousius
Mousius
merged commit 6d557ff
into
apache:mainJun 9, 2022
@Mousius
Mousius
commented
Jun 9, 2022

Copy link


Copy Markdown

Member
Nice work @driazati, looking forward to seeing this fully functional 😸
Kathryn-cat pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
@driazati@Kathryn-cat
[ci] Rebuild Docker images if necessary (apache#11329)
dd75257
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@driazatidriazati
mentioned this pull request
Jun 10, 2022
 Closed

@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@MousiusMousiusMousius approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@Mousius

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[ci][1/n] Rebuild Docker images if necessary by driazati · Pull Request #11329 · apache/tvm · GitHub
Skip to content
[ci][1/n] Rebuild Docker images if necessary - #11329
Merged
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Jun 9, 2022
Merged
[ci][1/n] Rebuild Docker images if necessary#11329
Mousius merged 1 commit into
apache:mainfrom 
driazati:rebuild_images2
Conversation
@driazati
@driazatidriazati
commented
May 16, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This sets us up to rebuild Docker images and uses them in later stages in the same build. This is not yet enabled (see the commented out code in DockerBuild.groovy.j2. If the build is running on main, then the images are uploaded to Docker Hub automatically once the run is complete. To avoid landing a complicated infra PR all at once this mostly adds the scaffolding and a follow up PR will: 1. upload images to tlcpack instead of tlcpackstaging 2. dynamically determine the docker image to use based on the latest hash 3. always rebuild docker images if an updated one hasn't been uploaded
cc @Mousius@areusch
@driazatidriazati
mentioned this pull request
May 17, 2022
 Open

@driazatidriazati
changed the title
[ci][wip] Rebuild Docker images if necessary[ci] Rebuild Docker images if necessaryMay 18, 2022
@driazati
driazati
marked this pull request as ready for review
May 18, 2022 18:01
areusch
areusch
reviewed
May 18, 2022
View reviewed changes
@areuschareusch
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @driazati, added some comments
Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
Outdated

Comment threadtests/scripts/should_rebuild_docker.py
@github-actions
github-actionsBot
requested a review
from MousiusMay 18, 2022 19:30
@areusch
areusch
commented
May 18, 2022

Copy link


Copy Markdown

Contributor
cool! i think this looks good to me, will let @Mousius have a look.
also cc @leandron
@driazati
driazati
commented
May 19, 2022

Copy link


Copy Markdown

MemberAuthor
just a note for reviewers: the code is 99% done but will take a couple more iterations through CI once it’s verified before it can be merged (ie right now it still has testing code specific to this PR)
Mousius
Mousius
requested changes
May 19, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, this Jenkinsfile is getting fun 😸 Thanks for working through this @driazati, is it possible to document some of the flow here in terms of using ECR as an intermediary cache before Docker Hub? Not necessarily this PR but it'd be great to have as a reference
Comment threadtests/scripts/git_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadtests/scripts/cmd_utils.py
Outdated

Comment threadtests/python/ci/test_ci.py
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

Comment threadjenkins/Jenkinsfile.j2
Outdated

 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusMay 19, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is literally for testing, but I'll leave a comment just in case 😸

Suggested change

 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
 update_docker({{ image.name }}, "tlcpackstaging/{{ image.name }}:${tag}")
Comment threadjenkins/Jenkinsfile.j2
Outdated

@driazatidriazati
mentioned this pull request
May 19, 2022
 Closed

@driazatidriazati
changed the title
[ci] Rebuild Docker images if necessary[ci] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci] Add code to rebuild Docker images if necessary[ci][1/n] Add code to rebuild Docker images if necessaryMay 31, 2022
@driazatidriazati
changed the title
[ci][1/n] Add code to rebuild Docker images if necessary[ci][1/n] Rebuild Docker images if necessaryMay 31, 2022
@driazati
driazati
commented
May 31, 2022

Copy link


Copy Markdown

MemberAuthor
@Mousius I've re-worked this PR a bit, I'm weary about landing it all at once since it can potentially have a big impact on CI times. In a follow up PR I'll enable the docker image rebuilds based on the Docker Hub hashes behind a flag in Jenkins so we can turn it off if we need to, but this one is ready to go now
@driazati
driazati
requested a review
from MousiusJune 1, 2022 14:59
@driazati
driazati
commented
Jun 3, 2022

Copy link


Copy Markdown

MemberAuthor
@tvm-bot rerun
Mousius
Mousius
approved these changes
Jun 6, 2022
View reviewed changes
@MousiusMousius
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driazati I left a few questions but I'm ok with follow up in the next in the PR series. I also manually triggered CI to re-run as the bot didn't seem to be doing it?
Comment threadjenkins/Build.groovy.j2
Outdated

 timeout(time: max_time, unit: 'MINUTES') {
 try {
 cmake_build(docker_type, path, make_flag)
 // always run cpp test when build
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment has been sneaking around with this function but actually no longer relates to this function?
Comment threadjenkins/Deploy.groovy.j2
 ).trim()
 def tag = "${date_Ymd_HMS}-${upstream_revision.substring(0, 8)}"
 {% for image in images %}
 update_docker({{ image.name }}, "tlcpackstaging/test_{{ image.name }}:${tag}")
@MousiusMousiusJun 6, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is just to avoid conflicts with the over night build?
@driazatidriazatiJun 7, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, in the follow up(s) we'll switch it over
@driazati
driazati
commented
Jun 7, 2022

Copy link


Copy Markdown

MemberAuthor
I also manually triggered CI to re-run as the bot didn't seem to be doing it?
the bot is broken but fixes are in flight, we're looking into better ways to test these kinds of things before deploying (e.g. the merge functionality also isn't working due to some auth errors I haven't been able to sort out yet)
@driazati
[ci] Rebuild Docker images if necessary
69363eb
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@Mousius
Mousius
merged commit 6d557ff
into
apache:mainJun 9, 2022
@Mousius
Mousius
commented
Jun 9, 2022

Copy link


Copy Markdown

Member
Nice work @driazati, looking forward to seeing this fully functional 😸
Kathryn-cat pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
@driazati@Kathryn-cat
[ci] Rebuild Docker images if necessary (apache#11329)
dd75257
This rebuilds Docker images and uses them in later stages in the same build. If the build is running on `main`, then the images are uploaded to Docker Hub automatically once the run is complete. Images are always rebuilt, but Docker Hub functions as a cache. If there have been no changes to `docker/` since the last available hash on Docker Hub, then the build will just use the images from Hub.
@driazatidriazati
mentioned this pull request
Jun 10, 2022
 Closed

@driazatidriazati
mentioned this pull request
Jul 14, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@MousiusMousiusMousius approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@Mousius