') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [Bugfix][TIR] Removed passing of IterMapExpr into PrettyPrint by Lunderberg · Pull Request #11412 · apache/tvm · GitHub
Skip to content

[Bugfix][TIR] Removed passing of IterMapExpr into PrettyPrint - #11412

Merged
junrushao merged 1 commit into
apache:mainfrom
Lunderberg:no_pretty_print_itermapexpr
May 23, 2022
Merged

[Bugfix][TIR] Removed passing of IterMapExpr into PrettyPrint#11412
junrushao merged 1 commit into
apache:mainfrom
Lunderberg:no_pretty_print_itermapexpr

Conversation

@Lunderberg

@LunderbergLunderberg commented May 23, 2022

Copy link
Copy Markdown
Contributor

Follow-up from #11235, all error messages should be based on expressions that are not IterMapExpr.

cc @vinx13

@Lunderberg
[Bugfix][TIR] Removed passing of IterMapExpr into PrettyPrint
0980101
Follow-up from apache#11235, all error
messages should be based on expressions that are not IterMapExpr.
@github-actions
github-actionsBot requested a review from vinx13May 23, 2022 17:41
@junrushao

junrushao commented May 23, 2022

Copy link
Copy Markdown
Member

Shall we have a regression test over this? Thanks a lot!

@junrushao

junrushao commented May 23, 2022

Copy link
Copy Markdown
Member

Maybe not. It's more related to error reporting

@junrushao
junrushao merged commit 5655fa8 into apache:mainMay 23, 2022
@Lunderberg
Lunderberg deleted the no_pretty_print_itermapexpr branch May 23, 2022 20:50
@Lunderberg

Lunderberg commented May 23, 2022

Copy link
Copy Markdown
ContributorAuthor

Unfortunately, it does cause issues beyond error reporting. By attempting to print an unsupported type, this bug called LOG(FATAL) instead of recording the context for later checks. Some paths do turn these into errors (e.g. through IndexMap), but others do not (e.g. through tvm::arith::EstimateRegionLowerBound which @vinx13 ran into earlier today).

Which is all to say that I've made a regression test, and am going to open a PR to add it.

Lunderberg added a commit to Lunderberg/tvm that referenced this pull request May 23, 2022
@Lunderberg
[TIR] Regression test for PrettyPrint/IterMapExpr bugfix
f3f97c2
Follow-up from apache#11412, adding a
regression test for the bugfix.
@LunderbergLunderberg mentioned this pull request May 23, 2022
Merged
junrushao pushed a commit that referenced this pull request May 24, 2022
@Lunderberg
[TIR] Regression test for PrettyPrint/IterMapExpr bugfix (#11418)
f3d8ba4
Follow-up from #11412, adding a
regression test for the bugfix.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinx13vinx13vinx13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lunderberg@junrushao@vinx13