[TE] Support schedulable TIR compute definitions in TOPI by csullivan · Pull Request #11589 · apache/tvm

csullivan · 2022-06-06T05:55:52Z

This PR adds te.extern_primfunc which provides the interface around TE ExternOp that allows a TVMScript defined schedulable TIR PrimFunc to be inlined into a TE compute graph. The result is that TIR can be used for compute definitions in Relay OpStrategies and, paired with meta-scheduler support in relay as introduced in #10578, these compute definitions can be scheduled and tuned as demonstrated in the attached tests.

Prior to this, compute definitions were limited to those definable in TE only. As a consequence of this patch and ongoing improvements to TVMScript meta-programming (#11097), TOPI can be extended to include compute and scheduling functions targeting schedulable TIR uniformly.

for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

user defined buffers expressed in te.extern ops.

TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

masahi · 2022-06-06T19:57:38Z

cc @Hzfengsy

Hzfengsy

Overall LGTM. Thanks @csullivan for such great contribution!!!

csullivan

Many thanks @Hzfengsy! PTAL again if/when you have the cycles.

Hzfengsy · 2022-06-09T06:22:10Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:43Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:54Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:23:05Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

junrushao · 2022-06-09T07:32:28Z

@Hzfengsy for context, as a rule of thumb, usually we don't use "requested changes" if the comment is not emotional :-) in our case, it's just some syntactic nitpicking, so let's just use "comment" as review type

Hzfengsy · 2022-06-10T01:55:41Z

Thanks for the reminder of @junrushao1994. And I'm sorry for bringing ambiguity to @csullivan. I will change the Changes requested into Approve and we can merge it if we want.

csullivan · 2022-06-13T15:41:20Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

Hzfengsy · 2022-06-13T15:48:44Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

T.serial is good too! Just make it in one line, e.g. for i in T.serial(0, 16): :)

csullivan · 2022-06-06T05:55:52Z

This PR adds te.extern_primfunc which provides the interface around TE ExternOp that allows a TVMScript defined schedulable TIR PrimFunc to be inlined into a TE compute graph. The result is that TIR can be used for compute definitions in Relay OpStrategies and, paired with meta-scheduler support in relay as introduced in #10578, these compute definitions can be scheduled and tuned as demonstrated in the attached tests.

Prior to this, compute definitions were limited to those definable in TE only. As a consequence of this patch and ongoing improvements to TVMScript meta-programming (#11097), TOPI can be extended to include compute and scheduling functions targeting schedulable TIR uniformly.

for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

user defined buffers expressed in te.extern ops.

TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

masahi · 2022-06-06T19:57:38Z

cc @Hzfengsy

Hzfengsy

Overall LGTM. Thanks @csullivan for such great contribution!!!

csullivan

Many thanks @Hzfengsy! PTAL again if/when you have the cycles.

Hzfengsy · 2022-06-09T06:22:10Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:43Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:54Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:23:05Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

junrushao · 2022-06-09T07:32:28Z

@Hzfengsy for context, as a rule of thumb, usually we don't use "requested changes" if the comment is not emotional :-) in our case, it's just some syntactic nitpicking, so let's just use "comment" as review type

Hzfengsy · 2022-06-10T01:55:41Z

Thanks for the reminder of @junrushao1994. And I'm sorry for bringing ambiguity to @csullivan. I will change the Changes requested into Approve and we can merge it if we want.

csullivan · 2022-06-13T15:41:20Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

Hzfengsy · 2022-06-13T15:48:44Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

T.serial is good too! Just make it in one line, e.g. for i in T.serial(0, 16): :)

csullivan · 2022-06-06T05:55:52Z

This PR adds te.extern_primfunc which provides the interface around TE ExternOp that allows a TVMScript defined schedulable TIR PrimFunc to be inlined into a TE compute graph. The result is that TIR can be used for compute definitions in Relay OpStrategies and, paired with meta-scheduler support in relay as introduced in #10578, these compute definitions can be scheduled and tuned as demonstrated in the attached tests.

Prior to this, compute definitions were limited to those definable in TE only. As a consequence of this patch and ongoing improvements to TVMScript meta-programming (#11097), TOPI can be extended to include compute and scheduling functions targeting schedulable TIR uniformly.

for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

user defined buffers expressed in te.extern ops.

TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

masahi · 2022-06-06T19:57:38Z

cc @Hzfengsy

Hzfengsy

Overall LGTM. Thanks @csullivan for such great contribution!!!

csullivan

Many thanks @Hzfengsy! PTAL again if/when you have the cycles.

Hzfengsy · 2022-06-09T06:22:10Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:43Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:54Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:23:05Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

junrushao · 2022-06-09T07:32:28Z

@Hzfengsy for context, as a rule of thumb, usually we don't use "requested changes" if the comment is not emotional :-) in our case, it's just some syntactic nitpicking, so let's just use "comment" as review type

Hzfengsy · 2022-06-10T01:55:41Z

Thanks for the reminder of @junrushao1994. And I'm sorry for bringing ambiguity to @csullivan. I will change the Changes requested into Approve and we can merge it if we want.

csullivan · 2022-06-13T15:41:20Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

Hzfengsy · 2022-06-13T15:48:44Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

T.serial is good too! Just make it in one line, e.g. for i in T.serial(0, 16): :)

csullivan · 2022-06-06T05:55:52Z

This PR adds te.extern_primfunc which provides the interface around TE ExternOp that allows a TVMScript defined schedulable TIR PrimFunc to be inlined into a TE compute graph. The result is that TIR can be used for compute definitions in Relay OpStrategies and, paired with meta-scheduler support in relay as introduced in #10578, these compute definitions can be scheduled and tuned as demonstrated in the attached tests.

Prior to this, compute definitions were limited to those definable in TE only. As a consequence of this patch and ongoing improvements to TVMScript meta-programming (#11097), TOPI can be extended to include compute and scheduling functions targeting schedulable TIR uniformly.

for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

user defined buffers expressed in te.extern ops.

TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

masahi · 2022-06-06T19:57:38Z

cc @Hzfengsy

Hzfengsy

Overall LGTM. Thanks @csullivan for such great contribution!!!

csullivan

Many thanks @Hzfengsy! PTAL again if/when you have the cycles.

Hzfengsy · 2022-06-09T06:22:10Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:43Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:54Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:23:05Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

junrushao · 2022-06-09T07:32:28Z

@Hzfengsy for context, as a rule of thumb, usually we don't use "requested changes" if the comment is not emotional :-) in our case, it's just some syntactic nitpicking, so let's just use "comment" as review type

Hzfengsy · 2022-06-10T01:55:41Z

Thanks for the reminder of @junrushao1994. And I'm sorry for bringing ambiguity to @csullivan. I will change the Changes requested into Approve and we can merge it if we want.

csullivan · 2022-06-13T15:41:20Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

Hzfengsy · 2022-06-13T15:48:44Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

T.serial is good too! Just make it in one line, e.g. for i in T.serial(0, 16): :)

csullivan · 2022-06-06T05:55:52Z

This PR adds te.extern_primfunc which provides the interface around TE ExternOp that allows a TVMScript defined schedulable TIR PrimFunc to be inlined into a TE compute graph. The result is that TIR can be used for compute definitions in Relay OpStrategies and, paired with meta-scheduler support in relay as introduced in #10578, these compute definitions can be scheduled and tuned as demonstrated in the attached tests.

Prior to this, compute definitions were limited to those definable in TE only. As a consequence of this patch and ongoing improvements to TVMScript meta-programming (#11097), TOPI can be extended to include compute and scheduling functions targeting schedulable TIR uniformly.

for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

user defined buffers expressed in te.extern ops.

TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

masahi · 2022-06-06T19:57:38Z

cc @Hzfengsy

Hzfengsy

Overall LGTM. Thanks @csullivan for such great contribution!!!

csullivan

Many thanks @Hzfengsy! PTAL again if/when you have the cycles.

Hzfengsy · 2022-06-09T06:22:10Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:43Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:54Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:23:05Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

junrushao · 2022-06-09T07:32:28Z

@Hzfengsy for context, as a rule of thumb, usually we don't use "requested changes" if the comment is not emotional :-) in our case, it's just some syntactic nitpicking, so let's just use "comment" as review type

Hzfengsy · 2022-06-10T01:55:41Z

Thanks for the reminder of @junrushao1994. And I'm sorry for bringing ambiguity to @csullivan. I will change the Changes requested into Approve and we can merge it if we want.

csullivan · 2022-06-13T15:41:20Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

Hzfengsy · 2022-06-13T15:48:44Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

T.serial is good too! Just make it in one line, e.g. for i in T.serial(0, 16): :)

csullivan · 2022-06-06T05:55:52Z

This PR adds te.extern_primfunc which provides the interface around TE ExternOp that allows a TVMScript defined schedulable TIR PrimFunc to be inlined into a TE compute graph. The result is that TIR can be used for compute definitions in Relay OpStrategies and, paired with meta-scheduler support in relay as introduced in #10578, these compute definitions can be scheduled and tuned as demonstrated in the attached tests.

Prior to this, compute definitions were limited to those definable in TE only. As a consequence of this patch and ongoing improvements to TVMScript meta-programming (#11097), TOPI can be extended to include compute and scheduling functions targeting schedulable TIR uniformly.

for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

user defined buffers expressed in te.extern ops.

TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

masahi · 2022-06-06T19:57:38Z

cc @Hzfengsy

Hzfengsy

Overall LGTM. Thanks @csullivan for such great contribution!!!

csullivan

Many thanks @Hzfengsy! PTAL again if/when you have the cycles.

Hzfengsy · 2022-06-09T06:22:10Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:43Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:54Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:23:05Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

junrushao · 2022-06-09T07:32:28Z

@Hzfengsy for context, as a rule of thumb, usually we don't use "requested changes" if the comment is not emotional :-) in our case, it's just some syntactic nitpicking, so let's just use "comment" as review type

Hzfengsy · 2022-06-10T01:55:41Z

Thanks for the reminder of @junrushao1994. And I'm sorry for bringing ambiguity to @csullivan. I will change the Changes requested into Approve and we can merge it if we want.

csullivan · 2022-06-13T15:41:20Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

Hzfengsy · 2022-06-13T15:48:44Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

T.serial is good too! Just make it in one line, e.g. for i in T.serial(0, 16): :)

csullivan · 2022-06-06T05:55:52Z

This PR adds te.extern_primfunc which provides the interface around TE ExternOp that allows a TVMScript defined schedulable TIR PrimFunc to be inlined into a TE compute graph. The result is that TIR can be used for compute definitions in Relay OpStrategies and, paired with meta-scheduler support in relay as introduced in #10578, these compute definitions can be scheduled and tuned as demonstrated in the attached tests.

Prior to this, compute definitions were limited to those definable in TE only. As a consequence of this patch and ongoing improvements to TVMScript meta-programming (#11097), TOPI can be extended to include compute and scheduling functions targeting schedulable TIR uniformly.

for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

user defined buffers expressed in te.extern ops.

TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

masahi · 2022-06-06T19:57:38Z

cc @Hzfengsy

Hzfengsy

Overall LGTM. Thanks @csullivan for such great contribution!!!

csullivan

Many thanks @Hzfengsy! PTAL again if/when you have the cycles.

Hzfengsy · 2022-06-09T06:22:10Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:43Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:54Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:23:05Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

junrushao · 2022-06-09T07:32:28Z

@Hzfengsy for context, as a rule of thumb, usually we don't use "requested changes" if the comment is not emotional :-) in our case, it's just some syntactic nitpicking, so let's just use "comment" as review type

Hzfengsy · 2022-06-10T01:55:41Z

Thanks for the reminder of @junrushao1994. And I'm sorry for bringing ambiguity to @csullivan. I will change the Changes requested into Approve and we can merge it if we want.

csullivan · 2022-06-13T15:41:20Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

Hzfengsy · 2022-06-13T15:48:44Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

T.serial is good too! Just make it in one line, e.g. for i in T.serial(0, 16): :)

csullivan · 2022-06-06T05:55:52Z

This PR adds te.extern_primfunc which provides the interface around TE ExternOp that allows a TVMScript defined schedulable TIR PrimFunc to be inlined into a TE compute graph. The result is that TIR can be used for compute definitions in Relay OpStrategies and, paired with meta-scheduler support in relay as introduced in #10578, these compute definitions can be scheduled and tuned as demonstrated in the attached tests.

Prior to this, compute definitions were limited to those definable in TE only. As a consequence of this patch and ongoing improvements to TVMScript meta-programming (#11097), TOPI can be extended to include compute and scheduling functions targeting schedulable TIR uniformly.

for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

user defined buffers expressed in te.extern ops.

TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

masahi · 2022-06-06T19:57:38Z

cc @Hzfengsy

Hzfengsy

Overall LGTM. Thanks @csullivan for such great contribution!!!

csullivan

Many thanks @Hzfengsy! PTAL again if/when you have the cycles.

Hzfengsy · 2022-06-09T06:22:10Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:43Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:22:54Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

Hzfengsy · 2022-06-09T06:23:05Z

+ for i in T.serial(
+ 0,
+ 16,
+ ):


Suggested change
foriinT.serial(
0,
16,
):
foriinrange(16):

junrushao · 2022-06-09T07:32:28Z

@Hzfengsy for context, as a rule of thumb, usually we don't use "requested changes" if the comment is not emotional :-) in our case, it's just some syntactic nitpicking, so let's just use "comment" as review type

Hzfengsy · 2022-06-10T01:55:41Z

Thanks for the reminder of @junrushao1994. And I'm sorry for bringing ambiguity to @csullivan. I will change the Changes requested into Approve and we can merge it if we want.

csullivan · 2022-06-13T15:41:20Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

Hzfengsy · 2022-06-13T15:48:44Z

Thanks @Hzfengsy. I think I prefer T.serial personally but I continue to be impressed by the TVMScript parser. I agree the linter made this a bit ugly. I want to add some additional tests in a follow up so I'll happily address the formatting then and consider the change to range.

T.serial is good too! Just make it in one line, e.g. for i in T.serial(0, 16): :)

csullivan added 5 commits June 6, 2022 08:49

[TIR] Update domain touched to track touched domains for all buffers
eb3feba
for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

[TE] Refactor logical steps of CreatePrimFunc into separate functions.
fa888bf

[TE] Update CreatePrimFunc to pre-populate buffer binds map with
f75d82d
user defined buffers expressed in te.extern ops.

[TE] Introduce te.extern_primfunc which allows for inlining a
5efedea
TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test showing the use of te.extern on a TVMScript PrimFunc
659dce6
Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

csullivan requested a review from masahi June 6, 2022 17:10

Fix task extraction default filter func skipping TE ExternOpNodes.
1936ae4

Hzfengsy approved these changes Jun 7, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc
Comment threadsrc/te/operation/create_primfunc.cc Outdated
Comment threadtests/python/unittest/test_meta_schedule_relay_tir_compute.py

csullivan commented Jun 8, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc

Address@Hzfengsy's review comments.
ad2b285

Hzfengsy requested changes Jun 9, 2022
View reviewed changes

Hzfengsy approved these changes Jun 10, 2022
View reviewed changes

junrushao merged commit 1420df7 into apache:mainJun 13, 2022

csullivan deleted the te/extern_primfunc branch June 13, 2022 15:51

areusch mentioned this pull request Jun 14, 2022
[Bug] Crash with tensorize + prefetch after PR#11589 #11716
Closed

Lunderberg mentioned this pull request Jun 30, 2022
[Arith] Updated BufferDomainTouched to use IRVisitorWithAnalyzer #11970
Merged

driazati mentioned this pull request Jul 14, 2022
TVM v0.9.0.rc0 Release Candidate Notes #12102
Closed

csullivan added 5 commits June 6, 2022 08:49

[TIR] Update domain touched to track touched domains for all buffers
eb3feba
for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

[TE] Refactor logical steps of CreatePrimFunc into separate functions.
fa888bf

[TE] Update CreatePrimFunc to pre-populate buffer binds map with
f75d82d
user defined buffers expressed in te.extern ops.

[TE] Introduce te.extern_primfunc which allows for inlining a
5efedea
TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test showing the use of te.extern on a TVMScript PrimFunc
659dce6
Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

csullivan requested a review from masahi June 6, 2022 17:10

Fix task extraction default filter func skipping TE ExternOpNodes.
1936ae4

Hzfengsy approved these changes Jun 7, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc
Comment threadsrc/te/operation/create_primfunc.cc Outdated
Comment threadtests/python/unittest/test_meta_schedule_relay_tir_compute.py

csullivan commented Jun 8, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc

Address@Hzfengsy's review comments.
ad2b285

Hzfengsy requested changes Jun 9, 2022
View reviewed changes

Hzfengsy approved these changes Jun 10, 2022
View reviewed changes

junrushao merged commit 1420df7 into apache:mainJun 13, 2022

csullivan deleted the te/extern_primfunc branch June 13, 2022 15:51

areusch mentioned this pull request Jun 14, 2022
[Bug] Crash with tensorize + prefetch after PR#11589 #11716
Closed

Lunderberg mentioned this pull request Jun 30, 2022
[Arith] Updated BufferDomainTouched to use IRVisitorWithAnalyzer #11970
Merged

driazati mentioned this pull request Jul 14, 2022
TVM v0.9.0.rc0 Release Candidate Notes #12102
Closed

csullivan added 5 commits June 6, 2022 08:49

[TIR] Update domain touched to track touched domains for all buffers
eb3feba
for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

[TE] Refactor logical steps of CreatePrimFunc into separate functions.
fa888bf

[TE] Update CreatePrimFunc to pre-populate buffer binds map with
f75d82d
user defined buffers expressed in te.extern ops.

[TE] Introduce te.extern_primfunc which allows for inlining a
5efedea
TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test showing the use of te.extern on a TVMScript PrimFunc
659dce6
Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

csullivan requested a review from masahi June 6, 2022 17:10

Fix task extraction default filter func skipping TE ExternOpNodes.
1936ae4

Hzfengsy approved these changes Jun 7, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc
Comment threadsrc/te/operation/create_primfunc.cc Outdated
Comment threadtests/python/unittest/test_meta_schedule_relay_tir_compute.py

csullivan commented Jun 8, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc

Address@Hzfengsy's review comments.
ad2b285

Hzfengsy requested changes Jun 9, 2022
View reviewed changes

Hzfengsy approved these changes Jun 10, 2022
View reviewed changes

junrushao merged commit 1420df7 into apache:mainJun 13, 2022

csullivan deleted the te/extern_primfunc branch June 13, 2022 15:51

areusch mentioned this pull request Jun 14, 2022
[Bug] Crash with tensorize + prefetch after PR#11589 #11716
Closed

Lunderberg mentioned this pull request Jun 30, 2022
[Arith] Updated BufferDomainTouched to use IRVisitorWithAnalyzer #11970
Merged

driazati mentioned this pull request Jul 14, 2022
TVM v0.9.0.rc0 Release Candidate Notes #12102
Closed

csullivan added 5 commits June 6, 2022 08:49

[TIR] Update domain touched to track touched domains for all buffers
eb3feba
for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

[TE] Refactor logical steps of CreatePrimFunc into separate functions.
fa888bf

[TE] Update CreatePrimFunc to pre-populate buffer binds map with
f75d82d
user defined buffers expressed in te.extern ops.

[TE] Introduce te.extern_primfunc which allows for inlining a
5efedea
TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test showing the use of te.extern on a TVMScript PrimFunc
659dce6
Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

csullivan requested a review from masahi June 6, 2022 17:10

Fix task extraction default filter func skipping TE ExternOpNodes.
1936ae4

Hzfengsy approved these changes Jun 7, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc
Comment threadsrc/te/operation/create_primfunc.cc Outdated
Comment threadtests/python/unittest/test_meta_schedule_relay_tir_compute.py

csullivan commented Jun 8, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc

Address@Hzfengsy's review comments.
ad2b285

Hzfengsy requested changes Jun 9, 2022
View reviewed changes

Hzfengsy approved these changes Jun 10, 2022
View reviewed changes

junrushao merged commit 1420df7 into apache:mainJun 13, 2022

csullivan deleted the te/extern_primfunc branch June 13, 2022 15:51

areusch mentioned this pull request Jun 14, 2022
[Bug] Crash with tensorize + prefetch after PR#11589 #11716
Closed

Lunderberg mentioned this pull request Jun 30, 2022
[Arith] Updated BufferDomainTouched to use IRVisitorWithAnalyzer #11970
Merged

driazati mentioned this pull request Jul 14, 2022
TVM v0.9.0.rc0 Release Candidate Notes #12102
Closed

csullivan added 5 commits June 6, 2022 08:49

[TIR] Update domain touched to track touched domains for all buffers
eb3feba
for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

[TE] Refactor logical steps of CreatePrimFunc into separate functions.
fa888bf

[TE] Update CreatePrimFunc to pre-populate buffer binds map with
f75d82d
user defined buffers expressed in te.extern ops.

[TE] Introduce te.extern_primfunc which allows for inlining a
5efedea
TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test showing the use of te.extern on a TVMScript PrimFunc
659dce6
Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

csullivan requested a review from masahi June 6, 2022 17:10

Fix task extraction default filter func skipping TE ExternOpNodes.
1936ae4

Hzfengsy approved these changes Jun 7, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc
Comment threadsrc/te/operation/create_primfunc.cc Outdated
Comment threadtests/python/unittest/test_meta_schedule_relay_tir_compute.py

csullivan commented Jun 8, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc

Address@Hzfengsy's review comments.
ad2b285

Hzfengsy requested changes Jun 9, 2022
View reviewed changes

Hzfengsy approved these changes Jun 10, 2022
View reviewed changes

junrushao merged commit 1420df7 into apache:mainJun 13, 2022

csullivan deleted the te/extern_primfunc branch June 13, 2022 15:51

areusch mentioned this pull request Jun 14, 2022
[Bug] Crash with tensorize + prefetch after PR#11589 #11716
Closed

Lunderberg mentioned this pull request Jun 30, 2022
[Arith] Updated BufferDomainTouched to use IRVisitorWithAnalyzer #11970
Merged

driazati mentioned this pull request Jul 14, 2022
TVM v0.9.0.rc0 Release Candidate Notes #12102
Closed

csullivan added 5 commits June 6, 2022 08:49

[TIR] Update domain touched to track touched domains for all buffers
eb3feba
for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

[TE] Refactor logical steps of CreatePrimFunc into separate functions.
fa888bf

[TE] Update CreatePrimFunc to pre-populate buffer binds map with
f75d82d
user defined buffers expressed in te.extern ops.

[TE] Introduce te.extern_primfunc which allows for inlining a
5efedea
TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test showing the use of te.extern on a TVMScript PrimFunc
659dce6
Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

csullivan requested a review from masahi June 6, 2022 17:10

Fix task extraction default filter func skipping TE ExternOpNodes.
1936ae4

Hzfengsy approved these changes Jun 7, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc
Comment threadsrc/te/operation/create_primfunc.cc Outdated
Comment threadtests/python/unittest/test_meta_schedule_relay_tir_compute.py

csullivan commented Jun 8, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc

Address@Hzfengsy's review comments.
ad2b285

Hzfengsy requested changes Jun 9, 2022
View reviewed changes

Hzfengsy approved these changes Jun 10, 2022
View reviewed changes

junrushao merged commit 1420df7 into apache:mainJun 13, 2022

csullivan deleted the te/extern_primfunc branch June 13, 2022 15:51

areusch mentioned this pull request Jun 14, 2022
[Bug] Crash with tensorize + prefetch after PR#11589 #11716
Closed

Lunderberg mentioned this pull request Jun 30, 2022
[Arith] Updated BufferDomainTouched to use IRVisitorWithAnalyzer #11970
Merged

driazati mentioned this pull request Jul 14, 2022
TVM v0.9.0.rc0 Release Candidate Notes #12102
Closed

csullivan added 5 commits June 6, 2022 08:49

[TIR] Update domain touched to track touched domains for all buffers
eb3feba
for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

[TE] Refactor logical steps of CreatePrimFunc into separate functions.
fa888bf

[TE] Update CreatePrimFunc to pre-populate buffer binds map with
f75d82d
user defined buffers expressed in te.extern ops.

[TE] Introduce te.extern_primfunc which allows for inlining a
5efedea
TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test showing the use of te.extern on a TVMScript PrimFunc
659dce6
Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

csullivan requested a review from masahi June 6, 2022 17:10

Fix task extraction default filter func skipping TE ExternOpNodes.
1936ae4

Hzfengsy approved these changes Jun 7, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc
Comment threadsrc/te/operation/create_primfunc.cc Outdated
Comment threadtests/python/unittest/test_meta_schedule_relay_tir_compute.py

csullivan commented Jun 8, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc

Address@Hzfengsy's review comments.
ad2b285

Hzfengsy requested changes Jun 9, 2022
View reviewed changes

Hzfengsy approved these changes Jun 10, 2022
View reviewed changes

junrushao merged commit 1420df7 into apache:mainJun 13, 2022

csullivan deleted the te/extern_primfunc branch June 13, 2022 15:51

areusch mentioned this pull request Jun 14, 2022
[Bug] Crash with tensorize + prefetch after PR#11589 #11716
Closed

Lunderberg mentioned this pull request Jun 30, 2022
[Arith] Updated BufferDomainTouched to use IRVisitorWithAnalyzer #11970
Merged

driazati mentioned this pull request Jul 14, 2022
TVM v0.9.0.rc0 Release Candidate Notes #12102
Closed

csullivan added 5 commits June 6, 2022 08:49

[TIR] Update domain touched to track touched domains for all buffers
eb3feba
for loads, stores and both in one pass. Expose an FFI to return the buffer domain access map.

[TE] Refactor logical steps of CreatePrimFunc into separate functions.
fa888bf

[TE] Update CreatePrimFunc to pre-populate buffer binds map with
f75d82d
user defined buffers expressed in te.extern ops.

[TE] Introduce te.extern_primfunc which allows for inlining a
5efedea
TVMScript defined schedulable TIR primfunc into TE. In this way TOPI compute definitions can be defined via TIR and scheduled using TIR scheduling primitives via meta-scheduler.

Add test showing the use of te.extern on a TVMScript PrimFunc
659dce6
Add test that uses TVMScript defined TOPI compute definition for relay meta-schedule execution.

csullivan requested a review from masahi June 6, 2022 17:10

Fix task extraction default filter func skipping TE ExternOpNodes.
1936ae4

Hzfengsy approved these changes Jun 7, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc
Comment threadsrc/te/operation/create_primfunc.cc Outdated
Comment threadtests/python/unittest/test_meta_schedule_relay_tir_compute.py

csullivan commented Jun 8, 2022
View reviewed changes

Comment threadsrc/arith/domain_touched.cc

Address@Hzfengsy's review comments.
ad2b285

Hzfengsy requested changes Jun 9, 2022
View reviewed changes

Hzfengsy approved these changes Jun 10, 2022
View reviewed changes

junrushao merged commit 1420df7 into apache:mainJun 13, 2022

csullivan deleted the te/extern_primfunc branch June 13, 2022 15:51

areusch mentioned this pull request Jun 14, 2022
[Bug] Crash with tensorize + prefetch after PR#11589 #11716
Closed

Lunderberg mentioned this pull request Jun 30, 2022
[Arith] Updated BufferDomainTouched to use IRVisitorWithAnalyzer #11970
Merged

driazati mentioned this pull request Jul 14, 2022
TVM v0.9.0.rc0 Release Candidate Notes #12102
Closed

-foriinT.serial(
-,
-,
- ):
+foriinrange(16):

Uh oh!

Conversation

csullivan commented Jun 6, 2022

Uh oh!

masahi commented Jun 6, 2022

Uh oh!

Hzfengsy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csullivan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

junrushao commented Jun 9, 2022

Uh oh!

Hzfengsy commented Jun 10, 2022

Uh oh!

csullivan commented Jun 13, 2022

Uh oh!

Hzfengsy commented Jun 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

csullivan commented Jun 6, 2022

Uh oh!

masahi commented Jun 6, 2022

Uh oh!

Hzfengsy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csullivan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

junrushao commented Jun 9, 2022

Uh oh!

Hzfengsy commented Jun 10, 2022

Uh oh!

csullivan commented Jun 13, 2022

Uh oh!

Hzfengsy commented Jun 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

csullivan left a comment •
edited
Loading

csullivan left a comment •
edited
Loading

csullivan left a comment •
edited
Loading