Uh oh!
There was an error while loading. Please reload this page.
[Docker][Pylint] Upgrade ci lint docker file - #11734
Merged
Merged
Conversation
AndrewZhaoLuo
commented
Jun 15, 2022
ContributorAuthor
cc @Mousius |
AndrewZhaoLuoforce-pushed
the
aluo/upgrade-pylint
branch
from
June 16, 2022 16:18
fa3a518 to
5870964Comparezxybazh pushed a commit
to zxybazh/tvm
that referenced
this pull request
Jun 16, 2022
leandron added a commit
to leandron/tvm
that referenced
this pull request
Jun 20, 2022
This reverts commit 7bfbc74, as it generates near 500 code violations when PyLint was updated from 2.4.4 to 2.9.3. Issue apache#11785 for details.
leandron added a commit
to leandron/tvm
that referenced
this pull request
Jun 23, 2022
This reverts commit 7bfbc74, as it generates near 500 code violations when PyLint was updated from 2.4.4 to 2.9.3. Issue apache#11785 for details.
lhutton1 pushed a commit
that referenced
this pull request
Jun 23, 2022
blackkker pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
This reverts commit 7bfbc74, as it generates near 500 code violations when PyLint was updated from 2.4.4 to 2.9.3. Issue apache#11785 for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading pylint allows the use of
good-names-rgxswhich allows us to create regexes which match "good" names in pylint as opposed to manually listing them all out usinggood-namesin the current version.Follow up issue: #11733
See https://github.com/apache/tvm/pull/11712/files for a potential example