Skip to content

[ci][docker] Use RFC image tags only - #11938

Merged
areusch merged 1 commit into
apache:mainfrom
driazati:fix_update_pr
Jul 27, 2022
Merged

[ci][docker] Use RFC image tags only#11938
areusch merged 1 commit into
apache:mainfrom
driazati:fix_update_pr

Conversation

@driazati

@driazatidriazati commented Jun 28, 2022•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This ignores any images that don't match the pattern laid out in apache/tvm-rfcs#66

cc @Mousius@areusch

@driazati
[ci][docker] Use RFC image tags only
28d0ba9
This ignores image names like `123-123-abc-validated`
@github-actions

github-actionsBot commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Built docs for commit 28d0ba9 can be found here.

@driazati
driazati marked this pull request as ready for review July 1, 2022 15:24
@github-actions

github-actionsBot commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

It has been a while since this PR was updated, @Mousius@areusch please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please convert it to a draft until it is ready for review.

@driazati
driazati requested a review from areuschJuly 11, 2022 17:16
@areusch

areusch commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

@driazati could you give a bit more context here? is there a bug describing what's wrong right now?

@driazati

driazati commented Jul 13, 2022

Copy link
Copy Markdown
MemberAuthor

it ignores any extra images that someone might manually push (or the validated ones that get pushed by ci with the name 123-123-abc-validated)

@github-actions

github-actionsBot commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

It has been a while since this PR was updated, @areusch@Mousius please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please convert it to a draft until it is ready for review.

@areusch

areusch commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

@gigiblender could you review this one so you can understand how this tool works?

@gigiblender

gigiblender commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

@gigiblender could you review this one so you can understand how this tool works?

@areusch Sure

@gigiblender

gigiblender commented Jul 26, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks @driazati! LGTM!

cc'ing @areusch to approve.

@areusch
areusch merged commit 465b579 into apache:mainJul 27, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@driazati@xinetzone
[ci][docker] Use RFC image tags only (apache#11938)
5318c7e
This ignores image names like `123-123-abc-validated`
Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@areuschareuschareusch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driazati@areusch@gigiblender