[Collage] SubGraphs by mbs-octoml · Pull Request #11981 · apache/tvm

mbs-octoml · 2022-06-30T23:51:53Z

See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md.

Collage works in units of 'sub-graphs', which are potential partitions of the
overall Relay model. This PR introduces SubGraph (an arbitrary partitioning, without
any implication about how it is to be represented), it's companion SubSubGraph
(implying a representation as a function), and some supporting odds 'n ends.

mbs-octoml · 2022-06-30T23:52:05Z

@mbaret, thanks.

mbs-octoml · 2022-07-01T20:14:31Z

green and ready for review

See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981.

SebastianBoblest · 2022-07-06T10:03:51Z

I read this out of curiosity, I cannot review this on a technical level.
On a fundamental level the code looks great though.

mbaret

Largely looks good to me, couple of points around naming. It's tacitly acknowledged that more of this infrastructure will get exercised by tests in later PRs.

See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. Collage works in units of 'sub-graphs', which are potential partitions of the overall Relay model. This PR introduces SubGraph (an arbitrary partitioning, without any implication about how it is to be represented), it's companion SubSubGraph (implying a representation as a function), and some supporting odds 'n ends.

- make 'Compiler' name explicit

mbs-octoml · 2022-07-11T18:07:59Z

Thanks @SebastianBoblest, every little bit helps.

Thanks and PTAL @mbaret.

mbaret

LGTM

See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981.

* [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on #11981. * - Backport improvements to partiton_rule_test.cc * - Oops

* [Collage] SubGraphs See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. Collage works in units of 'sub-graphs', which are potential partitions of the overall Relay model. This PR introduces SubGraph (an arbitrary partitioning, without any implication about how it is to be represented), it's companion SubSubGraph (implying a representation as a function), and some supporting odds 'n ends. * - make Integer <-> size_t conversion explicit - make 'Compiler' name explicit * - fix namespace ambiguity * - review comments

…#11993) * [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981. * - Backport improvements to partiton_rule_test.cc * - Oops

* [Collage] SubGraphs See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. Collage works in units of 'sub-graphs', which are potential partitions of the overall Relay model. This PR introduces SubGraph (an arbitrary partitioning, without any implication about how it is to be represented), it's companion SubSubGraph (implying a representation as a function), and some supporting odds 'n ends. * - make Integer <-> size_t conversion explicit - make 'Compiler' name explicit * - fix namespace ambiguity * - review comments

…#11993) * [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981. * - Backport improvements to partiton_rule_test.cc * - Oops

* [Collage] SubGraphs See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. Collage works in units of 'sub-graphs', which are potential partitions of the overall Relay model. This PR introduces SubGraph (an arbitrary partitioning, without any implication about how it is to be represented), it's companion SubSubGraph (implying a representation as a function), and some supporting odds 'n ends. * - make Integer <-> size_t conversion explicit - make 'Compiler' name explicit * - fix namespace ambiguity * - review comments

…#11993) * [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981. * - Backport improvements to partiton_rule_test.cc * - Oops

* [Collage] SubGraphs See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. Collage works in units of 'sub-graphs', which are potential partitions of the overall Relay model. This PR introduces SubGraph (an arbitrary partitioning, without any implication about how it is to be represented), it's companion SubSubGraph (implying a representation as a function), and some supporting odds 'n ends. * - make Integer <-> size_t conversion explicit - make 'Compiler' name explicit * - fix namespace ambiguity * - review comments

…#11993) * [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981. * - Backport improvements to partiton_rule_test.cc * - Oops

mbs-octoml force-pushed the mbs-collage-subgraph branch from cfc5aff to 300dc7dCompare July 1, 2022 18:17

mbs-octoml force-pushed the mbs-collage-subgraph branch from d0d4237 to d71779dCompare July 1, 2022 20:48

mbs-octoml mentioned this pull request Jul 1, 2022
[Collage] PartitionRule (though without CombinePartitionRule) #11993
Merged

mbs-octoml force-pushed the mbs-collage-subgraph branch from d71779d to 70fc25aCompare July 1, 2022 22:55