[TFLite][CI] Update TensorFlow dependency to 2.9.1 - #12131

Merged
areusch merged 1 commit into
apache:mainfrom
leandron:tflite_29_update
Sep 7, 2022
Merged

[TFLite][CI] Update TensorFlow dependency to 2.9.1#12131
areusch merged 1 commit into
apache:mainfrom
leandron:tflite_29_update

Conversation

@leandron

@leandronleandron commented Jul 19, 2022•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.

Adding it here as a draft until we get #12130 merged.

cc @Mousius@NicolaLancellotti@areusch@driazati@gigiblender

@leandron
leandronforce-pushed the tflite_29_update branch 3 times, most recently from 8f0fa97 to 2dd5353CompareJuly 19, 2022 16:46
@areusch

areusch commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.

@leandron

leandron commented Jul 25, 2022

Copy link
Copy Markdown
ContributorAuthor

@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.

This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.

@areusch

areusch commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?

@leandron

leandron commented Jul 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Yes. However it still requires the Docker images to have the updated TF for the whole CI.

I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.

@areusch

areusch commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

ah ok cool--lmk when i can take a look at them

@NicolaLancellottiNicolaLancellotti mentioned this pull request Jul 26, 2022
Closed
@leandronleandron mentioned this pull request Aug 23, 2022
Merged
@leandronleandron mentioned this pull request Aug 31, 2022
Merged
@leandron
leandron marked this pull request as ready for review September 2, 2022 15:32
@leandron

leandron commented Sep 2, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:

echo set\(USE_TFLITE ON\) >> config.cmake

to:

echo set\(USE_TFLITE /opt/tflite\) >> config.cmake

This way we keep the default source based installation in the new format introduced here.

If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.

@areusch

areusch commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

@mbrookhart could you have a look?

mbrookhart
mbrookhart reviewed Sep 2, 2022
View reviewed changes

@mbrookhartmbrookhart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but overall I think I'm okay with this.

Comment threaddocker/Dockerfile.ci_cpu Outdated
Comment threaddocker/install/ubuntu_install_cmake_source.sh Outdated
driazati
driazati reviewed Sep 2, 2022
View reviewed changes
Comment threaddocker/install/ubuntu_install_tflite.sh
Comment threaddocker/install/ubuntu_install_cmake_source.sh Outdated
@leandron
leandronforce-pushed the tflite_29_update branch 2 times, most recently from af4871f to d56e23fCompareSeptember 2, 2022 18:09
driazati
driazati approved these changes Sep 2, 2022
View reviewed changes

@driazatidriazati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed

Comment threaddocker/install/ubuntu_install_cmake_source.sh Outdated
@leandron

leandron commented Sep 2, 2022

Copy link
Copy Markdown
ContributorAuthor

lgtm once comments are addressed

Thanks @driazati

@leandron

leandron commented Sep 2, 2022

Copy link
Copy Markdown
ContributorAuthor

@tvm-bot rerun

@leandron

leandron commented Sep 5, 2022

Copy link
Copy Markdown
ContributorAuthor

@tvm-bot rerun

@leandron
leandronforce-pushed the tflite_29_update branch 2 times, most recently from 22fd81d to 4bc5e11CompareSeptember 5, 2022 10:39
@leandron
[TFLite][CI] Update TensorFlow dependency to 2.9.1
73c0dea
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
@mehrdadh

mehrdadh commented Sep 7, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.

tvm/apps/microtvm/pyproject.toml

Line 107 in 2622ac9

tensorflow = {version = "^2.1", optional = true}

@leandron

leandron commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.

tvm/apps/microtvm/pyproject.toml

Line 107 in 2622ac9

tensorflow = {version = "^2.1", optional = true}

Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm

@areusch
areusch merged commit bee5627 into apache:mainSep 7, 2022
@areusch

areusch commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

thanks @leandron !!

@mehrdadh

mehrdadh commented Sep 7, 2022

Copy link
Copy Markdown
Member

@leandron I don't think it changed recently, it should be fine

@driazatidriazati mentioned this pull request Sep 7, 2022
Merged
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@leandron@xinetzone
[TFLite][CI] Update TensorFlow dependency to 2.9.1 (apache#12131)
6c7da2e
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart left review comments
@driazatidriazatidriazati approved these changes
@MousiusMousiusAwaiting requested review from Mousius
@areuschareuschAwaiting requested review from areusch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leandron@areusch@mehrdadh@mbrookhart@driazati
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[TFLite][CI] Update TensorFlow dependency to 2.9.1 - #12131
Merged
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Sep 7, 2022
Merged
[TFLite][CI] Update TensorFlow dependency to 2.9.1#12131
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Conversation
@leandron
@leandronleandron
commented
Jul 19, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.
Adding it here as a draft until we get #12130 merged.
cc @Mousius@NicolaLancellotti@areusch@driazati@gigiblender
@leandron
leandronforce-pushed
the
tflite_29_update
branch
3 times, most recently
from
8f0fa97 to
2dd5353CompareJuly 19, 2022 16:46
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Yes. However it still requires the Docker images to have the updated TF for the whole CI.
I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.
@areusch
areusch
commented
Jul 26, 2022

Copy link


Copy Markdown

Contributor
ah ok cool--lmk when i can take a look at them
@NicolaLancellottiNicolaLancellotti
mentioned this pull request
Jul 26, 2022
 Closed

@leandronleandron
mentioned this pull request
Aug 23, 2022
 Merged

@leandronleandron
mentioned this pull request
Aug 31, 2022
 Merged

@leandron
leandron
marked this pull request as ready for review
September 2, 2022 15:32
@leandron
leandron
commented
Sep 2, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:
echo set\(USE_TFLITE ON\) >> config.cmake

to:
echo set\(USE_TFLITE /opt/tflite\) >> config.cmake

This way we keep the default source based installation in the new format introduced here.
If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.
@areusch
areusch
commented
Sep 2, 2022

Copy link


Copy Markdown

Contributor
@mbrookhart could you have a look?
mbrookhart
mbrookhart
reviewed
Sep 2, 2022
View reviewed changes
@mbrookhartmbrookhart
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but overall I think I'm okay with this.
Comment threaddocker/Dockerfile.ci_cpu
Outdated

Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

driazati
driazati
reviewed
Sep 2, 2022
View reviewed changes
Comment threaddocker/install/ubuntu_install_tflite.sh
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
af4871f to
d56e23fCompareSeptember 2, 2022 18:09
driazati
driazati
approved these changes
Sep 2, 2022
View reviewed changes
@driazatidriazati
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
lgtm once comments are addressed
Thanks @driazati
@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandron
commented
Sep 5, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
22fd81d to
4bc5e11CompareSeptember 5, 2022 10:39
@leandron
[TFLite][CI] Update TensorFlow dependency to 2.9.1
73c0dea
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
@mehrdadh
mehrdadh
commented
Sep 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
@leandron
leandron
commented
Sep 7, 2022

Copy link


Copy Markdown

ContributorAuthor
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm
@areusch
areusch
merged commit bee5627
into
apache:mainSep 7, 2022
@areusch
areusch
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
thanks @leandron !!
@mehrdadh
mehrdadh
commented
Sep 7, 2022

Copy link


Copy Markdown

Member
@leandron I don't think it changed recently, it should be fine
@driazatidriazati
mentioned this pull request
Sep 7, 2022
 Merged

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
@leandron@xinetzone
[TFLite][CI] Update TensorFlow dependency to 2.9.1 (apache#12131)
6c7da2e
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart left review comments
@driazatidriazatidriazati approved these changes
@MousiusMousiusAwaiting requested review from Mousius
@areuschareuschAwaiting requested review from areusch

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@leandron@areusch@mehrdadh@mbrookhart@driazati

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[TFLite][CI] Update TensorFlow dependency to 2.9.1 - #12131
Merged
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Sep 7, 2022
Merged
[TFLite][CI] Update TensorFlow dependency to 2.9.1#12131
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Conversation
@leandron
@leandronleandron
commented
Jul 19, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.
Adding it here as a draft until we get #12130 merged.
cc @Mousius@NicolaLancellotti@areusch@driazati@gigiblender
@leandron
leandronforce-pushed
the
tflite_29_update
branch
3 times, most recently
from
8f0fa97 to
2dd5353CompareJuly 19, 2022 16:46
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Yes. However it still requires the Docker images to have the updated TF for the whole CI.
I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.
@areusch
areusch
commented
Jul 26, 2022

Copy link


Copy Markdown

Contributor
ah ok cool--lmk when i can take a look at them
@NicolaLancellottiNicolaLancellotti
mentioned this pull request
Jul 26, 2022
 Closed

@leandronleandron
mentioned this pull request
Aug 23, 2022
 Merged

@leandronleandron
mentioned this pull request
Aug 31, 2022
 Merged

@leandron
leandron
marked this pull request as ready for review
September 2, 2022 15:32
@leandron
leandron
commented
Sep 2, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:
echo set\(USE_TFLITE ON\) >> config.cmake

to:
echo set\(USE_TFLITE /opt/tflite\) >> config.cmake

This way we keep the default source based installation in the new format introduced here.
If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.
@areusch
areusch
commented
Sep 2, 2022

Copy link


Copy Markdown

Contributor
@mbrookhart could you have a look?
mbrookhart
mbrookhart
reviewed
Sep 2, 2022
View reviewed changes
@mbrookhartmbrookhart
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but overall I think I'm okay with this.
Comment threaddocker/Dockerfile.ci_cpu
Outdated

Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

driazati
driazati
reviewed
Sep 2, 2022
View reviewed changes
Comment threaddocker/install/ubuntu_install_tflite.sh
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
af4871f to
d56e23fCompareSeptember 2, 2022 18:09
driazati
driazati
approved these changes
Sep 2, 2022
View reviewed changes
@driazatidriazati
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
lgtm once comments are addressed
Thanks @driazati
@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandron
commented
Sep 5, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
22fd81d to
4bc5e11CompareSeptember 5, 2022 10:39
@leandron
[TFLite][CI] Update TensorFlow dependency to 2.9.1
73c0dea
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
@mehrdadh
mehrdadh
commented
Sep 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
@leandron
leandron
commented
Sep 7, 2022

Copy link


Copy Markdown

ContributorAuthor
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm
@areusch
areusch
merged commit bee5627
into
apache:mainSep 7, 2022
@areusch
areusch
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
thanks @leandron !!
@mehrdadh
mehrdadh
commented
Sep 7, 2022

Copy link


Copy Markdown

Member
@leandron I don't think it changed recently, it should be fine
@driazatidriazati
mentioned this pull request
Sep 7, 2022
 Merged

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
@leandron@xinetzone
[TFLite][CI] Update TensorFlow dependency to 2.9.1 (apache#12131)
6c7da2e
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart left review comments
@driazatidriazatidriazati approved these changes
@MousiusMousiusAwaiting requested review from Mousius
@areuschareuschAwaiting requested review from areusch

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@leandron@areusch@mehrdadh@mbrookhart@driazati

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[TFLite][CI] Update TensorFlow dependency to 2.9.1 - #12131
Merged
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Sep 7, 2022
Merged
[TFLite][CI] Update TensorFlow dependency to 2.9.1#12131
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Conversation
@leandron
@leandronleandron
commented
Jul 19, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.
Adding it here as a draft until we get #12130 merged.
cc @Mousius@NicolaLancellotti@areusch@driazati@gigiblender
@leandron
leandronforce-pushed
the
tflite_29_update
branch
3 times, most recently
from
8f0fa97 to
2dd5353CompareJuly 19, 2022 16:46
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Yes. However it still requires the Docker images to have the updated TF for the whole CI.
I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.
@areusch
areusch
commented
Jul 26, 2022

Copy link


Copy Markdown

Contributor
ah ok cool--lmk when i can take a look at them
@NicolaLancellottiNicolaLancellotti
mentioned this pull request
Jul 26, 2022
 Closed

@leandronleandron
mentioned this pull request
Aug 23, 2022
 Merged

@leandronleandron
mentioned this pull request
Aug 31, 2022
 Merged

@leandron
leandron
marked this pull request as ready for review
September 2, 2022 15:32
@leandron
leandron
commented
Sep 2, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:
echo set\(USE_TFLITE ON\) >> config.cmake

to:
echo set\(USE_TFLITE /opt/tflite\) >> config.cmake

This way we keep the default source based installation in the new format introduced here.
If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.
@areusch
areusch
commented
Sep 2, 2022

Copy link


Copy Markdown

Contributor
@mbrookhart could you have a look?
mbrookhart
mbrookhart
reviewed
Sep 2, 2022
View reviewed changes
@mbrookhartmbrookhart
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but overall I think I'm okay with this.
Comment threaddocker/Dockerfile.ci_cpu
Outdated

Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

driazati
driazati
reviewed
Sep 2, 2022
View reviewed changes
Comment threaddocker/install/ubuntu_install_tflite.sh
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
af4871f to
d56e23fCompareSeptember 2, 2022 18:09
driazati
driazati
approved these changes
Sep 2, 2022
View reviewed changes
@driazatidriazati
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
lgtm once comments are addressed
Thanks @driazati
@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandron
commented
Sep 5, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
22fd81d to
4bc5e11CompareSeptember 5, 2022 10:39
@leandron
[TFLite][CI] Update TensorFlow dependency to 2.9.1
73c0dea
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
@mehrdadh
mehrdadh
commented
Sep 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
@leandron
leandron
commented
Sep 7, 2022

Copy link


Copy Markdown

ContributorAuthor
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm
@areusch
areusch
merged commit bee5627
into
apache:mainSep 7, 2022
@areusch
areusch
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
thanks @leandron !!
@mehrdadh
mehrdadh
commented
Sep 7, 2022

Copy link


Copy Markdown

Member
@leandron I don't think it changed recently, it should be fine
@driazatidriazati
mentioned this pull request
Sep 7, 2022
 Merged

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
@leandron@xinetzone
[TFLite][CI] Update TensorFlow dependency to 2.9.1 (apache#12131)
6c7da2e
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart left review comments
@driazatidriazatidriazati approved these changes
@MousiusMousiusAwaiting requested review from Mousius
@areuschareuschAwaiting requested review from areusch

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@leandron@areusch@mehrdadh@mbrookhart@driazati

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[TFLite][CI] Update TensorFlow dependency to 2.9.1 - #12131
Merged
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Sep 7, 2022
Merged
[TFLite][CI] Update TensorFlow dependency to 2.9.1#12131
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Conversation
@leandron
@leandronleandron
commented
Jul 19, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.
Adding it here as a draft until we get #12130 merged.
cc @Mousius@NicolaLancellotti@areusch@driazati@gigiblender
@leandron
leandronforce-pushed
the
tflite_29_update
branch
3 times, most recently
from
8f0fa97 to
2dd5353CompareJuly 19, 2022 16:46
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Yes. However it still requires the Docker images to have the updated TF for the whole CI.
I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.
@areusch
areusch
commented
Jul 26, 2022

Copy link


Copy Markdown

Contributor
ah ok cool--lmk when i can take a look at them
@NicolaLancellottiNicolaLancellotti
mentioned this pull request
Jul 26, 2022
 Closed

@leandronleandron
mentioned this pull request
Aug 23, 2022
 Merged

@leandronleandron
mentioned this pull request
Aug 31, 2022
 Merged

@leandron
leandron
marked this pull request as ready for review
September 2, 2022 15:32
@leandron
leandron
commented
Sep 2, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:
echo set\(USE_TFLITE ON\) >> config.cmake

to:
echo set\(USE_TFLITE /opt/tflite\) >> config.cmake

This way we keep the default source based installation in the new format introduced here.
If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.
@areusch
areusch
commented
Sep 2, 2022

Copy link


Copy Markdown

Contributor
@mbrookhart could you have a look?
mbrookhart
mbrookhart
reviewed
Sep 2, 2022
View reviewed changes
@mbrookhartmbrookhart
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but overall I think I'm okay with this.
Comment threaddocker/Dockerfile.ci_cpu
Outdated

Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

driazati
driazati
reviewed
Sep 2, 2022
View reviewed changes
Comment threaddocker/install/ubuntu_install_tflite.sh
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
af4871f to
d56e23fCompareSeptember 2, 2022 18:09
driazati
driazati
approved these changes
Sep 2, 2022
View reviewed changes
@driazatidriazati
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
lgtm once comments are addressed
Thanks @driazati
@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandron
commented
Sep 5, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
22fd81d to
4bc5e11CompareSeptember 5, 2022 10:39
@leandron
[TFLite][CI] Update TensorFlow dependency to 2.9.1
73c0dea
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
@mehrdadh
mehrdadh
commented
Sep 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
@leandron
leandron
commented
Sep 7, 2022

Copy link


Copy Markdown

ContributorAuthor
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm
@areusch
areusch
merged commit bee5627
into
apache:mainSep 7, 2022
@areusch
areusch
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
thanks @leandron !!
@mehrdadh
mehrdadh
commented
Sep 7, 2022

Copy link


Copy Markdown

Member
@leandron I don't think it changed recently, it should be fine
@driazatidriazati
mentioned this pull request
Sep 7, 2022
 Merged

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
@leandron@xinetzone
[TFLite][CI] Update TensorFlow dependency to 2.9.1 (apache#12131)
6c7da2e
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart left review comments
@driazatidriazatidriazati approved these changes
@MousiusMousiusAwaiting requested review from Mousius
@areuschareuschAwaiting requested review from areusch

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@leandron@areusch@mehrdadh@mbrookhart@driazati

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[TFLite][CI] Update TensorFlow dependency to 2.9.1 - #12131
Merged
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Sep 7, 2022
Merged
[TFLite][CI] Update TensorFlow dependency to 2.9.1#12131
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Conversation
@leandron
@leandronleandron
commented
Jul 19, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.
Adding it here as a draft until we get #12130 merged.
cc @Mousius@NicolaLancellotti@areusch@driazati@gigiblender
@leandron
leandronforce-pushed
the
tflite_29_update
branch
3 times, most recently
from
8f0fa97 to
2dd5353CompareJuly 19, 2022 16:46
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Yes. However it still requires the Docker images to have the updated TF for the whole CI.
I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.
@areusch
areusch
commented
Jul 26, 2022

Copy link


Copy Markdown

Contributor
ah ok cool--lmk when i can take a look at them
@NicolaLancellottiNicolaLancellotti
mentioned this pull request
Jul 26, 2022
 Closed

@leandronleandron
mentioned this pull request
Aug 23, 2022
 Merged

@leandronleandron
mentioned this pull request
Aug 31, 2022
 Merged

@leandron
leandron
marked this pull request as ready for review
September 2, 2022 15:32
@leandron
leandron
commented
Sep 2, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:
echo set\(USE_TFLITE ON\) >> config.cmake

to:
echo set\(USE_TFLITE /opt/tflite\) >> config.cmake

This way we keep the default source based installation in the new format introduced here.
If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.
@areusch
areusch
commented
Sep 2, 2022

Copy link


Copy Markdown

Contributor
@mbrookhart could you have a look?
mbrookhart
mbrookhart
reviewed
Sep 2, 2022
View reviewed changes
@mbrookhartmbrookhart
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but overall I think I'm okay with this.
Comment threaddocker/Dockerfile.ci_cpu
Outdated

Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

driazati
driazati
reviewed
Sep 2, 2022
View reviewed changes
Comment threaddocker/install/ubuntu_install_tflite.sh
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
af4871f to
d56e23fCompareSeptember 2, 2022 18:09
driazati
driazati
approved these changes
Sep 2, 2022
View reviewed changes
@driazatidriazati
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
lgtm once comments are addressed
Thanks @driazati
@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandron
commented
Sep 5, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
22fd81d to
4bc5e11CompareSeptember 5, 2022 10:39
@leandron
[TFLite][CI] Update TensorFlow dependency to 2.9.1
73c0dea
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
@mehrdadh
mehrdadh
commented
Sep 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
@leandron
leandron
commented
Sep 7, 2022

Copy link


Copy Markdown

ContributorAuthor
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm
@areusch
areusch
merged commit bee5627
into
apache:mainSep 7, 2022
@areusch
areusch
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
thanks @leandron !!
@mehrdadh
mehrdadh
commented
Sep 7, 2022

Copy link


Copy Markdown

Member
@leandron I don't think it changed recently, it should be fine
@driazatidriazati
mentioned this pull request
Sep 7, 2022
 Merged

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
@leandron@xinetzone
[TFLite][CI] Update TensorFlow dependency to 2.9.1 (apache#12131)
6c7da2e
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart left review comments
@driazatidriazatidriazati approved these changes
@MousiusMousiusAwaiting requested review from Mousius
@areuschareuschAwaiting requested review from areusch

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@leandron@areusch@mehrdadh@mbrookhart@driazati

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[TFLite][CI] Update TensorFlow dependency to 2.9.1 - #12131
Merged
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Sep 7, 2022
Merged
[TFLite][CI] Update TensorFlow dependency to 2.9.1#12131
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Conversation
@leandron
@leandronleandron
commented
Jul 19, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.
Adding it here as a draft until we get #12130 merged.
cc @Mousius@NicolaLancellotti@areusch@driazati@gigiblender
@leandron
leandronforce-pushed
the
tflite_29_update
branch
3 times, most recently
from
8f0fa97 to
2dd5353CompareJuly 19, 2022 16:46
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Yes. However it still requires the Docker images to have the updated TF for the whole CI.
I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.
@areusch
areusch
commented
Jul 26, 2022

Copy link


Copy Markdown

Contributor
ah ok cool--lmk when i can take a look at them
@NicolaLancellottiNicolaLancellotti
mentioned this pull request
Jul 26, 2022
 Closed

@leandronleandron
mentioned this pull request
Aug 23, 2022
 Merged

@leandronleandron
mentioned this pull request
Aug 31, 2022
 Merged

@leandron
leandron
marked this pull request as ready for review
September 2, 2022 15:32
@leandron
leandron
commented
Sep 2, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:
echo set\(USE_TFLITE ON\) >> config.cmake

to:
echo set\(USE_TFLITE /opt/tflite\) >> config.cmake

This way we keep the default source based installation in the new format introduced here.
If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.
@areusch
areusch
commented
Sep 2, 2022

Copy link


Copy Markdown

Contributor
@mbrookhart could you have a look?
mbrookhart
mbrookhart
reviewed
Sep 2, 2022
View reviewed changes
@mbrookhartmbrookhart
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but overall I think I'm okay with this.
Comment threaddocker/Dockerfile.ci_cpu
Outdated

Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

driazati
driazati
reviewed
Sep 2, 2022
View reviewed changes
Comment threaddocker/install/ubuntu_install_tflite.sh
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
af4871f to
d56e23fCompareSeptember 2, 2022 18:09
driazati
driazati
approved these changes
Sep 2, 2022
View reviewed changes
@driazatidriazati
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
lgtm once comments are addressed
Thanks @driazati
@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandron
commented
Sep 5, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
22fd81d to
4bc5e11CompareSeptember 5, 2022 10:39
@leandron
[TFLite][CI] Update TensorFlow dependency to 2.9.1
73c0dea
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
@mehrdadh
mehrdadh
commented
Sep 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
@leandron
leandron
commented
Sep 7, 2022

Copy link


Copy Markdown

ContributorAuthor
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm
@areusch
areusch
merged commit bee5627
into
apache:mainSep 7, 2022
@areusch
areusch
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
thanks @leandron !!
@mehrdadh
mehrdadh
commented
Sep 7, 2022

Copy link


Copy Markdown

Member
@leandron I don't think it changed recently, it should be fine
@driazatidriazati
mentioned this pull request
Sep 7, 2022
 Merged

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
@leandron@xinetzone
[TFLite][CI] Update TensorFlow dependency to 2.9.1 (apache#12131)
6c7da2e
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart left review comments
@driazatidriazatidriazati approved these changes
@MousiusMousiusAwaiting requested review from Mousius
@areuschareuschAwaiting requested review from areusch

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@leandron@areusch@mehrdadh@mbrookhart@driazati

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[TFLite][CI] Update TensorFlow dependency to 2.9.1 - #12131
Merged
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Sep 7, 2022
Merged
[TFLite][CI] Update TensorFlow dependency to 2.9.1#12131
areusch merged 1 commit into
apache:mainfrom 
leandron:tflite_29_update
Conversation
@leandron
@leandronleandron
commented
Jul 19, 2022•

edited by github-actions
Bot
Loading

Copy link


Copy Markdown

Contributor
This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.
Adding it here as a draft until we get #12130 merged.
cc @Mousius@NicolaLancellotti@areusch@driazati@gigiblender
@leandron
leandronforce-pushed
the
tflite_29_update
branch
3 times, most recently
from
8f0fa97 to
2dd5353CompareJuly 19, 2022 16:46
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.
@areusch
areusch
commented
Jul 25, 2022

Copy link


Copy Markdown

Contributor
hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?
@leandron
leandron
commented
Jul 25, 2022

Copy link


Copy Markdown

ContributorAuthor
Yes. However it still requires the Docker images to have the updated TF for the whole CI.
I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.
@areusch
areusch
commented
Jul 26, 2022

Copy link


Copy Markdown

Contributor
ah ok cool--lmk when i can take a look at them
@NicolaLancellottiNicolaLancellotti
mentioned this pull request
Jul 26, 2022
 Closed

@leandronleandron
mentioned this pull request
Aug 23, 2022
 Merged

@leandronleandron
mentioned this pull request
Aug 31, 2022
 Merged

@leandron
leandron
marked this pull request as ready for review
September 2, 2022 15:32
@leandron
leandron
commented
Sep 2, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:
echo set\(USE_TFLITE ON\) >> config.cmake

to:
echo set\(USE_TFLITE /opt/tflite\) >> config.cmake

This way we keep the default source based installation in the new format introduced here.
If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.
@areusch
areusch
commented
Sep 2, 2022

Copy link


Copy Markdown

Contributor
@mbrookhart could you have a look?
mbrookhart
mbrookhart
reviewed
Sep 2, 2022
View reviewed changes
@mbrookhartmbrookhart
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but overall I think I'm okay with this.
Comment threaddocker/Dockerfile.ci_cpu
Outdated

Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

driazati
driazati
reviewed
Sep 2, 2022
View reviewed changes
Comment threaddocker/install/ubuntu_install_tflite.sh
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
af4871f to
d56e23fCompareSeptember 2, 2022 18:09
driazati
driazati
approved these changes
Sep 2, 2022
View reviewed changes
@driazatidriazati
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed
Comment threaddocker/install/ubuntu_install_cmake_source.sh
Outdated

@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
lgtm once comments are addressed
Thanks @driazati
@leandron
leandron
commented
Sep 2, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandron
commented
Sep 5, 2022

Copy link


Copy Markdown

ContributorAuthor
@tvm-bot rerun
@leandron
leandronforce-pushed
the
tflite_29_update
branch
2 times, most recently
from
22fd81d to
4bc5e11CompareSeptember 5, 2022 10:39
@leandron
[TFLite][CI] Update TensorFlow dependency to 2.9.1
73c0dea
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
@mehrdadh
mehrdadh
commented
Sep 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
@leandron
leandron
commented
Sep 7, 2022

Copy link


Copy Markdown

ContributorAuthor
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
tvm/apps/microtvm/pyproject.toml

Line 107
in
2622ac9
tensorflow = {version = "^2.1", optional = true} 
Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm
@areusch
areusch
merged commit bee5627
into
apache:mainSep 7, 2022
@areusch
areusch
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
thanks @leandron !!
@mehrdadh
mehrdadh
commented
Sep 7, 2022

Copy link


Copy Markdown

Member
@leandron I don't think it changed recently, it should be fine
@driazatidriazati
mentioned this pull request
Sep 7, 2022
 Merged

xinetzone pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
@leandron@xinetzone
[TFLite][CI] Update TensorFlow dependency to 2.9.1 (apache#12131)
6c7da2e
This updates the TF version to be used in TVM CI to 2.9.1,
which brings improvements so that more platforms are supported by
official packages.
When building TFLite, an update to CMake was also required,
which is updated now to 3.18.4.
ethos-u-vela dependency is also updated, from version 3.2.0 to 3.4.0
so that it is closer to the TensorFlow version being proposed here.
This PR updates the Docker images scripting to install TF and TFLite.
Change-Id: I290085f0c018ad57606f1295494c19ff6e1af2dd
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mbrookhartmbrookhartmbrookhart left review comments
@driazatidriazatidriazati approved these changes
@MousiusMousiusAwaiting requested review from Mousius
@areuschareuschAwaiting requested review from areusch

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@leandron@areusch@mehrdadh@mbrookhart@driazati