[Arith][TIR] IntSetAnalyzer, delay intersection of IntSet until use by Lunderberg · Pull Request #12821 · apache/tvm

Lunderberg · 2022-09-16T19:34:23Z

Follow-up from #11970, to improve performance. In the initial implementation, the analyzer->int_set would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to Intersect until required, following the same behavior as ConstIntBound.

cc @Hzfengsy @junrushao1994

Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

wrongtest-intellif · 2022-09-18T07:52:19Z

Also happy to know IRVisitorWithAnalyzer now come back to life! I remember it is in somewhat broken state for a long time.

tkonolige

Thanks @Lunderberg!

…pache#12821) Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

Lunderberg · 2022-09-16T19:34:23Z

Follow-up from #11970, to improve performance. In the initial implementation, the analyzer->int_set would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to Intersect until required, following the same behavior as ConstIntBound.

cc @Hzfengsy @junrushao1994

Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

wrongtest-intellif · 2022-09-18T07:52:19Z

Also happy to know IRVisitorWithAnalyzer now come back to life! I remember it is in somewhat broken state for a long time.

tkonolige

Thanks @Lunderberg!

…pache#12821) Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

Lunderberg · 2022-09-16T19:34:23Z

Follow-up from #11970, to improve performance. In the initial implementation, the analyzer->int_set would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to Intersect until required, following the same behavior as ConstIntBound.

cc @Hzfengsy @junrushao1994

Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

wrongtest-intellif · 2022-09-18T07:52:19Z

Also happy to know IRVisitorWithAnalyzer now come back to life! I remember it is in somewhat broken state for a long time.

tkonolige

Thanks @Lunderberg!

…pache#12821) Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

Lunderberg · 2022-09-16T19:34:23Z

Follow-up from #11970, to improve performance. In the initial implementation, the analyzer->int_set would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to Intersect until required, following the same behavior as ConstIntBound.

cc @Hzfengsy @junrushao1994

Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

wrongtest-intellif · 2022-09-18T07:52:19Z

Also happy to know IRVisitorWithAnalyzer now come back to life! I remember it is in somewhat broken state for a long time.

tkonolige

Thanks @Lunderberg!

…pache#12821) Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

Lunderberg · 2022-09-16T19:34:23Z

Follow-up from #11970, to improve performance. In the initial implementation, the analyzer->int_set would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to Intersect until required, following the same behavior as ConstIntBound.

cc @Hzfengsy @junrushao1994

Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

wrongtest-intellif · 2022-09-18T07:52:19Z

Also happy to know IRVisitorWithAnalyzer now come back to life! I remember it is in somewhat broken state for a long time.

tkonolige

Thanks @Lunderberg!

…pache#12821) Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

Lunderberg · 2022-09-16T19:34:23Z

Follow-up from #11970, to improve performance. In the initial implementation, the analyzer->int_set would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to Intersect until required, following the same behavior as ConstIntBound.

cc @Hzfengsy @junrushao1994

Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

wrongtest-intellif · 2022-09-18T07:52:19Z

Also happy to know IRVisitorWithAnalyzer now come back to life! I remember it is in somewhat broken state for a long time.

tkonolige

Thanks @Lunderberg!

…pache#12821) Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

Lunderberg · 2022-09-16T19:34:23Z

Follow-up from #11970, to improve performance. In the initial implementation, the analyzer->int_set would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to Intersect until required, following the same behavior as ConstIntBound.

cc @Hzfengsy @junrushao1994

Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

wrongtest-intellif · 2022-09-18T07:52:19Z

Also happy to know IRVisitorWithAnalyzer now come back to life! I remember it is in somewhat broken state for a long time.

tkonolige

Thanks @Lunderberg!

…pache#12821) Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

Lunderberg · 2022-09-16T19:34:23Z

Follow-up from #11970, to improve performance. In the initial implementation, the analyzer->int_set would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to Intersect until required, following the same behavior as ConstIntBound.

cc @Hzfengsy @junrushao1994

Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

wrongtest-intellif · 2022-09-18T07:52:19Z

Also happy to know IRVisitorWithAnalyzer now come back to life! I remember it is in somewhat broken state for a long time.

tkonolige

Thanks @Lunderberg!

…pache#12821) Follow-up from apache#11970, to improve performance. In the initial implementation, the `analyzer->int_set` would compute the intersection of all scope-based constraints when entering the scope, even if they weren't actually used. This commit delays the call to `Intersect` until required, following the same behavior as `ConstIntBound`.

tkonolige approved these changes Sep 19, 2022
View reviewed changes