') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [Hexagon] Support template-free meta schedule tuning by masahi · Pull Request #12854 · apache/tvm · GitHub
Skip to content

[Hexagon] Support template-free meta schedule tuning - #12854

Merged
tmoreau89 merged 4 commits into
apache:mainfrom
masahi:hex-metasch-auto
Oct 3, 2022
Merged

[Hexagon] Support template-free meta schedule tuning#12854
tmoreau89 merged 4 commits into
apache:mainfrom
masahi:hex-metasch-auto

Conversation

@masahi

@masahimasahi commented Sep 21, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Building on #12845, this PR adds an initial support for template-free auto tuning on Hexagon.

Test cases demonstrate:

  • Auto-scheduler style, template free tuning for fp16 conv2d in NHWC layout.
  • vrmpy auto tensorization for TE int8 dense (weight pre-packed), achieving 440 GOPs on SD888.

Known issues:

  • Due to the issue explained in [Node][Metaschedule] Allow ignoring NDArray raw data in StructuralEqual / Hash #12706, link-params = True, required by Hexagon, causes identical workloads to be tuned as distinct tasks. So e2d tuning is very slow without the changes from 12706.
  • Tuning nn.dense essentially requires metaschedule RewriteLayout postproc: I found that the memory access pattern of nn.dense, C[i, j] += A[i, k] * B[j, k], where the j axis is vectorized, performs terribly on Hexagon. But the implementation of RewriteLayout is completely incompatible with link-params = True. Until we fix this, we cannot enable RewriteLayout for Hexagon and hence tuning nn.dense (and nn.batch_matmul) is not supported for now.

cc @kparzysz-quic@junrushao@tmoreau89

masahi
masahi commented Sep 21, 2022
View reviewed changes
Comment threadpython/tvm/meta_schedule/tune.py
"relay.FuseOps.link_params": link_params,
"relay.backend.use_meta_schedule": True,
"relay.backend.tir_converter": "default",
}

@masahimasahiSep 21, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

tvm/python/tvm/meta_schedule/relay_integration.py

Lines 87 to 91 in 370abe6

ifpass_configisNone:
pass_config= {
"relay.backend.use_meta_schedule": True,
"relay.backend.tir_converter": tir_converter,
}
for why this change is necessary. We only need to pass relay.FuseOps.link_params config, others are for compatibility with the existing code.

@masahi

masahi commented Sep 21, 2022

Copy link
Copy Markdown
MemberAuthor

@tvm-bot rerun

kparzysz-quic
kparzysz-quic reviewed Sep 30, 2022
View reviewed changes
Comment threadtests/python/contrib/test_hexagon/test_meta_schedule.py
postproc.RewriteTensorize(vectorize_init_loop=True),
]

if True:

@kparzysz-quickparzysz-quicSep 30, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a leftover from something?

@masahimasahiSep 30, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally left it so that people can experiment with both then and else paths. The else path just compiles and runs the best schedule found in my experiment, which reproduces 440 GOPs performance.

@tmoreau89
tmoreau89 merged commit fa17da2 into apache:mainOct 3, 2022
@tmoreau89

tmoreau89 commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Thanks @masahi@kparzysz-quic, the PR has been merged!

@junrushaojunrushao mentioned this pull request Oct 3, 2022
Merged
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@masahi@xinetzone
[Hexagon] Support template-free meta schedule tuning (apache#12854)
fa23ae6
* [Metaschedule] Support template-free tuning on Hexagon
* enable multi threading
* update tests
* black
@leandronleandron mentioned this pull request Feb 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junrushaojunrushaoAwaiting requested review from junrushao
@tmoreau89tmoreau89Awaiting requested review from tmoreau89
1 more reviewer
@kparzysz-quickparzysz-quickparzysz-quic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@masahi@tmoreau89@kparzysz-quic