Uh oh!
There was an error while loading. Please reload this page.
[Fix][Arith] Analyzer simplification starts with canonical - #13875
Merged
tqchen merged 1 commit intoFeb 3, 2023
Merged
Conversation
tvm-bot
commented
Jan 30, 2023
Collaborator
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
MasterJH5574force-pushed
the
tvm-dev/2023-01-30-analyzer-simplification-starts-c
branch
3 times, most recently
from
January 31, 2023 01:47
87cc850 to
e1de9c6CompareHzfengsy
commented
Jan 31, 2023
Member
MasterJH5574force-pushed
the
tvm-dev/2023-01-30-analyzer-simplification-starts-c
branch
2 times, most recently
from
January 31, 2023 15:54
4edd0cb to
23346f1CompareUh oh!
There was an error while loading. Please reload this page.
MasterJH5574force-pushed
the
tvm-dev/2023-01-30-analyzer-simplification-starts-c
branch
2 times, most recently
from
January 31, 2023 18:20
e0b19bb to
0b4d970CompareMasterJH5574
commented
Jan 31, 2023
ContributorAuthor
@tvm-bot rerun |
MasterJH5574force-pushed
the
tvm-dev/2023-01-30-analyzer-simplification-starts-c
branch
from
January 31, 2023 22:48
0b4d970 to
5b28e7eComparetqchen
commented
Feb 1, 2023
Member
@tvm-bot rerun |
MasterJH5574force-pushed
the
tvm-dev/2023-01-30-analyzer-simplification-starts-c
branch
5 times, most recently
from
February 3, 2023 03:37
361feea to
0820465CompareMasterJH5574
marked this pull request as draft
February 3, 2023 03:37
MasterJH5574force-pushed
the
tvm-dev/2023-01-30-analyzer-simplification-starts-c
branch
from
February 3, 2023 03:39
0820465 to
ce45b2aCompareThis PR updates the order of arithmetic analyzer simplification, by adding a stage of canonical simplification at the very beginning so that every simplification always starts with a canonical round. This is because the rewrite simplification may destroy some PrimExpr property that the canonical simplification can make use of. Therefore, adding the canonical one in the front can maximize the use of canonical simplification.
MasterJH5574force-pushed
the
tvm-dev/2023-01-30-analyzer-simplification-starts-c
branch
from
February 3, 2023 05:04
ce45b2a to
4df3068Comparetqchen
marked this pull request as ready for review
February 3, 2023 14:34
tqchen
approved these changes
Feb 3, 2023
junrushao pushed a commit
to junrushao/tvm
that referenced
this pull request
Feb 8, 2023
) (apache#404) This PR updates the order of arithmetic analyzer simplification, by adding a stage of canonical simplification at the very beginning so that every simplification always starts with a canonical round. This is because the rewrite simplification may destroy some PrimExpr property that the canonical simplification can make use of. Therefore, adding the canonical one in the front can maximize the use of canonical simplification.
yelite pushed a commit
to yelite/tvm
that referenced
this pull request
Feb 17, 2023
) (apache#404) This PR updates the order of arithmetic analyzer simplification, by adding a stage of canonical simplification at the very beginning so that every simplification always starts with a canonical round. This is because the rewrite simplification may destroy some PrimExpr property that the canonical simplification can make use of. Therefore, adding the canonical one in the front can maximize the use of canonical simplification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the order of arithmetic analyzer simplification, by adding a stage of canonical simplification at the very beginning so that every simplification always starts with a canonical round. This is because the rewrite simplification may destroy some PrimExpr property that the canonical simplification can make use of. Therefore, adding the canonical one in the front can maximize the use of canonical simplification.