Skip to content

[Unity] Support pattern-based rewriting - #14312

Merged
masahi merged 12 commits into
apache:unityfrom
masahi:pattern-rewriting
Mar 16, 2023
Merged

[Unity] Support pattern-based rewriting#14312
masahi merged 12 commits into
apache:unityfrom
masahi:pattern-rewriting

Conversation

@masahi

@masahimasahi commented Mar 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Currently, dataflow pattern matching in Relax only supports matching with boolean result and doesn't support rewriting matched expressions. This PR adds such utility following the Relay counterpart below (with a simpler API).

tvm/python/tvm/relay/dataflow_pattern/__init__.py

Line 884 in da99e9d

defrewrite(callbacks, expr: Expr, mod: Optional[_ir.IRModule] =None) ->Expr:

This is useful for, for example, rewriting a sequence of matmul -> softmax -> matmul into an attention op introduced in #14150.

@cyx-6@sunggg@vinx13@yelite@MasterJH5574@spectrometerHBH@ganler

@tvm-bot

tvm-bot commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

ganler
ganler approved these changes Mar 15, 2023
View reviewed changes

@ganlerganler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments on documentation improvements.

Comment threadpython/tvm/relax/dpl/pattern.py Outdated
Comment threadpython/tvm/relax/dpl/pattern.py Outdated
Comment threadpython/tvm/relax/dpl/pattern.py Outdated
Comment threadtests/python/relax/test_dataflow_pattern.py
@ganler

ganler commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Thanks for providing more examples and documentation. It looks great now!

Hzfengsy
Hzfengsy approved these changes Mar 16, 2023
View reviewed changes

@HzfengsyHzfengsy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful tools, thanks @masahi

sunggg
sunggg reviewed Mar 16, 2023
View reviewed changes

@sungggsunggg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for filling the missing piece!
LGTM.
One question. What happens if we try to rewrite to something invalid?

@masahi

masahi commented Mar 16, 2023

Copy link
Copy Markdown
MemberAuthor

One question. What happens if we try to rewrite to something invalid?

Well, you'd just get an error somewhere, as with any other ExprMutator passes.

@masahi
masahi merged commit cb6efae into apache:unityMar 16, 2023
tqchen pushed a commit that referenced this pull request Mar 20, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
f5ee097
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
@masahimasahi mentioned this pull request Mar 31, 2023
Merged
tqchen pushed a commit that referenced this pull request Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
1a72441
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit that referenced this pull request Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
89f54c9
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit that referenced this pull request Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
4bfbd3a
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sungggsungggsunggg left review comments
@HzfengsyHzfengsyHzfengsy approved these changes
+1 more reviewer
@ganlerganlerganler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@masahi@tvm-bot@ganler@Hzfengsy@sunggg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Unity] Support pattern-based rewriting by masahi · Pull Request #14312 · apache/tvm · GitHub
Skip to content
[Unity] Support pattern-based rewriting - #14312
Merged
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Mar 16, 2023
Merged
[Unity] Support pattern-based rewriting#14312
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Conversation
@masahi
@masahimasahi
commented
Mar 15, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Currently, dataflow pattern matching in Relax only supports matching with boolean result and doesn't support rewriting matched expressions. This PR adds such utility following the Relay counterpart below (with a simpler API).
tvm/python/tvm/relay/dataflow_pattern/__init__.py

Line 884
in
da99e9d
defrewrite(callbacks, expr: Expr, mod: Optional[_ir.IRModule] =None) ->Expr: 
This is useful for, for example, rewriting a sequence of matmul -> softmax -> matmul into an attention op introduced in #14150.
@cyx-6@sunggg@vinx13@yelite@MasterJH5574@spectrometerHBH@ganler
@tvm-bot
tvm-bot
commented
Mar 15, 2023

Copy link


Copy Markdown

Collaborator
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot
ganler
ganler
approved these changes
Mar 15, 2023
View reviewed changes
@ganlerganler
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments on documentation improvements.
Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadtests/python/relax/test_dataflow_pattern.py
@ganler
ganler
commented
Mar 15, 2023

Copy link


Copy Markdown

Contributor
Thanks for providing more examples and documentation. It looks great now!
Hzfengsy
Hzfengsy
approved these changes
Mar 16, 2023
View reviewed changes
@HzfengsyHzfengsy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful tools, thanks @masahi
sunggg
sunggg
reviewed
Mar 16, 2023
View reviewed changes
@sungggsunggg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for filling the missing piece!

LGTM.

One question. What happens if we try to rewrite to something invalid?
@masahi
masahi
commented
Mar 16, 2023

Copy link


Copy Markdown

MemberAuthor
One question. What happens if we try to rewrite to something invalid?
Well, you'd just get an error somewhere, as with any other ExprMutator passes.
@masahi
masahi
merged commit cb6efae
into
apache:unityMar 16, 2023
tqchen pushed a commit
that referenced
this pull request
Mar 20, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
f5ee097
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
@masahimasahi
mentioned this pull request
Mar 31, 2023
 Merged

tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
1a72441
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
89f54c9
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
4bfbd3a
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sungggsungggsunggg left review comments
@HzfengsyHzfengsyHzfengsy approved these changes

+1 more reviewer

@ganlerganlerganler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@masahi@tvm-bot@ganler@Hzfengsy@sunggg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Unity] Support pattern-based rewriting by masahi · Pull Request #14312 · apache/tvm · GitHub
Skip to content
[Unity] Support pattern-based rewriting - #14312
Merged
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Mar 16, 2023
Merged
[Unity] Support pattern-based rewriting#14312
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Conversation
@masahi
@masahimasahi
commented
Mar 15, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Currently, dataflow pattern matching in Relax only supports matching with boolean result and doesn't support rewriting matched expressions. This PR adds such utility following the Relay counterpart below (with a simpler API).
tvm/python/tvm/relay/dataflow_pattern/__init__.py

Line 884
in
da99e9d
defrewrite(callbacks, expr: Expr, mod: Optional[_ir.IRModule] =None) ->Expr: 
This is useful for, for example, rewriting a sequence of matmul -> softmax -> matmul into an attention op introduced in #14150.
@cyx-6@sunggg@vinx13@yelite@MasterJH5574@spectrometerHBH@ganler
@tvm-bot
tvm-bot
commented
Mar 15, 2023

Copy link


Copy Markdown

Collaborator
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot
ganler
ganler
approved these changes
Mar 15, 2023
View reviewed changes
@ganlerganler
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments on documentation improvements.
Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadtests/python/relax/test_dataflow_pattern.py
@ganler
ganler
commented
Mar 15, 2023

Copy link


Copy Markdown

Contributor
Thanks for providing more examples and documentation. It looks great now!
Hzfengsy
Hzfengsy
approved these changes
Mar 16, 2023
View reviewed changes
@HzfengsyHzfengsy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful tools, thanks @masahi
sunggg
sunggg
reviewed
Mar 16, 2023
View reviewed changes
@sungggsunggg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for filling the missing piece!

LGTM.

One question. What happens if we try to rewrite to something invalid?
@masahi
masahi
commented
Mar 16, 2023

Copy link


Copy Markdown

MemberAuthor
One question. What happens if we try to rewrite to something invalid?
Well, you'd just get an error somewhere, as with any other ExprMutator passes.
@masahi
masahi
merged commit cb6efae
into
apache:unityMar 16, 2023
tqchen pushed a commit
that referenced
this pull request
Mar 20, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
f5ee097
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
@masahimasahi
mentioned this pull request
Mar 31, 2023
 Merged

tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
1a72441
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
89f54c9
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
4bfbd3a
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sungggsungggsunggg left review comments
@HzfengsyHzfengsyHzfengsy approved these changes

+1 more reviewer

@ganlerganlerganler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@masahi@tvm-bot@ganler@Hzfengsy@sunggg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Unity] Support pattern-based rewriting by masahi · Pull Request #14312 · apache/tvm · GitHub
Skip to content
[Unity] Support pattern-based rewriting - #14312
Merged
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Mar 16, 2023
Merged
[Unity] Support pattern-based rewriting#14312
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Conversation
@masahi
@masahimasahi
commented
Mar 15, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Currently, dataflow pattern matching in Relax only supports matching with boolean result and doesn't support rewriting matched expressions. This PR adds such utility following the Relay counterpart below (with a simpler API).
tvm/python/tvm/relay/dataflow_pattern/__init__.py

Line 884
in
da99e9d
defrewrite(callbacks, expr: Expr, mod: Optional[_ir.IRModule] =None) ->Expr: 
This is useful for, for example, rewriting a sequence of matmul -> softmax -> matmul into an attention op introduced in #14150.
@cyx-6@sunggg@vinx13@yelite@MasterJH5574@spectrometerHBH@ganler
@tvm-bot
tvm-bot
commented
Mar 15, 2023

Copy link


Copy Markdown

Collaborator
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot
ganler
ganler
approved these changes
Mar 15, 2023
View reviewed changes
@ganlerganler
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments on documentation improvements.
Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadtests/python/relax/test_dataflow_pattern.py
@ganler
ganler
commented
Mar 15, 2023

Copy link


Copy Markdown

Contributor
Thanks for providing more examples and documentation. It looks great now!
Hzfengsy
Hzfengsy
approved these changes
Mar 16, 2023
View reviewed changes
@HzfengsyHzfengsy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful tools, thanks @masahi
sunggg
sunggg
reviewed
Mar 16, 2023
View reviewed changes
@sungggsunggg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for filling the missing piece!

LGTM.

One question. What happens if we try to rewrite to something invalid?
@masahi
masahi
commented
Mar 16, 2023

Copy link


Copy Markdown

MemberAuthor
One question. What happens if we try to rewrite to something invalid?
Well, you'd just get an error somewhere, as with any other ExprMutator passes.
@masahi
masahi
merged commit cb6efae
into
apache:unityMar 16, 2023
tqchen pushed a commit
that referenced
this pull request
Mar 20, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
f5ee097
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
@masahimasahi
mentioned this pull request
Mar 31, 2023
 Merged

tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
1a72441
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
89f54c9
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
4bfbd3a
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sungggsungggsunggg left review comments
@HzfengsyHzfengsyHzfengsy approved these changes

+1 more reviewer

@ganlerganlerganler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@masahi@tvm-bot@ganler@Hzfengsy@sunggg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[Unity] Support pattern-based rewriting by masahi · Pull Request #14312 · apache/tvm · GitHub
Skip to content
[Unity] Support pattern-based rewriting - #14312
Merged
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Mar 16, 2023
Merged
[Unity] Support pattern-based rewriting#14312
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Conversation
@masahi
@masahimasahi
commented
Mar 15, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Currently, dataflow pattern matching in Relax only supports matching with boolean result and doesn't support rewriting matched expressions. This PR adds such utility following the Relay counterpart below (with a simpler API).
tvm/python/tvm/relay/dataflow_pattern/__init__.py

Line 884
in
da99e9d
defrewrite(callbacks, expr: Expr, mod: Optional[_ir.IRModule] =None) ->Expr: 
This is useful for, for example, rewriting a sequence of matmul -> softmax -> matmul into an attention op introduced in #14150.
@cyx-6@sunggg@vinx13@yelite@MasterJH5574@spectrometerHBH@ganler
@tvm-bot
tvm-bot
commented
Mar 15, 2023

Copy link


Copy Markdown

Collaborator
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot
ganler
ganler
approved these changes
Mar 15, 2023
View reviewed changes
@ganlerganler
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments on documentation improvements.
Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadtests/python/relax/test_dataflow_pattern.py
@ganler
ganler
commented
Mar 15, 2023

Copy link


Copy Markdown

Contributor
Thanks for providing more examples and documentation. It looks great now!
Hzfengsy
Hzfengsy
approved these changes
Mar 16, 2023
View reviewed changes
@HzfengsyHzfengsy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful tools, thanks @masahi
sunggg
sunggg
reviewed
Mar 16, 2023
View reviewed changes
@sungggsunggg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for filling the missing piece!

LGTM.

One question. What happens if we try to rewrite to something invalid?
@masahi
masahi
commented
Mar 16, 2023

Copy link


Copy Markdown

MemberAuthor
One question. What happens if we try to rewrite to something invalid?
Well, you'd just get an error somewhere, as with any other ExprMutator passes.
@masahi
masahi
merged commit cb6efae
into
apache:unityMar 16, 2023
tqchen pushed a commit
that referenced
this pull request
Mar 20, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
f5ee097
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
@masahimasahi
mentioned this pull request
Mar 31, 2023
 Merged

tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
1a72441
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
89f54c9
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
4bfbd3a
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sungggsungggsunggg left review comments
@HzfengsyHzfengsyHzfengsy approved these changes

+1 more reviewer

@ganlerganlerganler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@masahi@tvm-bot@ganler@Hzfengsy@sunggg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Unity] Support pattern-based rewriting by masahi · Pull Request #14312 · apache/tvm · GitHub
Skip to content
[Unity] Support pattern-based rewriting - #14312
Merged
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Mar 16, 2023
Merged
[Unity] Support pattern-based rewriting#14312
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Conversation
@masahi
@masahimasahi
commented
Mar 15, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Currently, dataflow pattern matching in Relax only supports matching with boolean result and doesn't support rewriting matched expressions. This PR adds such utility following the Relay counterpart below (with a simpler API).
tvm/python/tvm/relay/dataflow_pattern/__init__.py

Line 884
in
da99e9d
defrewrite(callbacks, expr: Expr, mod: Optional[_ir.IRModule] =None) ->Expr: 
This is useful for, for example, rewriting a sequence of matmul -> softmax -> matmul into an attention op introduced in #14150.
@cyx-6@sunggg@vinx13@yelite@MasterJH5574@spectrometerHBH@ganler
@tvm-bot
tvm-bot
commented
Mar 15, 2023

Copy link


Copy Markdown

Collaborator
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot
ganler
ganler
approved these changes
Mar 15, 2023
View reviewed changes
@ganlerganler
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments on documentation improvements.
Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadtests/python/relax/test_dataflow_pattern.py
@ganler
ganler
commented
Mar 15, 2023

Copy link


Copy Markdown

Contributor
Thanks for providing more examples and documentation. It looks great now!
Hzfengsy
Hzfengsy
approved these changes
Mar 16, 2023
View reviewed changes
@HzfengsyHzfengsy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful tools, thanks @masahi
sunggg
sunggg
reviewed
Mar 16, 2023
View reviewed changes
@sungggsunggg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for filling the missing piece!

LGTM.

One question. What happens if we try to rewrite to something invalid?
@masahi
masahi
commented
Mar 16, 2023

Copy link


Copy Markdown

MemberAuthor
One question. What happens if we try to rewrite to something invalid?
Well, you'd just get an error somewhere, as with any other ExprMutator passes.
@masahi
masahi
merged commit cb6efae
into
apache:unityMar 16, 2023
tqchen pushed a commit
that referenced
this pull request
Mar 20, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
f5ee097
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
@masahimasahi
mentioned this pull request
Mar 31, 2023
 Merged

tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
1a72441
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
89f54c9
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
4bfbd3a
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sungggsungggsunggg left review comments
@HzfengsyHzfengsyHzfengsy approved these changes

+1 more reviewer

@ganlerganlerganler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@masahi@tvm-bot@ganler@Hzfengsy@sunggg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[Unity] Support pattern-based rewriting by masahi · Pull Request #14312 · apache/tvm · GitHub
Skip to content
[Unity] Support pattern-based rewriting - #14312
Merged
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Mar 16, 2023
Merged
[Unity] Support pattern-based rewriting#14312
masahi merged 12 commits into
apache:unityfrom 
masahi:pattern-rewriting
Conversation
@masahi
@masahimasahi
commented
Mar 15, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Currently, dataflow pattern matching in Relax only supports matching with boolean result and doesn't support rewriting matched expressions. This PR adds such utility following the Relay counterpart below (with a simpler API).
tvm/python/tvm/relay/dataflow_pattern/__init__.py

Line 884
in
da99e9d
defrewrite(callbacks, expr: Expr, mod: Optional[_ir.IRModule] =None) ->Expr: 
This is useful for, for example, rewriting a sequence of matmul -> softmax -> matmul into an attention op introduced in #14150.
@cyx-6@sunggg@vinx13@yelite@MasterJH5574@spectrometerHBH@ganler
@tvm-bot
tvm-bot
commented
Mar 15, 2023

Copy link


Copy Markdown

Collaborator
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot
ganler
ganler
approved these changes
Mar 15, 2023
View reviewed changes
@ganlerganler
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments on documentation improvements.
Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadpython/tvm/relax/dpl/pattern.py
Outdated

Comment threadtests/python/relax/test_dataflow_pattern.py
@ganler
ganler
commented
Mar 15, 2023

Copy link


Copy Markdown

Contributor
Thanks for providing more examples and documentation. It looks great now!
Hzfengsy
Hzfengsy
approved these changes
Mar 16, 2023
View reviewed changes
@HzfengsyHzfengsy
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful tools, thanks @masahi
sunggg
sunggg
reviewed
Mar 16, 2023
View reviewed changes
@sungggsunggg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for filling the missing piece!

LGTM.

One question. What happens if we try to rewrite to something invalid?
@masahi
masahi
commented
Mar 16, 2023

Copy link


Copy Markdown

MemberAuthor
One question. What happens if we try to rewrite to something invalid?
Well, you'd just get an error somewhere, as with any other ExprMutator passes.
@masahi
masahi
merged commit cb6efae
into
apache:unityMar 16, 2023
tqchen pushed a commit
that referenced
this pull request
Mar 20, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
f5ee097
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
@masahimasahi
mentioned this pull request
Mar 31, 2023
 Merged

tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
1a72441
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
89f54c9
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
tqchen pushed a commit
that referenced
this pull request
Apr 1, 2023
@masahi@tqchen
[Unity] Support pattern-based rewriting (#14312)
4bfbd3a
* stub
* wip
* works
* restore binding
* attention test work
* use RemoveAllUnused
* simplified callback api
* pass original call node to callback
* clean test
* add doc
* add test for the case where the original call is returned
* callback -> rewriter and other doc improvement
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sungggsungggsunggg left review comments
@HzfengsyHzfengsyHzfengsy approved these changes

+1 more reviewer

@ganlerganlerganler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@masahi@tvm-bot@ganler@Hzfengsy@sunggg