[Unity] Recursive pattern match in rewrite_call by Lunderberg · Pull Request #15495 · apache/tvm

Lunderberg · 2023-08-06T15:50:13Z

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once.

This commit updates PatternMatcher to iterate until convergence when provided with a pattern, analogous to its current behavior when called through rewrite_bindings.

tvm-bot · 2023-08-06T15:50:16Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @quic-sanirudh_{See #10317 for details}

_{Generated by tvm-bot}

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once. This commit updates `PatternMatcher` to iterate until convergence when provided with a pattern, analogous to its current behavior when called through `rewrite_bindings`.

kparzysz-quic

We should probably add some guards against looping forever eventually in the fixed point rewriting.

Lunderberg · 2023-08-06T15:50:13Z

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once.

This commit updates PatternMatcher to iterate until convergence when provided with a pattern, analogous to its current behavior when called through rewrite_bindings.

tvm-bot · 2023-08-06T15:50:16Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @quic-sanirudh_{See #10317 for details}

_{Generated by tvm-bot}

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once. This commit updates `PatternMatcher` to iterate until convergence when provided with a pattern, analogous to its current behavior when called through `rewrite_bindings`.

kparzysz-quic

We should probably add some guards against looping forever eventually in the fixed point rewriting.

Lunderberg · 2023-08-06T15:50:13Z

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once.

This commit updates PatternMatcher to iterate until convergence when provided with a pattern, analogous to its current behavior when called through rewrite_bindings.

tvm-bot · 2023-08-06T15:50:16Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @quic-sanirudh_{See #10317 for details}

_{Generated by tvm-bot}

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once. This commit updates `PatternMatcher` to iterate until convergence when provided with a pattern, analogous to its current behavior when called through `rewrite_bindings`.

kparzysz-quic

We should probably add some guards against looping forever eventually in the fixed point rewriting.

Lunderberg · 2023-08-06T15:50:13Z

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once.

This commit updates PatternMatcher to iterate until convergence when provided with a pattern, analogous to its current behavior when called through rewrite_bindings.

tvm-bot · 2023-08-06T15:50:16Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @quic-sanirudh_{See #10317 for details}

_{Generated by tvm-bot}

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once. This commit updates `PatternMatcher` to iterate until convergence when provided with a pattern, analogous to its current behavior when called through `rewrite_bindings`.

kparzysz-quic

We should probably add some guards against looping forever eventually in the fixed point rewriting.

Lunderberg · 2023-08-06T15:50:13Z

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once.

This commit updates PatternMatcher to iterate until convergence when provided with a pattern, analogous to its current behavior when called through rewrite_bindings.

tvm-bot · 2023-08-06T15:50:16Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @quic-sanirudh_{See #10317 for details}

_{Generated by tvm-bot}

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once. This commit updates `PatternMatcher` to iterate until convergence when provided with a pattern, analogous to its current behavior when called through `rewrite_bindings`.

kparzysz-quic

We should probably add some guards against looping forever eventually in the fixed point rewriting.

Lunderberg · 2023-08-06T15:50:13Z

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once.

This commit updates PatternMatcher to iterate until convergence when provided with a pattern, analogous to its current behavior when called through rewrite_bindings.

tvm-bot · 2023-08-06T15:50:16Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @quic-sanirudh_{See #10317 for details}

_{Generated by tvm-bot}

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once. This commit updates `PatternMatcher` to iterate until convergence when provided with a pattern, analogous to its current behavior when called through `rewrite_bindings`.

kparzysz-quic

We should probably add some guards against looping forever eventually in the fixed point rewriting.

Lunderberg · 2023-08-06T15:50:13Z

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once.

This commit updates PatternMatcher to iterate until convergence when provided with a pattern, analogous to its current behavior when called through rewrite_bindings.

tvm-bot · 2023-08-06T15:50:16Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

cc @quic-sanirudh_{See #10317 for details}

_{Generated by tvm-bot}

Prior to this commit, pattern matches were evaluated a single time, in the order of the block bindings. If a pattern rewrite produced a node which would also match the pattern (e.g. recursive reordering), the pattern would still only be evaluated once. This commit updates `PatternMatcher` to iterate until convergence when provided with a pattern, analogous to its current behavior when called through `rewrite_bindings`.

kparzysz-quic

We should probably add some guards against looping forever eventually in the fixed point rewriting.

Lunderberg force-pushed the pattern_match_rewrite_call_recursive branch from a4125ec to 896d058Compare August 6, 2023 20:22

Lunderberg force-pushed the pattern_match_rewrite_call_recursive branch from 896d058 to 4da8f3cCompare August 7, 2023 20:43