Uh oh!
There was an error while loading. Please reload this page.
[Unity][Analysis] Change warning to info for non-affine transform - #15820
Merged
quic-sanirudh merged 2 commits intoSep 27, 2023
Merged
Conversation
A `PrimFunc` may contain transformations that are not affine, or that are not recognizable as being affine. Prior to this commit, this produced a `LOG(WARNING)` stating that this was an error in the index analysis. Because this is the expected behavior for these functions, this commit updates the message to instead write to `DLOG(INFO)`. The other uses of `LOG(WARNING)` inside `layout_transformation.cc` are kept as-is, as they relate to limitations of the analysis, rather than being a statement about the analyzed `PrimFunc`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
PrimFuncmay contain transformations that are not affine, or that are not recognizable as being affine. Prior to this commit, this produced aLOG(WARNING)stating that this was an error in the index analysis. Because this is the expected behavior for these functions, this commit updates the message to instead write toDLOG(INFO).The other uses of
LOG(WARNING)insidelayout_transformation.ccare kept as-is, as they relate to limitations of the analysis, rather than being a statement about the analyzedPrimFunc.