[Runtime][Disco] Restore checks for hangup of disco pipe by Lunderberg · Pull Request #16997 · apache/tvm

Lunderberg · 2024-05-14T15:32:38Z

This resolves a conflict between two recent changes. In #16989, reads of size zero are used to identify hangups in ProcessSession. In #16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready.

For a long-term resolution, the dmlc::Stream interface will need to be updated, so that the Write method returns the number of bytes written, just as the Read method currently does. This will allow the calling scope to verify the number of bytes received.

This resolves a conflict between two recent changes. In apache#16989, reads of size zero are used to identify hangups in `ProcessSession`. In apache#16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready. For a long-term resolution, the `dmlc::Stream` interface will need to be updated, so that the `Write` method returns the number of bytes written, just as the `Read` method currently does. This will allow the calling scope to verify the number of bytes received.

Lunderberg · 2024-05-14T15:32:38Z

This resolves a conflict between two recent changes. In #16989, reads of size zero are used to identify hangups in ProcessSession. In #16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready.

For a long-term resolution, the dmlc::Stream interface will need to be updated, so that the Write method returns the number of bytes written, just as the Read method currently does. This will allow the calling scope to verify the number of bytes received.

This resolves a conflict between two recent changes. In apache#16989, reads of size zero are used to identify hangups in `ProcessSession`. In apache#16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready. For a long-term resolution, the `dmlc::Stream` interface will need to be updated, so that the `Write` method returns the number of bytes written, just as the `Read` method currently does. This will allow the calling scope to verify the number of bytes received.

Lunderberg · 2024-05-14T15:32:38Z

This resolves a conflict between two recent changes. In #16989, reads of size zero are used to identify hangups in ProcessSession. In #16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready.

For a long-term resolution, the dmlc::Stream interface will need to be updated, so that the Write method returns the number of bytes written, just as the Read method currently does. This will allow the calling scope to verify the number of bytes received.

This resolves a conflict between two recent changes. In apache#16989, reads of size zero are used to identify hangups in `ProcessSession`. In apache#16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready. For a long-term resolution, the `dmlc::Stream` interface will need to be updated, so that the `Write` method returns the number of bytes written, just as the `Read` method currently does. This will allow the calling scope to verify the number of bytes received.

Lunderberg · 2024-05-14T15:32:38Z

This resolves a conflict between two recent changes. In #16989, reads of size zero are used to identify hangups in ProcessSession. In #16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready.

For a long-term resolution, the dmlc::Stream interface will need to be updated, so that the Write method returns the number of bytes written, just as the Read method currently does. This will allow the calling scope to verify the number of bytes received.

This resolves a conflict between two recent changes. In apache#16989, reads of size zero are used to identify hangups in `ProcessSession`. In apache#16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready. For a long-term resolution, the `dmlc::Stream` interface will need to be updated, so that the `Write` method returns the number of bytes written, just as the `Read` method currently does. This will allow the calling scope to verify the number of bytes received.

Lunderberg · 2024-05-14T15:32:38Z

This resolves a conflict between two recent changes. In #16989, reads of size zero are used to identify hangups in ProcessSession. In #16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready.

For a long-term resolution, the dmlc::Stream interface will need to be updated, so that the Write method returns the number of bytes written, just as the Read method currently does. This will allow the calling scope to verify the number of bytes received.

This resolves a conflict between two recent changes. In apache#16989, reads of size zero are used to identify hangups in `ProcessSession`. In apache#16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready. For a long-term resolution, the `dmlc::Stream` interface will need to be updated, so that the `Write` method returns the number of bytes written, just as the `Read` method currently does. This will allow the calling scope to verify the number of bytes received.

Lunderberg · 2024-05-14T15:32:38Z

This resolves a conflict between two recent changes. In #16989, reads of size zero are used to identify hangups in ProcessSession. In #16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready.

For a long-term resolution, the dmlc::Stream interface will need to be updated, so that the Write method returns the number of bytes written, just as the Read method currently does. This will allow the calling scope to verify the number of bytes received.

This resolves a conflict between two recent changes. In apache#16989, reads of size zero are used to identify hangups in `ProcessSession`. In apache#16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready. For a long-term resolution, the `dmlc::Stream` interface will need to be updated, so that the `Write` method returns the number of bytes written, just as the `Read` method currently does. This will allow the calling scope to verify the number of bytes received.

Lunderberg · 2024-05-14T15:32:38Z

This resolves a conflict between two recent changes. In #16989, reads of size zero are used to identify hangups in ProcessSession. In #16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready.

For a long-term resolution, the dmlc::Stream interface will need to be updated, so that the Write method returns the number of bytes written, just as the Read method currently does. This will allow the calling scope to verify the number of bytes received.

This resolves a conflict between two recent changes. In apache#16989, reads of size zero are used to identify hangups in `ProcessSession`. In apache#16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready. For a long-term resolution, the `dmlc::Stream` interface will need to be updated, so that the `Write` method returns the number of bytes written, just as the `Read` method currently does. This will allow the calling scope to verify the number of bytes received.

Lunderberg · 2024-05-14T15:32:38Z

This resolves a conflict between two recent changes. In #16989, reads of size zero are used to identify hangups in ProcessSession. In #16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready.

For a long-term resolution, the dmlc::Stream interface will need to be updated, so that the Write method returns the number of bytes written, just as the Read method currently does. This will allow the calling scope to verify the number of bytes received.

This resolves a conflict between two recent changes. In apache#16989, reads of size zero are used to identify hangups in `ProcessSession`. In apache#16992, reads of size zero are treated as an error to avoid infinite loops while waiting for data to be ready. For a long-term resolution, the `dmlc::Stream` interface will need to be updated, so that the `Write` method returns the number of bytes written, just as the `Read` method currently does. This will allow the calling scope to verify the number of bytes received.

tqchen approved these changes May 14, 2024
View reviewed changes

Lunderberg merged commit f044eef into apache:mainMay 15, 2024

Lunderberg deleted the disco_restore_check_for_hangup_on_pipe branch May 15, 2024 13:16

ysh329 mentioned this pull request Jul 20, 2024
[Release] v0.17.0 Release Candidate Notes #17178
Closed